You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/04/20 02:03:35 UTC

[GitHub] [apisix-ingress-controller] Gallardot commented on pull request #968: chore: Fix some code formats

Gallardot commented on PR #968:
URL: https://github.com/apache/apisix-ingress-controller/pull/968#issuecomment-1103372728

   > Thank you for your contribution, I checked golang's documentation and haven't found any instructions about having to have a blank line after the license header file.
   > 
   > Can you explain the need for this modification?
   
   
   It's just that some files have a newline after the license header and some don't. Just to keep the code in a consistent format.
   
   
   > Shouldn't code format be handled by lint or format tools? 🤔
   
   Agree, maybe current tools don't cover this detail. Maybe we can make some adjustments back there.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org