You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by ni...@apache.org on 2019/07/01 05:55:11 UTC
[incubator-druid] branch master updated: Enable
RCN_REDUNDANT_NULLCHECK_OF_NULL_VALUE (#7972)
This is an automated email from the ASF dual-hosted git repository.
nishant pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-druid.git
The following commit(s) were added to refs/heads/master by this push:
new 4508d3f Enable RCN_REDUNDANT_NULLCHECK_OF_NULL_VALUE (#7972)
4508d3f is described below
commit 4508d3ff55a0e33d5bbcbb9d65f097543f4741c0
Author: Fokko Driesprong <fo...@apache.org>
AuthorDate: Mon Jul 1 07:55:06 2019 +0200
Enable RCN_REDUNDANT_NULLCHECK_OF_NULL_VALUE (#7972)
---
codestyle/spotbugs-exclude.xml | 1 -
.../druid/indexing/overlord/SingleTaskBackgroundRunner.java | 8 +-------
2 files changed, 1 insertion(+), 8 deletions(-)
diff --git a/codestyle/spotbugs-exclude.xml b/codestyle/spotbugs-exclude.xml
index 639fab7..4fafbc4 100644
--- a/codestyle/spotbugs-exclude.xml
+++ b/codestyle/spotbugs-exclude.xml
@@ -76,7 +76,6 @@
<Bug pattern="OBL_UNSATISFIED_OBLIGATION"/>
<Bug pattern="OS_OPEN_STREAM"/>
<Bug pattern="RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE"/>
- <Bug pattern="RCN_REDUNDANT_NULLCHECK_OF_NULL_VALUE"/>
<Bug pattern="RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE"/>
<Bug pattern="RC_REF_COMPARISON_BAD_PRACTICE_BOOLEAN"/>
<Bug pattern="REC_CATCH_EXCEPTION"/>
diff --git a/indexing-service/src/main/java/org/apache/druid/indexing/overlord/SingleTaskBackgroundRunner.java b/indexing-service/src/main/java/org/apache/druid/indexing/overlord/SingleTaskBackgroundRunner.java
index cb222ea..e814cc3 100644
--- a/indexing-service/src/main/java/org/apache/druid/indexing/overlord/SingleTaskBackgroundRunner.java
+++ b/indexing-service/src/main/java/org/apache/druid/indexing/overlord/SingleTaskBackgroundRunner.java
@@ -330,13 +330,7 @@ public class SingleTaskBackgroundRunner implements TaskRunner, QuerySegmentWalke
final QueryRunner<T> taskQueryRunner = task.getQueryRunner(query);
if (taskQueryRunner != null) {
- if (queryRunner == null) {
- queryRunner = taskQueryRunner;
- } else {
- log.makeAlert("Found too many query runners for datasource")
- .addData("dataSource", queryDataSource)
- .emit();
- }
+ queryRunner = taskQueryRunner;
}
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org