[GitHub] bigtop pull request #141: BIGTOP-2523. Incorrect cycle dependency during pup...

[c0s <gi...@git.apache.org>]

Github user c0s commented on a diff in the pull request:

    https://github.com/apache/bigtop/pull/141#discussion_r76845555
  
    --- Diff: bigtop_toolchain/bin/puppetize.sh ---
    @@ -54,8 +54,13 @@ case ${ID}-${VERSION_ID} in
     	apt-get -y install curl sudo unzip wget puppet software-properties-common
     	;;
         debian-8*)
    +    apt-get update
    +	apt-get -y install wget
    +	# BIGTOP-2523. in order to install puppet 3.8 we need to get it from puppet repo
    +	wget -O /tmp/puppetlabs-release-trusty.deb https://apt.puppetlabs.com/puppetlabs-release-trusty.deb && dpkg -i /tmp/puppetlabs-release-trusty.deb
    +	rm -f /tmp/puppetlabs-release-trusty.deb
     	apt-get update
    -	apt-get -y install curl sudo unzip wget puppet
    +    apt-get -y install curl sudo unzip puppet
    --- End diff --
    
    this looks like a formatting change, irrelevant to the scope


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---