You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/09/02 06:01:47 UTC

[GitHub] [spark] maryannxue commented on a change in pull request #29593: [SPARK-32753][SQL] Do not override when copying tags

maryannxue commented on a change in pull request #29593:
URL: https://github.com/apache/spark/pull/29593#discussion_r481756127



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/adaptive/AdaptiveQueryExecSuite.scala
##########
@@ -1205,4 +1205,13 @@ class AdaptiveQueryExecSuite
       })
     }
   }
+
+  test("SPARK-32753: Do not override when copying tags") {
+    withSQLConf(
+      SQLConf.ADAPTIVE_EXECUTION_ENABLED.key -> "true"
+    ) {
+      spark.range(10).union(spark.range(10)).createOrReplaceTempView("v1")
+      runAdaptiveAndVerifyResult("SELECT id FROM v1 GROUP BY id DISTRIBUTE BY id")

Review comment:
       we can also check the plan here to make sure the repartition did get removed.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org