You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@impala.apache.org by "Michael Ho (Code Review)" <ge...@cloudera.org> on 2016/03/17 00:37:31 UTC

[Impala-CR](cdh5-trunk) IMPALA-2399: Memory limit checks for all scanners.

Michael Ho has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/2568

Change subject: IMPALA-2399: Memory limit checks for all scanners.
......................................................................

IMPALA-2399: Memory limit checks for all scanners.

This change replaces all instances of MemPool::Allocate() in
avro, text, hbase scanners with MemPool::TryAllocate().

HdfsAvroScanner::MaterializeTuple() has been converted to return
a boolean in case of memory allocation failure. The codegen'ed
version of MaterializeTuple() will also return a boolean. In the
future, we should consider returning Status directly but that will
be more involved and best left as a separate change.

Change-Id: I3e5a56501967a58513888917db5ce66dec4fb5ce
---
M be/src/exec/data-source-scan-node.cc
M be/src/exec/hbase-table-scanner.cc
M be/src/exec/hbase-table-scanner.h
M be/src/exec/hdfs-avro-scanner-ir.cc
M be/src/exec/hdfs-avro-scanner.cc
M be/src/exec/hdfs-avro-scanner.h
M be/src/exec/hdfs-parquet-scanner.cc
M be/src/exec/hdfs-scanner.cc
M be/src/exec/hdfs-sequence-scanner.cc
M be/src/exec/hdfs-text-scanner.cc
M be/src/exec/hdfs-text-scanner.h
M be/src/exec/scanner-context.cc
M be/src/exec/text-converter.h
M be/src/exec/text-converter.inline.h
M be/src/runtime/string-buffer.h
15 files changed, 266 insertions(+), 120 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/68/2568/1
-- 
To view, visit http://gerrit.cloudera.org:8080/2568
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3e5a56501967a58513888917db5ce66dec4fb5ce
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Michael Ho <kw...@cloudera.com>