You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2022/02/28 10:52:38 UTC

[GitHub] [ignite-3] tledkov-gridgain commented on a change in pull request #692: IGNITE-16558 Sql schema synchronization

tledkov-gridgain commented on a change in pull request #692:
URL: https://github.com/apache/ignite-3/pull/692#discussion_r815776812



##########
File path: modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/schema/SqlSchemaManagerImpl.java
##########
@@ -72,36 +79,73 @@ public SchemaPlus schema(@Nullable String schema) {
     /** {@inheritDoc} */
     @Override
     @NotNull

Review comment:
       - Two spaces between 'requiredVer={}' and 'latestKnownVer'
   - Should we use different exceptions for cases when table not found (normal flow, e.g. table dropped) and invalid schema version (breaks internal invariant)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org