[GitHub] michellethomas commented on a change in pull request #5237: [bubble-chart] Fixing issue w/ metric names

[GitBox <gi...@apache.org>]

michellethomas commented on a change in pull request #5237: [bubble-chart] Fixing issue w/ metric names
URL: https://github.com/apache/incubator-superset/pull/5237#discussion_r196186799
 
 

 ##########
 File path: superset/viz.py
 ##########
 @@ -947,9 +947,9 @@ def query_obj(self):
         return d
 
     def get_data(self, df):
-        df['x'] = df[[self.x_metric]]
-        df['y'] = df[[self.y_metric]]
-        df['size'] = df[[self.z_metric]]
+        df['x'] = df[[utils.get_metric_name(self.x_metric)]]
 
 Review comment:
   Any reason not to set self.x_metric to utils.get_metric_name(form_data.get('x'))? Is the full metric needed anywhere?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org