You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Wang Xixu (Code Review)" <ge...@cloudera.org> on 2023/02/12 07:55:28 UTC
[kudu-CR] [Tools] Remove enter key when listing non-existed table
Wang Xixu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19493
Change subject: [Tools] Remove enter key when listing non-existed table
......................................................................
[Tools] Remove enter key when listing non-existed table
Change-Id: I86fafc3c7df26d380b424b6d6b3f80a1b8d78dc8
---
M src/kudu/tools/tool_action_table.cc
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/93/19493/1
--
To view, visit http://gerrit.cloudera.org:8080/19493
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I86fafc3c7df26d380b424b6d6b3f80a1b8d78dc8
Gerrit-Change-Number: 19493
Gerrit-PatchSet: 1
Gerrit-Owner: Wang Xixu <14...@qq.com>
[kudu-CR] [Tools] Remove enter key when listing non-existed table
Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/19493 )
Change subject: [Tools] Remove enter key when listing non-existed table
......................................................................
Patch Set 5: -Code-Review
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19493/5//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/19493/5//COMMIT_MSG@10
PS5, Line 10: it ouputs an enter key and a new line appears
> I think, you can paste some outputs about old version and after this patch.
BTW, what is enter key?
--
To view, visit http://gerrit.cloudera.org:8080/19493
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I86fafc3c7df26d380b424b6d6b3f80a1b8d78dc8
Gerrit-Change-Number: 19493
Gerrit-PatchSet: 5
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Thu, 23 Feb 2023 07:37:14 +0000
Gerrit-HasComments: Yes
[kudu-CR] [Tools] Remove enter key when listing non-existed table
Posted by "Wang Xixu (Code Review)" <ge...@cloudera.org>.
Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19493 )
Change subject: [Tools] Remove enter key when listing non-existed table
......................................................................
Patch Set 5:
(1 comment)
> Patch Set 4:
>
> (1 comment)
http://gerrit.cloudera.org:8080/#/c/19493/4/src/kudu/tools/tool_action_table.cc
File src/kudu/tools/tool_action_table.cc:
http://gerrit.cloudera.org:8080/#/c/19493/4/src/kudu/tools/tool_action_table.cc@362
PS4, Line 362: cout << ToPrettyFormat(tables_info_pb) << endl;
> nit: add brackets
Done
--
To view, visit http://gerrit.cloudera.org:8080/19493
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I86fafc3c7df26d380b424b6d6b3f80a1b8d78dc8
Gerrit-Change-Number: 19493
Gerrit-PatchSet: 5
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Fri, 17 Feb 2023 02:18:20 +0000
Gerrit-HasComments: Yes
[kudu-CR] [Tools] Remove enter key when listing non-existed table
Posted by "Wang Xixu (Code Review)" <ge...@cloudera.org>.
Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19493 )
Change subject: [Tools] Remove enter key when listing non-existed table
......................................................................
Patch Set 5:
> Patch Set 5: -Code-Review
>
> (1 comment)
A new line.
--
To view, visit http://gerrit.cloudera.org:8080/19493
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I86fafc3c7df26d380b424b6d6b3f80a1b8d78dc8
Gerrit-Change-Number: 19493
Gerrit-PatchSet: 5
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Fri, 24 Feb 2023 04:40:34 +0000
Gerrit-HasComments: No
[kudu-CR] [Tools] Remove enter key when listing non-existed table
Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/19493 )
Change subject: [Tools] Remove enter key when listing non-existed table
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19493/2/src/kudu/tools/tool_action_table.cc
File src/kudu/tools/tool_action_table.cc:
http://gerrit.cloudera.org:8080/#/c/19493/2/src/kudu/tools/tool_action_table.cc@361
PS2, Line 361: if (tables_info_pb.tables().size() > 0)
what about:
if (!tables_info_pb.tables().empty()) {
cout << ToPrettyFormat(tables_info_pb) << endl;
}
or
if (iequals(FLAGS_list_table_output_format, "pretty") && !tables_info_pb.tables().empty()) {
cout << ToPrettyFormat(tables_info_pb) << endl;
}
--
To view, visit http://gerrit.cloudera.org:8080/19493
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I86fafc3c7df26d380b424b6d6b3f80a1b8d78dc8
Gerrit-Change-Number: 19493
Gerrit-PatchSet: 2
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Thu, 16 Feb 2023 07:07:26 +0000
Gerrit-HasComments: Yes
[kudu-CR] [Tools] Remove enter key when listing non-existed table
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19493 )
Change subject: [Tools] Remove enter key when listing non-existed table
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19493
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I86fafc3c7df26d380b424b6d6b3f80a1b8d78dc8
Gerrit-Change-Number: 19493
Gerrit-PatchSet: 5
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Wed, 22 Feb 2023 02:51:05 +0000
Gerrit-HasComments: No
[kudu-CR] [Tools] Remove enter key when listing non-existed table
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19493 )
Change subject: [Tools] Remove enter key when listing non-existed table
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19493/4/src/kudu/tools/tool_action_table.cc
File src/kudu/tools/tool_action_table.cc:
http://gerrit.cloudera.org:8080/#/c/19493/4/src/kudu/tools/tool_action_table.cc@362
PS4, Line 362: cout << ToPrettyFormat(tables_info_pb) << endl;
nit: add brackets
--
To view, visit http://gerrit.cloudera.org:8080/19493
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I86fafc3c7df26d380b424b6d6b3f80a1b8d78dc8
Gerrit-Change-Number: 19493
Gerrit-PatchSet: 4
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Thu, 16 Feb 2023 16:28:59 +0000
Gerrit-HasComments: Yes
[kudu-CR] [Tools] Remove enter key when listing non-existed table
Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Yifan Zhang has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19493 )
Change subject: [Tools] Remove enter key when listing non-existed table
......................................................................
[Tools] Remove enter key when listing non-existed table
When Kudu listing a non-existed table using command line tool,
it ouputs an enter key and a new line appears. But earlier
version does not output an enter key.
Therefore it is better to be compatible with old versions of
Kudu.
Change-Id: I86fafc3c7df26d380b424b6d6b3f80a1b8d78dc8
Reviewed-on: http://gerrit.cloudera.org:8080/19493
Tested-by: Kudu Jenkins
Reviewed-by: Yingchun Lai <la...@apache.org>
Reviewed-by: Yuqi Du <sh...@gmail.com>
Reviewed-by: Yifan Zhang <ch...@163.com>
---
M src/kudu/tools/kudu-admin-test.cc
M src/kudu/tools/tool_action_table.cc
2 files changed, 4 insertions(+), 3 deletions(-)
Approvals:
Kudu Jenkins: Verified
Yingchun Lai: Looks good to me, approved
Yuqi Du: Looks good to me, but someone else must approve
Yifan Zhang: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/19493
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I86fafc3c7df26d380b424b6d6b3f80a1b8d78dc8
Gerrit-Change-Number: 19493
Gerrit-PatchSet: 6
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
[kudu-CR] [Tools] Remove enter key when listing non-existed table
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19493 )
Change subject: [Tools] Remove enter key when listing non-existed table
......................................................................
Patch Set 5:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19493/5//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/19493/5//COMMIT_MSG@10
PS5, Line 10: it ouputs an enter key and a new line appears
> In my Python program, it uses this command line to judge whether a table ex
str.strip() may help?
--
To view, visit http://gerrit.cloudera.org:8080/19493
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I86fafc3c7df26d380b424b6d6b3f80a1b8d78dc8
Gerrit-Change-Number: 19493
Gerrit-PatchSet: 5
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Wed, 22 Feb 2023 02:50:49 +0000
Gerrit-HasComments: Yes
[kudu-CR] [Tools] Remove enter key when listing non-existed table
Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/19493 )
Change subject: [Tools] Remove enter key when listing non-existed table
......................................................................
Patch Set 5: Code-Review+1
(1 comment)
LGTM.
http://gerrit.cloudera.org:8080/#/c/19493/5//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/19493/5//COMMIT_MSG@10
PS5, Line 10: it ouputs an enter key and a new line appears
> str.strip() may help?
I think, you can paste some outputs about old version and after this patch.
--
To view, visit http://gerrit.cloudera.org:8080/19493
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I86fafc3c7df26d380b424b6d6b3f80a1b8d78dc8
Gerrit-Change-Number: 19493
Gerrit-PatchSet: 5
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Wed, 22 Feb 2023 04:43:39 +0000
Gerrit-HasComments: Yes
[kudu-CR] [Tools] Remove enter key when listing non-existed table
Posted by "Wang Xixu (Code Review)" <ge...@cloudera.org>.
Hello Yuqi Du, Yingchun Lai, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19493
to look at the new patch set (#5).
Change subject: [Tools] Remove enter key when listing non-existed table
......................................................................
[Tools] Remove enter key when listing non-existed table
When Kudu listing a non-existed table using command line tool,
it ouputs an enter key and a new line appears. But earlier
version does not output an enter key.
Therefore it is better to be compatible with old versions of
Kudu.
Change-Id: I86fafc3c7df26d380b424b6d6b3f80a1b8d78dc8
---
M src/kudu/tools/kudu-admin-test.cc
M src/kudu/tools/tool_action_table.cc
2 files changed, 4 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/93/19493/5
--
To view, visit http://gerrit.cloudera.org:8080/19493
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I86fafc3c7df26d380b424b6d6b3f80a1b8d78dc8
Gerrit-Change-Number: 19493
Gerrit-PatchSet: 5
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
[kudu-CR] [Tools] Remove enter key when listing non-existed table
Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19493 )
Change subject: [Tools] Remove enter key when listing non-existed table
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19493
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I86fafc3c7df26d380b424b6d6b3f80a1b8d78dc8
Gerrit-Change-Number: 19493
Gerrit-PatchSet: 5
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Fri, 24 Feb 2023 06:55:05 +0000
Gerrit-HasComments: No
[kudu-CR] [Tools] Remove enter key when listing non-existed table
Posted by "Wang Xixu (Code Review)" <ge...@cloudera.org>.
Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19493 )
Change subject: [Tools] Remove enter key when listing non-existed table
......................................................................
Patch Set 5:
(1 comment)
> Patch Set 5: Code-Review+1
>
> (1 comment)
http://gerrit.cloudera.org:8080/#/c/19493/5//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/19493/5//COMMIT_MSG@10
PS5, Line 10: it ouputs an enter key and a new line appears
> I'm curious about what issue this new line cause?
In my Python program, it uses this command line to judge whether a table existed. In old versions, it returns empty result if a table not existed, but in new versions, it return an enter key.
--
To view, visit http://gerrit.cloudera.org:8080/19493
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I86fafc3c7df26d380b424b6d6b3f80a1b8d78dc8
Gerrit-Change-Number: 19493
Gerrit-PatchSet: 5
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Wed, 22 Feb 2023 01:54:08 +0000
Gerrit-HasComments: Yes
[kudu-CR] [Tools] Remove enter key when listing non-existed table
Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/19493 )
Change subject: [Tools] Remove enter key when listing non-existed table
......................................................................
Patch Set 5: Code-Review+1
> Patch Set 5: -Code-Review
>
> (1 comment)
--
To view, visit http://gerrit.cloudera.org:8080/19493
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I86fafc3c7df26d380b424b6d6b3f80a1b8d78dc8
Gerrit-Change-Number: 19493
Gerrit-PatchSet: 5
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Thu, 23 Feb 2023 07:37:29 +0000
Gerrit-HasComments: No
[kudu-CR] [Tools] Remove enter key when listing non-existed table
Posted by "Wang Xixu (Code Review)" <ge...@cloudera.org>.
Hello Yuqi Du, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19493
to look at the new patch set (#4).
Change subject: [Tools] Remove enter key when listing non-existed table
......................................................................
[Tools] Remove enter key when listing non-existed table
When Kudu listing a non-existed table using command line tool,
it ouputs an enter key and a new line appears. But earlier
version does not output an enter key.
Therefore it is better to be compatible with old versions of
Kudu.
Change-Id: I86fafc3c7df26d380b424b6d6b3f80a1b8d78dc8
---
M src/kudu/tools/kudu-admin-test.cc
M src/kudu/tools/tool_action_table.cc
2 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/93/19493/4
--
To view, visit http://gerrit.cloudera.org:8080/19493
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I86fafc3c7df26d380b424b6d6b3f80a1b8d78dc8
Gerrit-Change-Number: 19493
Gerrit-PatchSet: 4
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
[kudu-CR] [Tools] Remove enter key when listing non-existed table
Posted by "Wang Xixu (Code Review)" <ge...@cloudera.org>.
Hello Yuqi Du, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19493
to look at the new patch set (#3).
Change subject: [Tools] Remove enter key when listing non-existed table
......................................................................
[Tools] Remove enter key when listing non-existed table
When Kudu listing a non-existed table using command line tool,
it ouputs an enter key and a new line appears. But earlier
version does not output an enter key.
Therefore it is better to be compatible with old versions of
Kudu.
Change-Id: I86fafc3c7df26d380b424b6d6b3f80a1b8d78dc8
---
M src/kudu/tools/tool_action_table.cc
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/93/19493/3
--
To view, visit http://gerrit.cloudera.org:8080/19493
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I86fafc3c7df26d380b424b6d6b3f80a1b8d78dc8
Gerrit-Change-Number: 19493
Gerrit-PatchSet: 3
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
[kudu-CR] [Tools] Remove enter key when listing non-existed table
Posted by "Wang Xixu (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19493
to look at the new patch set (#2).
Change subject: [Tools] Remove enter key when listing non-existed table
......................................................................
[Tools] Remove enter key when listing non-existed table
When Kudu listing a non-existed table using command line tool,
it ouputs an enter key and a new line appears. But earlier
version does not output an enter key.
Therefore it is better to be compatible with old versions of
Kudu.
Change-Id: I86fafc3c7df26d380b424b6d6b3f80a1b8d78dc8
---
M src/kudu/tools/tool_action_table.cc
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/93/19493/2
--
To view, visit http://gerrit.cloudera.org:8080/19493
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I86fafc3c7df26d380b424b6d6b3f80a1b8d78dc8
Gerrit-Change-Number: 19493
Gerrit-PatchSet: 2
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [Tools] Remove enter key when listing non-existed table
Posted by "Wang Xixu (Code Review)" <ge...@cloudera.org>.
Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19493 )
Change subject: [Tools] Remove enter key when listing non-existed table
......................................................................
Patch Set 4:
(1 comment)
> Patch Set 2:
>
> (1 comment)
http://gerrit.cloudera.org:8080/#/c/19493/2/src/kudu/tools/tool_action_table.cc
File src/kudu/tools/tool_action_table.cc:
http://gerrit.cloudera.org:8080/#/c/19493/2/src/kudu/tools/tool_action_table.cc@361
PS2, Line 361: if (!tables_info_pb.tables().empty())
> what about:
Good advice.
--
To view, visit http://gerrit.cloudera.org:8080/19493
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I86fafc3c7df26d380b424b6d6b3f80a1b8d78dc8
Gerrit-Change-Number: 19493
Gerrit-PatchSet: 4
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Thu, 16 Feb 2023 08:46:41 +0000
Gerrit-HasComments: Yes
[kudu-CR] [Tools] Remove enter key when listing non-existed table
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19493 )
Change subject: [Tools] Remove enter key when listing non-existed table
......................................................................
Patch Set 5: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19493/5//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/19493/5//COMMIT_MSG@10
PS5, Line 10: it ouputs an enter key and a new line appears
I'm curious about what issue this new line cause?
--
To view, visit http://gerrit.cloudera.org:8080/19493
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I86fafc3c7df26d380b424b6d6b3f80a1b8d78dc8
Gerrit-Change-Number: 19493
Gerrit-PatchSet: 5
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Tue, 21 Feb 2023 15:37:55 +0000
Gerrit-HasComments: Yes