[GitHub] [airflow] potiuk commented on a change in pull request #6681: [AIRFLOW-6089] Reorder setup.py dependencies and add ci

[GitBox <gi...@apache.org>]

potiuk commented on a change in pull request #6681: [AIRFLOW-6089] Reorder setup.py dependencies and add ci
URL: https://github.com/apache/airflow/pull/6681#discussion_r352274538
 
 

 ##########
 File path: CONTRIBUTING.rst
 ##########
 @@ -458,6 +458,8 @@ image built locally):
 ----------------------------------- ---------------------------------------------------------------- ------------
 ``rst-backticks``                     Checks if RST files use double backticks for code.
 ----------------------------------- ---------------------------------------------------------------- ------------
+``setup-order``                       Checks for an order of dependencies in setup.py
+----------------------------------- ---------------------------------------------------------------- ------------
 
 Review comment:
   It's explained above (and we have a change in progress that it gets explained better). It's exactly the difference whether it uses Docker Breeze image underneath or not. Your test initially used it (with the scripts etc.) but then now with "python" it does not use those images. So it's ok as it is.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services