You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/11/30 14:46:25 UTC

[GitHub] [incubator-nuttx] slorquet opened a new pull request #4920: Prevent creation of MTD partitions that span past the parent device.

slorquet opened a new pull request #4920:
URL: https://github.com/apache/incubator-nuttx/pull/4920


   When creating a partition, compare erase sector partition limits with parent device erase sector count, not write blocks.
   
   ## Summary
   you can create partitions larger than the parent device
   
   ## Impact
   this is bad
   
   ## Testing
   old code did not detect the error on my board
   
   new code does detect the problem


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] slorquet commented on pull request #4920: Prevent creation of MTD partitions that span past the parent device.

Posted by GitBox <gi...@apache.org>.
slorquet commented on pull request #4920:
URL: https://github.com/apache/incubator-nuttx/pull/4920#issuecomment-982726108


   seriously, guys, this is a nightmare.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] slorquet closed pull request #4920: Prevent creation of MTD partitions that span past the parent device.

Posted by GitBox <gi...@apache.org>.
slorquet closed pull request #4920:
URL: https://github.com/apache/incubator-nuttx/pull/4920


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] acassis commented on pull request #4920: Prevent creation of MTD partitions that span past the parent device.

Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #4920:
URL: https://github.com/apache/incubator-nuttx/pull/4920#issuecomment-982725298


   > Isnt that automatic?
   
   No, it was changed to only "Rebase and Merge" we don't have the option to squase it anymore, the developer needs to do it


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] hartmannathan commented on pull request #4920: Prevent creation of MTD partitions that span past the parent device.

Posted by GitBox <gi...@apache.org>.
hartmannathan commented on pull request #4920:
URL: https://github.com/apache/incubator-nuttx/pull/4920#issuecomment-982724719


   > Isnt that automatic?
   
   Squashing? No, it's not automatic. In the "Rebase and merge" button there is an option to "Squash and merge" but it is not enabled for this repository for some reason. Not sure if that's an ASF policy or what.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] slorquet commented on pull request #4920: Prevent creation of MTD partitions that span past the parent device.

Posted by GitBox <gi...@apache.org>.
slorquet commented on pull request #4920:
URL: https://github.com/apache/incubator-nuttx/pull/4920#issuecomment-982725297


   you just want me to kill kittens, eh?
   
   ok hold my beer.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] acassis edited a comment on pull request #4920: Prevent creation of MTD partitions that span past the parent device.

Posted by GitBox <gi...@apache.org>.
acassis edited a comment on pull request #4920:
URL: https://github.com/apache/incubator-nuttx/pull/4920#issuecomment-982731003


   > seriously, guys, this is a nightmare.
   
   You don't need to close the PR, just use "git rebase -i HEAD~N" where N is the number of commits you want to merge.
   
   It is not a nightmare, it is the process to avoid squashing logical commits that shouldn't be squashed... ;-)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #4920: Prevent creation of MTD partitions that span past the parent device.

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #4920:
URL: https://github.com/apache/incubator-nuttx/pull/4920#issuecomment-982718592


   @slorquet could you squash all small fix into one patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] slorquet commented on pull request #4920: Prevent creation of MTD partitions that span past the parent device.

Posted by GitBox <gi...@apache.org>.
slorquet commented on pull request #4920:
URL: https://github.com/apache/incubator-nuttx/pull/4920#issuecomment-982720920


   Isnt that automatic?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] acassis commented on pull request #4920: Prevent creation of MTD partitions that span past the parent device.

Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #4920:
URL: https://github.com/apache/incubator-nuttx/pull/4920#issuecomment-982731003


   > seriously, guys, this is a nightmare.
   
   You don't need to close the PR, just use "git rebase -i HEAD~N" where N is the number of commits you want to merge.
   
   It is not a nightmare, it is the process to avoid merging logical commits that shouldn't be merged... ;-)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org