[GitHub] [airflow] jedcunningham commented on a diff in pull request #23711: Helmchart: Provision Standalone Dag Processor

[GitBox <gi...@apache.org>]

jedcunningham commented on code in PR #23711:
URL: https://github.com/apache/airflow/pull/23711#discussion_r911331264


##########
chart/templates/scheduler/scheduler-deployment.yaml:
##########
@@ -141,7 +141,7 @@ spec:
           {{- include "custom_airflow_environment" . | indent 10 }}
           {{- include "standard_airflow_environment" . | indent 10 }}
         {{- end }}
-        {{- if .Values.dags.gitSync.enabled }}
+        {{- if and (not .Values.dagProcessor.enabled) .Values.dags.gitSync.enabled }}

Review Comment:
   Don't we still need this if we have dagProcessor and local?



##########
chart/templates/scheduler/scheduler-deployment.yaml:
##########
@@ -202,13 +202,13 @@ spec:
               subPath: airflow_local_settings.py
               readOnly: true
             {{- end }}
-            {{- if or .Values.dags.persistence.enabled .Values.dags.gitSync.enabled }}
-            {{- include "airflow_dags_mount" . | nindent 12 }}
-            {{- end }}
+{{- if and (or (not .Values.dagProcessor.enabled) $local) (or .Values.dags.persistence.enabled .Values.dags.gitSync.enabled) }}
+{{- include "airflow_dags_mount" . | nindent 12 }}
+{{- end }}
 {{- if .Values.scheduler.extraVolumeMounts }}
 {{ toYaml .Values.scheduler.extraVolumeMounts | indent 12 }}
 {{- end }}
-{{- if .Values.dags.gitSync.enabled }}
+{{- if and (not .Values.dagProcessor.enabled) .Values.dags.gitSync.enabled }}

Review Comment:
   Same here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org