You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by ah...@apache.org on 2022/10/13 12:42:18 UTC
[commons-numbers] branch master updated (3bdbf7cc -> 824e9e02)
This is an automated email from the ASF dual-hosted git repository.
aherbert pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/commons-numbers.git
from 3bdbf7cc Move dependency version properties to a section
new 0cd05458 Use diamond operator
new 824e9e02 Use mvn for README contributing build goal
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
commons-numbers-angle/README.md | 2 +-
commons-numbers-arrays/README.md | 2 +-
commons-numbers-combinatorics/README.md | 2 +-
commons-numbers-complex-streams/README.md | 2 +-
commons-numbers-complex/README.md | 2 +-
commons-numbers-core/README.md | 2 +-
commons-numbers-examples/README.md | 2 +-
commons-numbers-examples/examples-jmh/README.md | 2 +-
commons-numbers-field/README.md | 2 +-
commons-numbers-fraction/README.md | 2 +-
commons-numbers-gamma/README.md | 2 +-
commons-numbers-primes/README.md | 2 +-
.../apache/commons/numbers/primes/SmallPrimesTest.java | 16 ++++++++--------
commons-numbers-quaternion/README.md | 2 +-
commons-numbers-rootfinder/README.md | 2 +-
15 files changed, 22 insertions(+), 22 deletions(-)
[commons-numbers] 01/02: Use diamond operator
Posted by ah...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
aherbert pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-numbers.git
commit 0cd0545886661c8efbecdb55726dddbb0b0321a6
Author: aherbert <ah...@apache.org>
AuthorDate: Thu Oct 13 11:13:46 2022 +0100
Use diamond operator
---
.../apache/commons/numbers/primes/SmallPrimesTest.java | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/commons-numbers-primes/src/test/java/org/apache/commons/numbers/primes/SmallPrimesTest.java b/commons-numbers-primes/src/test/java/org/apache/commons/numbers/primes/SmallPrimesTest.java
index 8ba4e7a7..7bf1af30 100644
--- a/commons-numbers-primes/src/test/java/org/apache/commons/numbers/primes/SmallPrimesTest.java
+++ b/commons-numbers-primes/src/test/java/org/apache/commons/numbers/primes/SmallPrimesTest.java
@@ -31,7 +31,7 @@ class SmallPrimesTest {
@Test
void smallTrialDivision_smallComposite() {
- final List<Integer> factors = new ArrayList<Integer>();
+ final List<Integer> factors = new ArrayList<>();
final int result = SmallPrimes.smallTrialDivision(3 * 7 * 23, factors);
Assertions.assertEquals(1, result);
Assertions.assertEquals(Arrays.asList(3, 7, 23), factors);
@@ -39,7 +39,7 @@ class SmallPrimesTest {
@Test
void smallTrialDivision_repeatedFactors() {
- final List<Integer> factors = new ArrayList<Integer>();
+ final List<Integer> factors = new ArrayList<>();
final int result = SmallPrimes.smallTrialDivision(2 * 2 * 3 * 3 * 3, factors);
Assertions.assertEquals(1, result);
Assertions.assertEquals(Arrays.asList(2, 2, 3, 3, 3), factors);
@@ -47,7 +47,7 @@ class SmallPrimesTest {
@Test
void smallTrialDivision_oneFactor() {
- final List<Integer> factors = new ArrayList<Integer>();
+ final List<Integer> factors = new ArrayList<>();
final int result = SmallPrimes.smallTrialDivision(59, factors);
Assertions.assertEquals(1, result);
Assertions.assertEquals(Collections.singletonList(59), factors);
@@ -55,7 +55,7 @@ class SmallPrimesTest {
@Test
void smallTrialDivision_BoundaryPrimes() {
- final List<Integer> factors = new ArrayList<Integer>();
+ final List<Integer> factors = new ArrayList<>();
final int penultimatePrime = SmallPrimes.PRIMES[SmallPrimes.PRIMES.length - 2];
final int result = SmallPrimes.smallTrialDivision(penultimatePrime * SmallPrimes.PRIMES_LAST, factors);
Assertions.assertEquals(1, result);
@@ -64,7 +64,7 @@ class SmallPrimesTest {
@Test
void smallTrialDivision_largeComposite() {
- final List<Integer> factors = new ArrayList<Integer>();
+ final List<Integer> factors = new ArrayList<>();
final int result = SmallPrimes.smallTrialDivision(2 * 5 * LARGE_PRIME[0], factors);
Assertions.assertEquals(LARGE_PRIME[0], result);
Assertions.assertEquals(Arrays.asList(2, 5), factors);
@@ -72,7 +72,7 @@ class SmallPrimesTest {
@Test
void smallTrialDivision_noSmallPrimeFactors() {
- final List<Integer> factors = new ArrayList<Integer>();
+ final List<Integer> factors = new ArrayList<>();
final int result = SmallPrimes.smallTrialDivision(LARGE_PRIME[0] * LARGE_PRIME[1], factors);
Assertions.assertEquals(LARGE_PRIME[0] * LARGE_PRIME[1], result);
Assertions.assertEquals(Collections.<Integer>emptyList(), factors);
@@ -80,7 +80,7 @@ class SmallPrimesTest {
@Test
void boundedTrialDivision_twoDifferentFactors() {
- final List<Integer> factors = new ArrayList<Integer>();
+ final List<Integer> factors = new ArrayList<>();
final int result = SmallPrimes.boundedTrialDivision(LARGE_PRIME[0] * LARGE_PRIME[1], Integer.MAX_VALUE,
factors);
Assertions.assertEquals(LARGE_PRIME[1], result);
@@ -89,7 +89,7 @@ class SmallPrimesTest {
@Test
void boundedTrialDivision_square() {
- final List<Integer> factors = new ArrayList<Integer>();
+ final List<Integer> factors = new ArrayList<>();
final int result = SmallPrimes.boundedTrialDivision(LARGE_PRIME[0] * LARGE_PRIME[0], Integer.MAX_VALUE,
factors);
Assertions.assertEquals(LARGE_PRIME[0], result);
[commons-numbers] 02/02: Use mvn for README contributing build goal
Posted by ah...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
aherbert pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-numbers.git
commit 824e9e02c28e0899bbad1f740452d126409516fc
Author: aherbert <ah...@apache.org>
AuthorDate: Thu Oct 13 13:40:07 2022 +0100
Use mvn for README contributing build goal
---
commons-numbers-angle/README.md | 2 +-
commons-numbers-arrays/README.md | 2 +-
commons-numbers-combinatorics/README.md | 2 +-
commons-numbers-complex-streams/README.md | 2 +-
commons-numbers-complex/README.md | 2 +-
commons-numbers-core/README.md | 2 +-
commons-numbers-examples/README.md | 2 +-
commons-numbers-examples/examples-jmh/README.md | 2 +-
commons-numbers-field/README.md | 2 +-
commons-numbers-fraction/README.md | 2 +-
commons-numbers-gamma/README.md | 2 +-
commons-numbers-primes/README.md | 2 +-
commons-numbers-quaternion/README.md | 2 +-
commons-numbers-rootfinder/README.md | 2 +-
14 files changed, 14 insertions(+), 14 deletions(-)
diff --git a/commons-numbers-angle/README.md b/commons-numbers-angle/README.md
index 70affd43..9da67cf7 100644
--- a/commons-numbers-angle/README.md
+++ b/commons-numbers-angle/README.md
@@ -79,7 +79,7 @@ There are some guidelines which will make applying PRs easier for us:
+ No tabs! Please use spaces for indentation.
+ Respect the code style.
+ Create minimal diffs - disable on save actions like reformat source code or organize imports. If you feel the source code should be reformatted create a separate PR for this change.
-+ Provide JUnit tests for your changes and make sure your changes don't break any existing tests by running ```mvn clean test```.
++ Provide JUnit tests for your changes and make sure your changes don't break any existing tests by running ```mvn```.
If you plan to contribute on a regular basis, please consider filing a [contributor license agreement](https://www.apache.org/licenses/#clas).
You can learn more about contributing via GitHub in our [contribution guidelines](CONTRIBUTING.md).
diff --git a/commons-numbers-arrays/README.md b/commons-numbers-arrays/README.md
index 5a7e4c34..53fd4f8a 100644
--- a/commons-numbers-arrays/README.md
+++ b/commons-numbers-arrays/README.md
@@ -79,7 +79,7 @@ There are some guidelines which will make applying PRs easier for us:
+ No tabs! Please use spaces for indentation.
+ Respect the code style.
+ Create minimal diffs - disable on save actions like reformat source code or organize imports. If you feel the source code should be reformatted create a separate PR for this change.
-+ Provide JUnit tests for your changes and make sure your changes don't break any existing tests by running ```mvn clean test```.
++ Provide JUnit tests for your changes and make sure your changes don't break any existing tests by running ```mvn```.
If you plan to contribute on a regular basis, please consider filing a [contributor license agreement](https://www.apache.org/licenses/#clas).
You can learn more about contributing via GitHub in our [contribution guidelines](CONTRIBUTING.md).
diff --git a/commons-numbers-combinatorics/README.md b/commons-numbers-combinatorics/README.md
index 292d2bd2..6a7abf55 100644
--- a/commons-numbers-combinatorics/README.md
+++ b/commons-numbers-combinatorics/README.md
@@ -79,7 +79,7 @@ There are some guidelines which will make applying PRs easier for us:
+ No tabs! Please use spaces for indentation.
+ Respect the code style.
+ Create minimal diffs - disable on save actions like reformat source code or organize imports. If you feel the source code should be reformatted create a separate PR for this change.
-+ Provide JUnit tests for your changes and make sure your changes don't break any existing tests by running ```mvn clean test```.
++ Provide JUnit tests for your changes and make sure your changes don't break any existing tests by running ```mvn```.
If you plan to contribute on a regular basis, please consider filing a [contributor license agreement](https://www.apache.org/licenses/#clas).
You can learn more about contributing via GitHub in our [contribution guidelines](CONTRIBUTING.md).
diff --git a/commons-numbers-complex-streams/README.md b/commons-numbers-complex-streams/README.md
index e6d4515d..5431c9ef 100644
--- a/commons-numbers-complex-streams/README.md
+++ b/commons-numbers-complex-streams/README.md
@@ -79,7 +79,7 @@ There are some guidelines which will make applying PRs easier for us:
+ No tabs! Please use spaces for indentation.
+ Respect the code style.
+ Create minimal diffs - disable on save actions like reformat source code or organize imports. If you feel the source code should be reformatted create a separate PR for this change.
-+ Provide JUnit tests for your changes and make sure your changes don't break any existing tests by running ```mvn clean test```.
++ Provide JUnit tests for your changes and make sure your changes don't break any existing tests by running ```mvn```.
If you plan to contribute on a regular basis, please consider filing a [contributor license agreement](https://www.apache.org/licenses/#clas).
You can learn more about contributing via GitHub in our [contribution guidelines](CONTRIBUTING.md).
diff --git a/commons-numbers-complex/README.md b/commons-numbers-complex/README.md
index 0db36ffa..bf32f1c6 100644
--- a/commons-numbers-complex/README.md
+++ b/commons-numbers-complex/README.md
@@ -79,7 +79,7 @@ There are some guidelines which will make applying PRs easier for us:
+ No tabs! Please use spaces for indentation.
+ Respect the code style.
+ Create minimal diffs - disable on save actions like reformat source code or organize imports. If you feel the source code should be reformatted create a separate PR for this change.
-+ Provide JUnit tests for your changes and make sure your changes don't break any existing tests by running ```mvn clean test```.
++ Provide JUnit tests for your changes and make sure your changes don't break any existing tests by running ```mvn```.
If you plan to contribute on a regular basis, please consider filing a [contributor license agreement](https://www.apache.org/licenses/#clas).
You can learn more about contributing via GitHub in our [contribution guidelines](CONTRIBUTING.md).
diff --git a/commons-numbers-core/README.md b/commons-numbers-core/README.md
index 9586a993..0f57475a 100644
--- a/commons-numbers-core/README.md
+++ b/commons-numbers-core/README.md
@@ -79,7 +79,7 @@ There are some guidelines which will make applying PRs easier for us:
+ No tabs! Please use spaces for indentation.
+ Respect the code style.
+ Create minimal diffs - disable on save actions like reformat source code or organize imports. If you feel the source code should be reformatted create a separate PR for this change.
-+ Provide JUnit tests for your changes and make sure your changes don't break any existing tests by running ```mvn clean test```.
++ Provide JUnit tests for your changes and make sure your changes don't break any existing tests by running ```mvn```.
If you plan to contribute on a regular basis, please consider filing a [contributor license agreement](https://www.apache.org/licenses/#clas).
You can learn more about contributing via GitHub in our [contribution guidelines](CONTRIBUTING.md).
diff --git a/commons-numbers-examples/README.md b/commons-numbers-examples/README.md
index cac722bc..4d817da1 100644
--- a/commons-numbers-examples/README.md
+++ b/commons-numbers-examples/README.md
@@ -66,7 +66,7 @@ There are some guidelines which will make applying PRs easier for us:
+ No tabs! Please use spaces for indentation.
+ Respect the code style.
+ Create minimal diffs - disable on save actions like reformat source code or organize imports. If you feel the source code should be reformatted create a separate PR for this change.
-+ Provide JUnit tests for your changes and make sure your changes don't break any existing tests by running ```mvn clean test```.
++ Provide JUnit tests for your changes and make sure your changes don't break any existing tests by running ```mvn```.
If you plan to contribute on a regular basis, please consider filing a [contributor license agreement](https://www.apache.org/licenses/#clas).
You can learn more about contributing via GitHub in our [contribution guidelines](CONTRIBUTING.md).
diff --git a/commons-numbers-examples/examples-jmh/README.md b/commons-numbers-examples/examples-jmh/README.md
index 0f1ea5c8..e272903a 100644
--- a/commons-numbers-examples/examples-jmh/README.md
+++ b/commons-numbers-examples/examples-jmh/README.md
@@ -64,7 +64,7 @@ There are some guidelines which will make applying PRs easier for us:
+ No tabs! Please use spaces for indentation.
+ Respect the code style.
+ Create minimal diffs - disable on save actions like reformat source code or organize imports. If you feel the source code should be reformatted create a separate PR for this change.
-+ Provide JUnit tests for your changes and make sure your changes don't break any existing tests by running ```mvn clean test```.
++ Provide JUnit tests for your changes and make sure your changes don't break any existing tests by running ```mvn```.
If you plan to contribute on a regular basis, please consider filing a [contributor license agreement](https://www.apache.org/licenses/#clas).
You can learn more about contributing via GitHub in our [contribution guidelines](CONTRIBUTING.md).
diff --git a/commons-numbers-field/README.md b/commons-numbers-field/README.md
index 696595d7..1215806f 100644
--- a/commons-numbers-field/README.md
+++ b/commons-numbers-field/README.md
@@ -79,7 +79,7 @@ There are some guidelines which will make applying PRs easier for us:
+ No tabs! Please use spaces for indentation.
+ Respect the code style.
+ Create minimal diffs - disable on save actions like reformat source code or organize imports. If you feel the source code should be reformatted create a separate PR for this change.
-+ Provide JUnit tests for your changes and make sure your changes don't break any existing tests by running ```mvn clean test```.
++ Provide JUnit tests for your changes and make sure your changes don't break any existing tests by running ```mvn```.
If you plan to contribute on a regular basis, please consider filing a [contributor license agreement](https://www.apache.org/licenses/#clas).
You can learn more about contributing via GitHub in our [contribution guidelines](CONTRIBUTING.md).
diff --git a/commons-numbers-fraction/README.md b/commons-numbers-fraction/README.md
index cf9bed4e..06c38f1f 100644
--- a/commons-numbers-fraction/README.md
+++ b/commons-numbers-fraction/README.md
@@ -79,7 +79,7 @@ There are some guidelines which will make applying PRs easier for us:
+ No tabs! Please use spaces for indentation.
+ Respect the code style.
+ Create minimal diffs - disable on save actions like reformat source code or organize imports. If you feel the source code should be reformatted create a separate PR for this change.
-+ Provide JUnit tests for your changes and make sure your changes don't break any existing tests by running ```mvn clean test```.
++ Provide JUnit tests for your changes and make sure your changes don't break any existing tests by running ```mvn```.
If you plan to contribute on a regular basis, please consider filing a [contributor license agreement](https://www.apache.org/licenses/#clas).
You can learn more about contributing via GitHub in our [contribution guidelines](CONTRIBUTING.md).
diff --git a/commons-numbers-gamma/README.md b/commons-numbers-gamma/README.md
index 1ca5327a..6ba640fa 100644
--- a/commons-numbers-gamma/README.md
+++ b/commons-numbers-gamma/README.md
@@ -79,7 +79,7 @@ There are some guidelines which will make applying PRs easier for us:
+ No tabs! Please use spaces for indentation.
+ Respect the code style.
+ Create minimal diffs - disable on save actions like reformat source code or organize imports. If you feel the source code should be reformatted create a separate PR for this change.
-+ Provide JUnit tests for your changes and make sure your changes don't break any existing tests by running ```mvn clean test```.
++ Provide JUnit tests for your changes and make sure your changes don't break any existing tests by running ```mvn```.
If you plan to contribute on a regular basis, please consider filing a [contributor license agreement](https://www.apache.org/licenses/#clas).
You can learn more about contributing via GitHub in our [contribution guidelines](CONTRIBUTING.md).
diff --git a/commons-numbers-primes/README.md b/commons-numbers-primes/README.md
index d8251801..81b81926 100644
--- a/commons-numbers-primes/README.md
+++ b/commons-numbers-primes/README.md
@@ -79,7 +79,7 @@ There are some guidelines which will make applying PRs easier for us:
+ No tabs! Please use spaces for indentation.
+ Respect the code style.
+ Create minimal diffs - disable on save actions like reformat source code or organize imports. If you feel the source code should be reformatted create a separate PR for this change.
-+ Provide JUnit tests for your changes and make sure your changes don't break any existing tests by running ```mvn clean test```.
++ Provide JUnit tests for your changes and make sure your changes don't break any existing tests by running ```mvn```.
If you plan to contribute on a regular basis, please consider filing a [contributor license agreement](https://www.apache.org/licenses/#clas).
You can learn more about contributing via GitHub in our [contribution guidelines](CONTRIBUTING.md).
diff --git a/commons-numbers-quaternion/README.md b/commons-numbers-quaternion/README.md
index b71a1a91..5044315d 100644
--- a/commons-numbers-quaternion/README.md
+++ b/commons-numbers-quaternion/README.md
@@ -79,7 +79,7 @@ There are some guidelines which will make applying PRs easier for us:
+ No tabs! Please use spaces for indentation.
+ Respect the code style.
+ Create minimal diffs - disable on save actions like reformat source code or organize imports. If you feel the source code should be reformatted create a separate PR for this change.
-+ Provide JUnit tests for your changes and make sure your changes don't break any existing tests by running ```mvn clean test```.
++ Provide JUnit tests for your changes and make sure your changes don't break any existing tests by running ```mvn```.
If you plan to contribute on a regular basis, please consider filing a [contributor license agreement](https://www.apache.org/licenses/#clas).
You can learn more about contributing via GitHub in our [contribution guidelines](CONTRIBUTING.md).
diff --git a/commons-numbers-rootfinder/README.md b/commons-numbers-rootfinder/README.md
index 148ad00b..09c9c1fb 100644
--- a/commons-numbers-rootfinder/README.md
+++ b/commons-numbers-rootfinder/README.md
@@ -79,7 +79,7 @@ There are some guidelines which will make applying PRs easier for us:
+ No tabs! Please use spaces for indentation.
+ Respect the code style.
+ Create minimal diffs - disable on save actions like reformat source code or organize imports. If you feel the source code should be reformatted create a separate PR for this change.
-+ Provide JUnit tests for your changes and make sure your changes don't break any existing tests by running ```mvn clean test```.
++ Provide JUnit tests for your changes and make sure your changes don't break any existing tests by running ```mvn```.
If you plan to contribute on a regular basis, please consider filing a [contributor license agreement](https://www.apache.org/licenses/#clas).
You can learn more about contributing via GitHub in our [contribution guidelines](CONTRIBUTING.md).