[GitHub] [eventmesh] xwm1992 commented on a diff in pull request #3666: [ISSUE #3647] Invoke method(s) only conditionally.[Utils]

["xwm1992 (via GitHub)" <gi...@apache.org>]

xwm1992 commented on code in PR #3666:
URL: https://github.com/apache/eventmesh/pull/3666#discussion_r1161399347


##########
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/util/Utils.java:
##########
@@ -98,9 +98,9 @@ public static void logFailedMessageFlow(ChannelFuture future, Package pkg, UserA
     private static void logFailedMessageFlow(Package pkg, UserAgent user, long startTime, long taskExecuteTime,
         Throwable e) {
         if (pkg.getBody() instanceof EventMeshMessage) {
+            final Sting mqMessage = EventMeshUtil.printMqMessage((EventMeshMessage) pkg.getBody());

Review Comment:
   `Sting` is not correct, please change to `String`.



##########
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/util/Utils.java:
##########
@@ -118,8 +118,9 @@ private static void logFailedMessageFlow(Package pkg, UserAgent user, long start
      */
     public static void logSucceedMessageFlow(Package pkg, UserAgent user, long startTime, long taskExecuteTime) {
         if (pkg.getBody() instanceof EventMeshMessage) {
+            final Sting mqMessage = EventMeshUtil.printMqMessage((EventMeshMessage) pkg.getBody());

Review Comment:
   same as above.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org