[GitHub] [spark] vsevolodstep-db commented on a diff in pull request #43153: [SPARK-45360] Initialize spark session builder configuration from SPARK_REMOTE

["vsevolodstep-db (via GitHub)" <gi...@apache.org>]

vsevolodstep-db commented on code in PR #43153:
URL: https://github.com/apache/spark/pull/43153#discussion_r1339988135


##########
connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/connect/client/SparkConnectClientSuite.scala:
##########
@@ -112,6 +130,35 @@ class SparkConnectClientSuite extends ConnectFunSuite with BeforeAndAfterEach {
     }
   }
 
+  test("SparkSession create with SPARK_REMOTE") {

Review Comment:
   It's worth to also have a test covering combination of both `SPARK_REMOTE` env variable and `builder.remote(...)` call



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org