You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Patrick Hunt (JIRA)" <ji...@apache.org> on 2010/07/16 18:02:57 UTC
[jira] Created: (ZOOKEEPER-820) update c unit tests to ensure
"zombie" java server processes don't cause failure
update c unit tests to ensure "zombie" java server processes don't cause failure
--------------------------------------------------------------------------------
Key: ZOOKEEPER-820
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-820
Project: Zookeeper
Issue Type: Bug
Affects Versions: 3.3.1
Reporter: Patrick Hunt
Priority: Critical
Fix For: 3.3.2, 3.4.0
When the c unit tests are run sometimes the server doesn't shutdown at the end of the test, this causes subsequent tests (hudson esp) to fail.
1) we should try harder to make the server shut down at the end of the test, I suspect this is related to test failing/cleanup
2) before the tests are run we should see if the old server is still running and try to shut it down
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-820) update c unit tests to ensure
"zombie" java server processes don't cause failure
Posted by "Michi Mutsuzaki (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michi Mutsuzaki updated ZOOKEEPER-820:
--------------------------------------
Attachment: ZOOKEEPER-820.patch
This patch is for branch-3.3.
I changed 2 things.
1. Instead of using a file to keep track of pid, use lsof to check if a process is using port 22181.
2. Fixed invalid return code checking. This was causing the unit test to go into a loop for 2 minutes in certain cases.
--Michi
> update c unit tests to ensure "zombie" java server processes don't cause failure
> --------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-820
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-820
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.3.1
> Reporter: Patrick Hunt
> Assignee: Michi Mutsuzaki
> Priority: Critical
> Fix For: 3.3.2, 3.4.0
>
> Attachments: ZOOKEEPER-820.patch
>
>
> When the c unit tests are run sometimes the server doesn't shutdown at the end of the test, this causes subsequent tests (hudson esp) to fail.
> 1) we should try harder to make the server shut down at the end of the test, I suspect this is related to test failing/cleanup
> 2) before the tests are run we should see if the old server is still running and try to shut it down
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-820) update c unit tests to ensure
"zombie" java server processes don't cause failure
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-820:
-----------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
+1, committed to trunk/branch33. Thanks Michi!
> update c unit tests to ensure "zombie" java server processes don't cause failure
> --------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-820
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-820
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.3.1
> Reporter: Patrick Hunt
> Assignee: Michi Mutsuzaki
> Priority: Critical
> Fix For: 3.3.2, 3.4.0
>
> Attachments: ZOOKEEPER-820-1.patch, ZOOKEEPER-820.patch, ZOOKEEPER-820.patch, ZOOKEEPER-820.patch
>
>
> When the c unit tests are run sometimes the server doesn't shutdown at the end of the test, this causes subsequent tests (hudson esp) to fail.
> 1) we should try harder to make the server shut down at the end of the test, I suspect this is related to test failing/cleanup
> 2) before the tests are run we should see if the old server is still running and try to shut it down
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-820) update c unit tests to ensure
"zombie" java server processes don't cause failure
Posted by "Michi Mutsuzaki (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michi Mutsuzaki updated ZOOKEEPER-820:
--------------------------------------
Status: Patch Available (was: Open)
> update c unit tests to ensure "zombie" java server processes don't cause failure
> --------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-820
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-820
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.3.1
> Reporter: Patrick Hunt
> Assignee: Michi Mutsuzaki
> Priority: Critical
> Fix For: 3.3.2, 3.4.0
>
> Attachments: ZOOKEEPER-820-1.patch, ZOOKEEPER-820.patch, ZOOKEEPER-820.patch, ZOOKEEPER-820.patch
>
>
> When the c unit tests are run sometimes the server doesn't shutdown at the end of the test, this causes subsequent tests (hudson esp) to fail.
> 1) we should try harder to make the server shut down at the end of the test, I suspect this is related to test failing/cleanup
> 2) before the tests are run we should see if the old server is still running and try to shut it down
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-820) update c unit tests to ensure
"zombie" java server processes don't cause failure
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12909306#action_12909306 ]
Mahadev konar commented on ZOOKEEPER-820:
-----------------------------------------
The only comment I have is that these scripts might not work on cygwin. Let me try and check how lsof works on cygwin windows.
> update c unit tests to ensure "zombie" java server processes don't cause failure
> --------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-820
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-820
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.3.1
> Reporter: Patrick Hunt
> Assignee: Michi Mutsuzaki
> Priority: Critical
> Fix For: 3.3.2, 3.4.0
>
> Attachments: ZOOKEEPER-820-1.patch, ZOOKEEPER-820.patch
>
>
> When the c unit tests are run sometimes the server doesn't shutdown at the end of the test, this causes subsequent tests (hudson esp) to fail.
> 1) we should try harder to make the server shut down at the end of the test, I suspect this is related to test failing/cleanup
> 2) before the tests are run we should see if the old server is still running and try to shut it down
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-820) update c unit tests to ensure
"zombie" java server processes don't cause failure
Posted by "Michi Mutsuzaki (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12902014#action_12902014 ]
Michi Mutsuzaki commented on ZOOKEEPER-820:
-------------------------------------------
What's the 'correct' way to stop zookeeper server process? Right now the c unit test does kill -9. Is there a way to do clean shutdown?
--Michi
> update c unit tests to ensure "zombie" java server processes don't cause failure
> --------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-820
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-820
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.3.1
> Reporter: Patrick Hunt
> Assignee: Michi Mutsuzaki
> Priority: Critical
> Fix For: 3.3.2, 3.4.0
>
>
> When the c unit tests are run sometimes the server doesn't shutdown at the end of the test, this causes subsequent tests (hudson esp) to fail.
> 1) we should try harder to make the server shut down at the end of the test, I suspect this is related to test failing/cleanup
> 2) before the tests are run we should see if the old server is still running and try to shut it down
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-820) update c unit tests to ensure
"zombie" java server processes don't cause failure
Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12915799#action_12915799 ]
Benjamin Reed commented on ZOOKEEPER-820:
-----------------------------------------
+1 this looks good to me. did you try it on cygwin?
> update c unit tests to ensure "zombie" java server processes don't cause failure
> --------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-820
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-820
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.3.1
> Reporter: Patrick Hunt
> Assignee: Michi Mutsuzaki
> Priority: Critical
> Fix For: 3.3.2, 3.4.0
>
> Attachments: ZOOKEEPER-820-1.patch, ZOOKEEPER-820.patch
>
>
> When the c unit tests are run sometimes the server doesn't shutdown at the end of the test, this causes subsequent tests (hudson esp) to fail.
> 1) we should try harder to make the server shut down at the end of the test, I suspect this is related to test failing/cleanup
> 2) before the tests are run we should see if the old server is still running and try to shut it down
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-820) update c unit tests to ensure
"zombie" java server processes don't cause failure
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12923115#action_12923115 ]
Hudson commented on ZOOKEEPER-820:
----------------------------------
Integrated in ZooKeeper-trunk #973 (See [https://hudson.apache.org/hudson/job/ZooKeeper-trunk/973/])
ZOOKEEPER-820. update c unit tests to ensure "zombie" java server processes dont cause failure
> update c unit tests to ensure "zombie" java server processes don't cause failure
> --------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-820
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-820
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.3.1
> Reporter: Patrick Hunt
> Assignee: Michi Mutsuzaki
> Priority: Critical
> Fix For: 3.3.2, 3.4.0
>
> Attachments: ZOOKEEPER-820-1.patch, ZOOKEEPER-820.patch, ZOOKEEPER-820.patch, ZOOKEEPER-820.patch
>
>
> When the c unit tests are run sometimes the server doesn't shutdown at the end of the test, this causes subsequent tests (hudson esp) to fail.
> 1) we should try harder to make the server shut down at the end of the test, I suspect this is related to test failing/cleanup
> 2) before the tests are run we should see if the old server is still running and try to shut it down
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-820) update c unit tests to ensure
"zombie" java server processes don't cause failure
Posted by "Michi Mutsuzaki (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michi Mutsuzaki updated ZOOKEEPER-820:
--------------------------------------
Attachment: ZOOKEEPER-820.patch
Uses which to check if lsof command is present. If it is, use it to see if there is a process listening on port 22181 and kill it.
--Michi
> update c unit tests to ensure "zombie" java server processes don't cause failure
> --------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-820
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-820
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.3.1
> Reporter: Patrick Hunt
> Assignee: Michi Mutsuzaki
> Priority: Critical
> Fix For: 3.3.2, 3.4.0
>
> Attachments: ZOOKEEPER-820-1.patch, ZOOKEEPER-820.patch, ZOOKEEPER-820.patch, ZOOKEEPER-820.patch
>
>
> When the c unit tests are run sometimes the server doesn't shutdown at the end of the test, this causes subsequent tests (hudson esp) to fail.
> 1) we should try harder to make the server shut down at the end of the test, I suspect this is related to test failing/cleanup
> 2) before the tests are run we should see if the old server is still running and try to shut it down
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-820) update c unit tests to ensure
"zombie" java server processes don't cause failure
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-820:
-----------------------------------
Status: Open (was: Patch Available)
> update c unit tests to ensure "zombie" java server processes don't cause failure
> --------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-820
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-820
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.3.1
> Reporter: Patrick Hunt
> Assignee: Michi Mutsuzaki
> Priority: Critical
> Fix For: 3.3.2, 3.4.0
>
> Attachments: ZOOKEEPER-820-1.patch, ZOOKEEPER-820.patch
>
>
> When the c unit tests are run sometimes the server doesn't shutdown at the end of the test, this causes subsequent tests (hudson esp) to fail.
> 1) we should try harder to make the server shut down at the end of the test, I suspect this is related to test failing/cleanup
> 2) before the tests are run we should see if the old server is still running and try to shut it down
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-820) update c unit tests to ensure
"zombie" java server processes don't cause failure
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12889216#action_12889216 ]
Patrick Hunt commented on ZOOKEEPER-820:
----------------------------------------
Mahadev suggested this for item 2 from the description:
> I think we could some more standard tools like netstat to getthe process
> using that port and try killing it. This would be less error prone nd more
> reliable than other tools.
> update c unit tests to ensure "zombie" java server processes don't cause failure
> --------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-820
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-820
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.3.1
> Reporter: Patrick Hunt
> Priority: Critical
> Fix For: 3.3.2, 3.4.0
>
>
> When the c unit tests are run sometimes the server doesn't shutdown at the end of the test, this causes subsequent tests (hudson esp) to fail.
> 1) we should try harder to make the server shut down at the end of the test, I suspect this is related to test failing/cleanup
> 2) before the tests are run we should see if the old server is still running and try to shut it down
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-820) update c unit tests to ensure
"zombie" java server processes don't cause failure
Posted by "Michi Mutsuzaki (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michi Mutsuzaki updated ZOOKEEPER-820:
--------------------------------------
Attachment: ZOOKEEPER-820.patch
Reverted back to use pid file instead of lsof.
> update c unit tests to ensure "zombie" java server processes don't cause failure
> --------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-820
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-820
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.3.1
> Reporter: Patrick Hunt
> Assignee: Michi Mutsuzaki
> Priority: Critical
> Fix For: 3.3.2, 3.4.0
>
> Attachments: ZOOKEEPER-820-1.patch, ZOOKEEPER-820.patch, ZOOKEEPER-820.patch
>
>
> When the c unit tests are run sometimes the server doesn't shutdown at the end of the test, this causes subsequent tests (hudson esp) to fail.
> 1) we should try harder to make the server shut down at the end of the test, I suspect this is related to test failing/cleanup
> 2) before the tests are run we should see if the old server is still running and try to shut it down
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-820) update c unit tests to ensure
"zombie" java server processes don't cause failure
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12918144#action_12918144 ]
Mahadev konar commented on ZOOKEEPER-820:
-----------------------------------------
thsi does fix the if problem in the script (which took me sometime to realise was backwards :) ). Michi, can you also add the lsof check as follows:
{code}
if which lsof > /dev/null 2>&1; then "run the command to kill the process using lsof"; else "we dont do anything"; fi
{code}
Note that this is in addition to using pid checks. We can do the following -
on stop server:
- kill using pid file first
- kill using lsof, if any such process if present.
> update c unit tests to ensure "zombie" java server processes don't cause failure
> --------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-820
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-820
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.3.1
> Reporter: Patrick Hunt
> Assignee: Michi Mutsuzaki
> Priority: Critical
> Fix For: 3.3.2, 3.4.0
>
> Attachments: ZOOKEEPER-820-1.patch, ZOOKEEPER-820.patch, ZOOKEEPER-820.patch
>
>
> When the c unit tests are run sometimes the server doesn't shutdown at the end of the test, this causes subsequent tests (hudson esp) to fail.
> 1) we should try harder to make the server shut down at the end of the test, I suspect this is related to test failing/cleanup
> 2) before the tests are run we should see if the old server is still running and try to shut it down
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (ZOOKEEPER-820) update c unit tests to ensure
"zombie" java server processes don't cause failure
Posted by "Michi Mutsuzaki (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michi Mutsuzaki reassigned ZOOKEEPER-820:
-----------------------------------------
Assignee: Michi Mutsuzaki
> update c unit tests to ensure "zombie" java server processes don't cause failure
> --------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-820
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-820
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.3.1
> Reporter: Patrick Hunt
> Assignee: Michi Mutsuzaki
> Priority: Critical
> Fix For: 3.3.2, 3.4.0
>
>
> When the c unit tests are run sometimes the server doesn't shutdown at the end of the test, this causes subsequent tests (hudson esp) to fail.
> 1) we should try harder to make the server shut down at the end of the test, I suspect this is related to test failing/cleanup
> 2) before the tests are run we should see if the old server is still running and try to shut it down
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-820) update c unit tests to ensure
"zombie" java server processes don't cause failure
Posted by "Michi Mutsuzaki (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12915918#action_12915918 ]
Michi Mutsuzaki commented on ZOOKEEPER-820:
-------------------------------------------
Cygwin doesn't have lsof.
Most of the time, 'zombie' process is caused by the invalid return code checking (it keeps starting the server process in a loop for 2 minutes). I think it's ok to use pid file to keep track of the server process.
I'll submit a new patch.
--Michi
> update c unit tests to ensure "zombie" java server processes don't cause failure
> --------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-820
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-820
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.3.1
> Reporter: Patrick Hunt
> Assignee: Michi Mutsuzaki
> Priority: Critical
> Fix For: 3.3.2, 3.4.0
>
> Attachments: ZOOKEEPER-820-1.patch, ZOOKEEPER-820.patch
>
>
> When the c unit tests are run sometimes the server doesn't shutdown at the end of the test, this causes subsequent tests (hudson esp) to fail.
> 1) we should try harder to make the server shut down at the end of the test, I suspect this is related to test failing/cleanup
> 2) before the tests are run we should see if the old server is still running and try to shut it down
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-820) update c unit tests to ensure
"zombie" java server processes don't cause failure
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-820:
-----------------------------------
Status: Open (was: Patch Available)
Cancelling patch - needs to be updated for Mahadev's most recent comment.
> update c unit tests to ensure "zombie" java server processes don't cause failure
> --------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-820
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-820
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.3.1
> Reporter: Patrick Hunt
> Assignee: Michi Mutsuzaki
> Priority: Critical
> Fix For: 3.3.2, 3.4.0
>
> Attachments: ZOOKEEPER-820-1.patch, ZOOKEEPER-820.patch, ZOOKEEPER-820.patch
>
>
> When the c unit tests are run sometimes the server doesn't shutdown at the end of the test, this causes subsequent tests (hudson esp) to fail.
> 1) we should try harder to make the server shut down at the end of the test, I suspect this is related to test failing/cleanup
> 2) before the tests are run we should see if the old server is still running and try to shut it down
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-820) update c unit tests to ensure
"zombie" java server processes don't cause failure
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-820:
-----------------------------------
Status: Patch Available (was: Open)
> update c unit tests to ensure "zombie" java server processes don't cause failure
> --------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-820
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-820
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.3.1
> Reporter: Patrick Hunt
> Assignee: Michi Mutsuzaki
> Priority: Critical
> Fix For: 3.3.2, 3.4.0
>
> Attachments: ZOOKEEPER-820-1.patch, ZOOKEEPER-820.patch
>
>
> When the c unit tests are run sometimes the server doesn't shutdown at the end of the test, this causes subsequent tests (hudson esp) to fail.
> 1) we should try harder to make the server shut down at the end of the test, I suspect this is related to test failing/cleanup
> 2) before the tests are run we should see if the old server is still running and try to shut it down
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-820) update c unit tests to ensure
"zombie" java server processes don't cause failure
Posted by "Michi Mutsuzaki (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michi Mutsuzaki updated ZOOKEEPER-820:
--------------------------------------
Attachment: ZOOKEEPER-820-1.patch
One more change. I like to change the sleep time to from 5 seconds 1 second. Most of the time, 1 second is enough for the server to start up (at least on my box).
--Michi
> update c unit tests to ensure "zombie" java server processes don't cause failure
> --------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-820
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-820
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.3.1
> Reporter: Patrick Hunt
> Assignee: Michi Mutsuzaki
> Priority: Critical
> Fix For: 3.3.2, 3.4.0
>
> Attachments: ZOOKEEPER-820-1.patch, ZOOKEEPER-820.patch
>
>
> When the c unit tests are run sometimes the server doesn't shutdown at the end of the test, this causes subsequent tests (hudson esp) to fail.
> 1) we should try harder to make the server shut down at the end of the test, I suspect this is related to test failing/cleanup
> 2) before the tests are run we should see if the old server is still running and try to shut it down
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-820) update c unit tests to ensure
"zombie" java server processes don't cause failure
Posted by "Michi Mutsuzaki (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michi Mutsuzaki updated ZOOKEEPER-820:
--------------------------------------
Status: Patch Available (was: Open)
> update c unit tests to ensure "zombie" java server processes don't cause failure
> --------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-820
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-820
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.3.1
> Reporter: Patrick Hunt
> Assignee: Michi Mutsuzaki
> Priority: Critical
> Fix For: 3.3.2, 3.4.0
>
> Attachments: ZOOKEEPER-820.patch
>
>
> When the c unit tests are run sometimes the server doesn't shutdown at the end of the test, this causes subsequent tests (hudson esp) to fail.
> 1) we should try harder to make the server shut down at the end of the test, I suspect this is related to test failing/cleanup
> 2) before the tests are run we should see if the old server is still running and try to shut it down
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.