You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/04/06 08:03:41 UTC

[jira] [Commented] (FLINK-6270) Port several network config parameters to ConfigOption

    [ https://issues.apache.org/jira/browse/FLINK-6270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15958505#comment-15958505 ] 

ASF GitHub Bot commented on FLINK-6270:
---------------------------------------

GitHub user NicoK opened a pull request:

    https://github.com/apache/flink/pull/3683

    [FLINK-6270] Port several network config parameters to ConfigOption

    This ports some memory and network buffers related config options to new `ConfigOption` instances. These include:
    
    * `taskmanager.memory.size`
    * `taskmanager.memory.fraction`
    * `taskmanager.memory.off-heap`
    * `taskmanager.memory.preallocate`
    * `taskmanager.network.numberOfBuffers`
    * `taskmanager.memory.segment-size`
    
    Some of these already existed as `ConfigOption` instances in `MiniClusterConfiguration`.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/NicoK/flink flink-6270

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3683.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3683
    
----
commit 15ae80ee5a9cd29597f6ed597183251fbbb32f37
Author: Nico Kruber <ni...@data-artisans.com>
Date:   2017-04-05T08:59:00Z

    [FLINK-6270] extend Configuration with contains(configOption)

commit f136af323bce2517983af6c47849c9c70dc3efc2
Author: Nico Kruber <ni...@data-artisans.com>
Date:   2017-04-05T09:45:57Z

    [FLINK-6270] port some memory and network task manager options to ConfigOption

----


> Port several network config parameters to ConfigOption
> ------------------------------------------------------
>
>                 Key: FLINK-6270
>                 URL: https://issues.apache.org/jira/browse/FLINK-6270
>             Project: Flink
>          Issue Type: Improvement
>          Components: Network
>    Affects Versions: 1.3.0
>            Reporter: Nico Kruber
>            Assignee: Nico Kruber
>            Priority: Minor
>
> I'd like to port some memory and network buffers related config options to  new {{ConfigOption}} instances before continuing with FLINK-4545. These include:
> * {{taskmanager.memory.size}}
> * {{taskmanager.memory.fraction}}
> * {{taskmanager.memory.off-heap}}
> * {{taskmanager.memory.preallocate}}
> * {{taskmanager.network.numberOfBuffers}}
> * {{taskmanager.memory.segment-size}}
> Some of these already existed as {{ConfigOption}} instances in {{MiniClusterConfiguration}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)