[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #7460: add causes to stack trace return

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on a change in pull request #7460:
URL: https://github.com/apache/pinot/pull/7460#discussion_r713395547



##########
File path: pinot-common/src/main/java/org/apache/pinot/common/exception/QueryException.java
##########
@@ -154,7 +154,8 @@ public static String getTruncatedStackTrace(Exception exception) {
     for (int i = 0; i < numLinesOfStackTrace; i++) {
       lengthOfStackTrace += lines[i].length();
     }
-    return fullStackTrace.substring(0, lengthOfStackTrace);
+    return fullStackTrace.substring(0, lengthOfStackTrace) + "\n Caused By:\n"
+        + getTruncatedStackTrace(exception.getCause());

Review comment:
       Need null check?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org