You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2019/11/05 05:59:53 UTC

[GitHub] [pulsar-client-go] merlimat commented on issue #84: Fixed locking between connection_reader and connection

merlimat commented on issue #84: Fixed locking between connection_reader and connection
URL: https://github.com/apache/pulsar-client-go/pull/84#issuecomment-549674909
 
 
   > In here, i am a bit confused. Go officially provided bytes.Buffer can not meet our needs? Why do we have to repackage a Buffer?
   
   We need more functionalities like efficiently reading int32 and int16 while encapsulating the details.
   
   > The package of this Buffer structure is more similar to the way Java buffer is used, but may not be very friendly to developers of the go community.
   
   The ideas of Buffer are taken from Netty ByteBuf (rather than Java ByteBuffer) because the API is an excellent example of good abstractions for working with buffers and parsing/writing network protocols. The abstractions are not language specific.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services