You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/10/31 10:02:11 UTC
[GitHub] [hudi] albericgenius opened a new pull request, #7096: fix the right payload class name, then MOR table use projection schema
albericgenius opened a new pull request, #7096:
URL: https://github.com/apache/hudi/pull/7096
### Change Logs
Fix #7095
_Describe context and summary for this change. Highlight if any code was copied._
update the default payload, the payload class have rename to other package, the old one can not work.
### Impact
No
_Describe any public API or user-facing feature change or any performance impact._
No
### Risk level (write none, low medium or high below)
none
_If medium or high, explain what verification was done to mitigate the risks._
### Documentation Update
no
_Describe any necessary documentation update if there is any new feature, config, or user-facing change_
no
- _The config description must be updated if new configs are added or the default value of the configs are changed_
- _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
changes to the website._
### Contributor's checklist
- [ x] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ x] Change Logs and Impact were stated clearly
- [ x] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] albericgenius commented on a diff in pull request #7096: [MINOR] Fix OverwriteWithLatestAvroPayload full class name
Posted by GitBox <gi...@apache.org>.
albericgenius commented on code in PR #7096:
URL: https://github.com/apache/hudi/pull/7096#discussion_r1010030308
##########
hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/realtime/AbstractRealtimeRecordReader.java:
##########
@@ -85,7 +85,7 @@ public AbstractRealtimeRecordReader(RealtimeSplit split, JobConf job) {
private boolean usesCustomPayload(HoodieTableMetaClient metaClient) {
return !(metaClient.getTableConfig().getPayloadClass().contains(HoodieAvroPayload.class.getName())
- || metaClient.getTableConfig().getPayloadClass().contains("org.apache.hudi.OverwriteWithLatestAvroPayload"));
+ || metaClient.getTableConfig().getPayloadClass().contains("org.apache.hudi.common.model.OverwriteWithLatestAvroPayload"));
Review Comment:
got you, and fixed
Thanks for your suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] the-other-tim-brown commented on a diff in pull request #7096: [MINOR] Fix OverwriteWithLatestAvroPayload full class name
Posted by GitBox <gi...@apache.org>.
the-other-tim-brown commented on code in PR #7096:
URL: https://github.com/apache/hudi/pull/7096#discussion_r1009944491
##########
hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/realtime/AbstractRealtimeRecordReader.java:
##########
@@ -85,7 +85,7 @@ public AbstractRealtimeRecordReader(RealtimeSplit split, JobConf job) {
private boolean usesCustomPayload(HoodieTableMetaClient metaClient) {
return !(metaClient.getTableConfig().getPayloadClass().contains(HoodieAvroPayload.class.getName())
- || metaClient.getTableConfig().getPayloadClass().contains("org.apache.hudi.OverwriteWithLatestAvroPayload"));
+ || metaClient.getTableConfig().getPayloadClass().contains("org.apache.hudi.common.model.OverwriteWithLatestAvroPayload"));
Review Comment:
Can we use `OverwriteWithLatestAvroPayload.class.getName()` to avoid potential typos and so it will be updated if the location of the class changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xushiyan commented on pull request #7096: [MINOR] Fix OverwriteWithLatestAvroPayload full class name
Posted by GitBox <gi...@apache.org>.
xushiyan commented on PR #7096:
URL: https://github.com/apache/hudi/pull/7096#issuecomment-1310437131
> @xushiyan sorry to both you, could you help to assign JIRA contributor permission to me(cnuliuwei).
@albericgenius Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7096: fix the right payload class name, then MOR table use projection schema
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7096:
URL: https://github.com/apache/hudi/pull/7096#issuecomment-1296871733
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "72fc6aad248bf54011c0a54cba3efc2c63361b6b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12684",
"triggerID" : "72fc6aad248bf54011c0a54cba3efc2c63361b6b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 72fc6aad248bf54011c0a54cba3efc2c63361b6b Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12684)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7096: [MINOR] Fix OverwriteWithLatestAvroPayload full class name
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7096:
URL: https://github.com/apache/hudi/pull/7096#issuecomment-1297348281
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "72fc6aad248bf54011c0a54cba3efc2c63361b6b",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12684",
"triggerID" : "72fc6aad248bf54011c0a54cba3efc2c63361b6b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 72fc6aad248bf54011c0a54cba3efc2c63361b6b Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12684)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7096: [MINOR] Fix OverwriteWithLatestAvroPayload full class name
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7096:
URL: https://github.com/apache/hudi/pull/7096#issuecomment-1297958646
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "72fc6aad248bf54011c0a54cba3efc2c63361b6b",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12684",
"triggerID" : "72fc6aad248bf54011c0a54cba3efc2c63361b6b",
"triggerType" : "PUSH"
}, {
"hash" : "6dfd9bf3bb729f1822739b4e8b1ee376777ab166",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6dfd9bf3bb729f1822739b4e8b1ee376777ab166",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 72fc6aad248bf54011c0a54cba3efc2c63361b6b Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12684)
* 6dfd9bf3bb729f1822739b4e8b1ee376777ab166 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7096: [MINOR] Fix OverwriteWithLatestAvroPayload full class name
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7096:
URL: https://github.com/apache/hudi/pull/7096#issuecomment-1298050390
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "72fc6aad248bf54011c0a54cba3efc2c63361b6b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12684",
"triggerID" : "72fc6aad248bf54011c0a54cba3efc2c63361b6b",
"triggerType" : "PUSH"
}, {
"hash" : "6dfd9bf3bb729f1822739b4e8b1ee376777ab166",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12699",
"triggerID" : "6dfd9bf3bb729f1822739b4e8b1ee376777ab166",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6dfd9bf3bb729f1822739b4e8b1ee376777ab166 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12699)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7096: fix the right payload class name, then MOR table use projection schema
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7096:
URL: https://github.com/apache/hudi/pull/7096#issuecomment-1296864954
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "72fc6aad248bf54011c0a54cba3efc2c63361b6b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "72fc6aad248bf54011c0a54cba3efc2c63361b6b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 72fc6aad248bf54011c0a54cba3efc2c63361b6b UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] albericgenius commented on a diff in pull request #7096: [MINOR] Fix OverwriteWithLatestAvroPayload full class name
Posted by GitBox <gi...@apache.org>.
albericgenius commented on code in PR #7096:
URL: https://github.com/apache/hudi/pull/7096#discussion_r1010030308
##########
hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/realtime/AbstractRealtimeRecordReader.java:
##########
@@ -85,7 +85,7 @@ public AbstractRealtimeRecordReader(RealtimeSplit split, JobConf job) {
private boolean usesCustomPayload(HoodieTableMetaClient metaClient) {
return !(metaClient.getTableConfig().getPayloadClass().contains(HoodieAvroPayload.class.getName())
- || metaClient.getTableConfig().getPayloadClass().contains("org.apache.hudi.OverwriteWithLatestAvroPayload"));
+ || metaClient.getTableConfig().getPayloadClass().contains("org.apache.hudi.common.model.OverwriteWithLatestAvroPayload"));
Review Comment:
@the-other-tim-brown may need your help to approve running workflow(it is my first PR for hudi)
got you, and fixed
Thanks for your suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7096: [MINOR] Fix OverwriteWithLatestAvroPayload full class name
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7096:
URL: https://github.com/apache/hudi/pull/7096#issuecomment-1297963362
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "72fc6aad248bf54011c0a54cba3efc2c63361b6b",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12684",
"triggerID" : "72fc6aad248bf54011c0a54cba3efc2c63361b6b",
"triggerType" : "PUSH"
}, {
"hash" : "6dfd9bf3bb729f1822739b4e8b1ee376777ab166",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12699",
"triggerID" : "6dfd9bf3bb729f1822739b4e8b1ee376777ab166",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 72fc6aad248bf54011c0a54cba3efc2c63361b6b Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12684)
* 6dfd9bf3bb729f1822739b4e8b1ee376777ab166 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12699)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xushiyan merged pull request #7096: [MINOR] Fix OverwriteWithLatestAvroPayload full class name
Posted by GitBox <gi...@apache.org>.
xushiyan merged PR #7096:
URL: https://github.com/apache/hudi/pull/7096
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] albericgenius commented on pull request #7096: [MINOR] Fix OverwriteWithLatestAvroPayload full class name
Posted by GitBox <gi...@apache.org>.
albericgenius commented on PR #7096:
URL: https://github.com/apache/hudi/pull/7096#issuecomment-1309840920
@xushiyan sorry to both you, could you help to assign JIRA contributor permission to me(cnuliuwei).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org