You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "sollhui (via GitHub)" <gi...@apache.org> on 2026/02/02 03:56:32 UTC

[PR] [enhance](memtable) support dynamic modification of flush thread pool size [doris]

sollhui opened a new pull request, #60423:
URL: https://github.com/apache/doris/pull/60423

   ### What problem does this PR solve?
   
   Support dynamic modification of flush thread pool size.
   
   Usage Example:
   ```
   # Update flush thread pool size without restarting BE
   curl "http://be_host:webserver_port/api/update_config?flush_thread_num_per_store=10"
   curl "http://be_host:webserver_port/api/update_config?max_flush_thread_num_per_cpu=8"
   ```
   
   ### Release note
   
   None
   
   ### Check List (For Author)
   
   - Test <!-- At least one of them must be included. -->
       - [ ] Regression test
       - [ ] Unit Test
       - [ ] Manual test (add detailed scripts or steps below)
       - [ ] No need to test or manual test. Explain why:
           - [ ] This is a refactor/code format and no logic has been changed.
           - [ ] Previous test can cover this change.
           - [ ] No code files have been changed.
           - [ ] Other reason <!-- Add your reason?  -->
   
   - Behavior changed:
       - [ ] No.
       - [ ] Yes. <!-- Explain the behavior change -->
   
   - Does this need documentation?
       - [ ] No.
       - [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
   
   ### Check List (For Reviewer who merge this PR)
   
   - [ ] Confirm the release note
   - [ ] Confirm test cases
   - [ ] Confirm document
   - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [enhance](memtable) support dynamic modification of flush thread pool size [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60423:
URL: https://github.com/apache/doris/pull/60423#issuecomment-3832773766

   
   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
   
   Please clearly describe your PR:
   1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
   2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
   3. What features were added. Why was this function added?
   4. Which code was refactored and why was this part of the code refactored?
   5. Which functions were optimized and what is the difference before and after the optimization?
       


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [enhance](memtable) support dynamic modification of flush thread pool size [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60423:
URL: https://github.com/apache/doris/pull/60423#issuecomment-3833709568

   
   <details>
   <summary>ClickBench: <b>Total hot run time: 28.3 s</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit 2ff3e752c4541174e70294991cd7366947b62e33, data reload: false
   
   query1	0.05	0.04	0.04
   query2	0.10	0.04	0.04
   query3	0.26	0.08	0.08
   query4	1.61	0.11	0.12
   query5	0.27	0.24	0.23
   query6	1.16	0.70	0.67
   query7	0.04	0.03	0.02
   query8	0.05	0.05	0.04
   query9	0.58	0.50	0.49
   query10	0.55	0.54	0.55
   query11	0.14	0.09	0.09
   query12	0.13	0.10	0.11
   query13	0.63	0.62	0.61
   query14	1.06	1.07	1.04
   query15	0.88	0.85	0.86
   query16	0.39	0.38	0.40
   query17	1.08	1.16	1.11
   query18	0.23	0.21	0.21
   query19	2.00	1.91	2.05
   query20	0.02	0.02	0.01
   query21	15.42	0.25	0.15
   query22	5.23	0.05	0.05
   query23	15.92	0.27	0.10
   query24	1.42	0.65	0.53
   query25	0.08	0.11	0.06
   query26	0.15	0.12	0.13
   query27	0.06	0.05	0.06
   query28	3.90	1.15	0.97
   query29	12.58	3.90	3.14
   query30	0.26	0.13	0.12
   query31	2.81	0.62	0.41
   query32	3.24	0.59	0.50
   query33	3.22	3.26	3.19
   query34	16.55	5.35	4.75
   query35	4.80	4.78	4.73
   query36	0.63	0.50	0.49
   query37	0.11	0.07	0.07
   query38	0.07	0.04	0.04
   query39	0.04	0.02	0.02
   query40	0.19	0.17	0.16
   query41	0.09	0.03	0.03
   query42	0.04	0.02	0.02
   query43	0.05	0.04	0.03
   Total cold run time: 98.09 s
   Total hot run time: 28.3 s
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [enhance](memtable) support dynamic modification of flush thread pool size [doris]

Posted by "sollhui (via GitHub)" <gi...@apache.org>.
sollhui commented on PR #60423:
URL: https://github.com/apache/doris/pull/60423#issuecomment-3838781207

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [enhance](memtable) support dynamic modification of flush thread pool size [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60423:
URL: https://github.com/apache/doris/pull/60423#issuecomment-3840353530

   # BE UT Coverage Report
   Increment line coverage `59.26% (32/54)` :tada:
   
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/453da1e885aec197803c792fb1cdeba21d81e902_453da1e885aec197803c792fb1cdeba21d81e902/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/453da1e885aec197803c792fb1cdeba21d81e902_453da1e885aec197803c792fb1cdeba21d81e902/report/index.html)
   | Category          | Coverage           |
   |-------------------|--------------------|
   | Function Coverage | 52.58% (19371/36841) |
   | Line Coverage     | 36.04% (179870/499121) |
   | Region Coverage   | 32.43% (139590/430386) |
   | Branch Coverage   | 33.39% (60369/180805) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [enhance](memtable) support dynamic modification of flush thread pool size [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60423:
URL: https://github.com/apache/doris/pull/60423#issuecomment-3833276674

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 31719 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 2c088f5e73453cdb87b01505838ec4c5066d1fa0, data reload: false
   
   ------ Round 1 ----------------------------------
   q1	17615	5363	5050	5050
   q2	2011	344	198	198
   q3	10187	1344	758	758
   q4	10202	877	307	307
   q5	7529	2192	1889	1889
   q6	203	183	153	153
   q7	879	711	610	610
   q8	9247	1479	1040	1040
   q9	5165	4845	4857	4845
   q10	6861	1935	1563	1563
   q11	504	295	289	289
   q12	345	373	220	220
   q13	17782	4012	3253	3253
   q14	245	239	223	223
   q15	893	825	811	811
   q16	677	672	621	621
   q17	636	824	492	492
   q18	6696	6498	6384	6384
   q19	1242	1001	622	622
   q20	386	338	226	226
   q21	2591	2037	1888	1888
   q22	355	323	277	277
   Total cold run time: 102251 ms
   Total hot run time: 31719 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   q1	5333	5286	5311	5286
   q2	263	330	250	250
   q3	2159	2672	2307	2307
   q4	1329	1733	1331	1331
   q5	4332	4123	4165	4123
   q6	222	185	138	138
   q7	2071	2157	1914	1914
   q8	2682	2488	2400	2400
   q9	7533	7331	7595	7331
   q10	2818	3059	2563	2563
   q11	563	493	470	470
   q12	663	821	665	665
   q13	3823	4507	3635	3635
   q14	301	308	270	270
   q15	863	819	811	811
   q16	691	720	669	669
   q17	1200	1382	1391	1382
   q18	7910	8082	7675	7675
   q19	852	825	824	824
   q20	2063	2226	2013	2013
   q21	4615	4178	4051	4051
   q22	573	560	497	497
   Total cold run time: 52859 ms
   Total hot run time: 50605 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [enhance](memtable) support dynamic modification of flush thread pool size [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60423:
URL: https://github.com/apache/doris/pull/60423#issuecomment-3834273580

   # BE Regression && UT Coverage Report
   Increment line coverage `100.00% (24/24)` :tada:
   
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/60423_2ff3e752c4541174e70294991cd7366947b62e33_merge/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/60423_2ff3e752c4541174e70294991cd7366947b62e33_merge/report/index.html)
   | Category          | Coverage           |
   |-------------------|--------------------|
   | Function Coverage | 71.57% (25827/36084) |
   | Line Coverage     | 54.22% (269974/497906) |
   | Region Coverage   | 51.75% (225023/434840) |
   | Branch Coverage   | 53.20% (96589/181555) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [enhance](memtable) support dynamic modification of flush thread pool size [doris]

Posted by "JNSimba (via GitHub)" <gi...@apache.org>.
JNSimba merged PR #60423:
URL: https://github.com/apache/doris/pull/60423


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [enhance](memtable) support dynamic modification of flush thread pool size [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60423:
URL: https://github.com/apache/doris/pull/60423#issuecomment-3839209687

   
   <details>
   <summary>ClickBench: <b>Total hot run time: 27.99 s</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit f3c20b022c49152eb5e0abf0fd2856570ab08e49, data reload: false
   
   query1	0.06	0.05	0.05
   query2	0.10	0.04	0.04
   query3	0.26	0.08	0.08
   query4	1.60	0.11	0.11
   query5	0.26	0.26	0.24
   query6	1.16	0.68	0.68
   query7	0.03	0.02	0.02
   query8	0.05	0.04	0.04
   query9	0.56	0.50	0.50
   query10	0.56	0.53	0.53
   query11	0.14	0.09	0.10
   query12	0.13	0.10	0.10
   query13	0.64	0.62	0.61
   query14	1.06	1.05	1.06
   query15	0.88	0.86	0.88
   query16	0.40	0.39	0.41
   query17	1.10	1.14	1.12
   query18	0.22	0.21	0.21
   query19	2.07	1.92	2.01
   query20	0.01	0.01	0.02
   query21	15.40	0.26	0.14
   query22	5.09	0.06	0.04
   query23	15.80	0.28	0.10
   query24	0.99	0.25	0.18
   query25	0.09	0.07	0.09
   query26	0.15	0.13	0.13
   query27	0.08	0.05	0.04
   query28	3.04	1.15	0.97
   query29	12.54	3.87	3.14
   query30	0.30	0.13	0.12
   query31	2.89	0.63	0.40
   query32	3.25	0.58	0.48
   query33	3.22	3.26	3.27
   query34	16.34	5.38	4.68
   query35	4.81	4.80	4.75
   query36	0.64	0.50	0.50
   query37	0.11	0.06	0.06
   query38	0.07	0.04	0.04
   query39	0.04	0.02	0.02
   query40	0.19	0.16	0.14
   query41	0.09	0.03	0.02
   query42	0.05	0.03	0.03
   query43	0.04	0.04	0.03
   Total cold run time: 96.51 s
   Total hot run time: 27.99 s
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [enhance](memtable) support dynamic modification of flush thread pool size [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60423:
URL: https://github.com/apache/doris/pull/60423#issuecomment-3845674985

   # BE Regression && UT Coverage Report
   Increment line coverage `51.61% (32/62)` :tada:
   
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/60423_453da1e885aec197803c792fb1cdeba21d81e902_merge/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/60423_453da1e885aec197803c792fb1cdeba21d81e902_merge/report/index.html)
   | Category          | Coverage           |
   |-------------------|--------------------|
   | Function Coverage | 71.65% (25870/36104) |
   | Line Coverage     | 54.27% (270208/497930) |
   | Region Coverage   | 51.77% (225106/434802) |
   | Branch Coverage   | 53.22% (96605/181535) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [enhance](memtable) support dynamic modification of flush thread pool size [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60423:
URL: https://github.com/apache/doris/pull/60423#issuecomment-3833333216

   
   <details>
   <summary>ClickBench: <b>Total hot run time: 28.72 s</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit 2c088f5e73453cdb87b01505838ec4c5066d1fa0, data reload: false
   
   query1	0.06	0.05	0.05
   query2	0.10	0.05	0.05
   query3	0.25	0.08	0.09
   query4	1.61	0.12	0.11
   query5	0.28	0.25	0.25
   query6	1.15	0.68	0.67
   query7	0.03	0.03	0.02
   query8	0.06	0.04	0.04
   query9	0.56	0.50	0.50
   query10	0.55	0.56	0.54
   query11	0.15	0.09	0.09
   query12	0.14	0.10	0.11
   query13	0.64	0.61	0.61
   query14	1.06	1.06	1.05
   query15	0.88	0.86	0.87
   query16	0.38	0.39	0.40
   query17	1.14	1.13	1.14
   query18	0.23	0.21	0.21
   query19	2.01	2.02	2.01
   query20	0.02	0.01	0.01
   query21	15.41	0.25	0.15
   query22	5.20	0.05	0.05
   query23	15.82	0.30	0.10
   query24	1.60	0.71	0.70
   query25	0.05	0.08	0.05
   query26	0.14	0.13	0.14
   query27	0.06	0.06	0.07
   query28	4.27	1.17	0.95
   query29	12.56	3.91	3.18
   query30	0.28	0.13	0.11
   query31	2.82	0.65	0.40
   query32	3.24	0.60	0.49
   query33	3.23	3.23	3.33
   query34	16.24	5.35	4.71
   query35	4.79	4.78	4.81
   query36	0.64	0.50	0.49
   query37	0.11	0.07	0.07
   query38	0.07	0.04	0.04
   query39	0.05	0.03	0.03
   query40	0.18	0.16	0.14
   query41	0.09	0.03	0.03
   query42	0.04	0.03	0.03
   query43	0.05	0.04	0.03
   Total cold run time: 98.24 s
   Total hot run time: 28.72 s
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [enhance](memtable) support dynamic modification of flush thread pool size [doris]

Posted by "sollhui (via GitHub)" <gi...@apache.org>.
sollhui commented on PR #60423:
URL: https://github.com/apache/doris/pull/60423#issuecomment-3839341873

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [enhance](memtable) support dynamic modification of flush thread pool size [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #60423:
URL: https://github.com/apache/doris/pull/60423#issuecomment-3850746485

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [enhance](memtable) support dynamic modification of flush thread pool size [doris]

Posted by "sollhui (via GitHub)" <gi...@apache.org>.
sollhui commented on PR #60423:
URL: https://github.com/apache/doris/pull/60423#issuecomment-3832887046

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [enhance](memtable) support dynamic modification of flush thread pool size [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60423:
URL: https://github.com/apache/doris/pull/60423#issuecomment-3833865283

   # BE UT Coverage Report
   Increment line coverage `100.00% (24/24)` :tada:
   
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/2ff3e752c4541174e70294991cd7366947b62e33_2ff3e752c4541174e70294991cd7366947b62e33/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/2ff3e752c4541174e70294991cd7366947b62e33_2ff3e752c4541174e70294991cd7366947b62e33/report/index.html)
   | Category          | Coverage           |
   |-------------------|--------------------|
   | Function Coverage | 52.50% (19329/36820) |
   | Line Coverage     | 36.00% (179674/499108) |
   | Region Coverage   | 32.37% (139319/430449) |
   | Branch Coverage   | 33.35% (60315/180829) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [enhance](memtable) support dynamic modification of flush thread pool size [doris]

Posted by "sollhui (via GitHub)" <gi...@apache.org>.
sollhui commented on PR #60423:
URL: https://github.com/apache/doris/pull/60423#issuecomment-3838851899

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [enhance](memtable) support dynamic modification of flush thread pool size [doris]

Posted by "sollhui (via GitHub)" <gi...@apache.org>.
sollhui commented on PR #60423:
URL: https://github.com/apache/doris/pull/60423#issuecomment-3833115137

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [enhance](memtable) support dynamic modification of flush thread pool size [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60423:
URL: https://github.com/apache/doris/pull/60423#issuecomment-3833625352

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 32153 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 2ff3e752c4541174e70294991cd7366947b62e33, data reload: false
   
   ------ Round 1 ----------------------------------
   q1	17658	5380	5084	5084
   q2	2076	327	200	200
   q3	10175	1370	756	756
   q4	10205	861	329	329
   q5	7534	2157	1923	1923
   q6	200	183	151	151
   q7	870	730	603	603
   q8	9254	1407	1117	1117
   q9	5068	4796	4931	4796
   q10	6791	1951	1592	1592
   q11	504	305	276	276
   q12	337	380	222	222
   q13	17780	4029	3267	3267
   q14	238	233	220	220
   q15	885	825	812	812
   q16	684	714	612	612
   q17	653	804	488	488
   q18	6781	6513	7535	6513
   q19	1288	1053	686	686
   q20	417	385	249	249
   q21	2946	2403	1987	1987
   q22	393	343	270	270
   Total cold run time: 102737 ms
   Total hot run time: 32153 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   q1	5570	5622	5935	5622
   q2	265	335	244	244
   q3	2404	2887	2489	2489
   q4	1428	1927	1364	1364
   q5	4544	4613	4475	4475
   q6	282	223	169	169
   q7	2007	1951	1782	1782
   q8	2611	2444	2441	2441
   q9	7447	7617	7486	7486
   q10	2802	3130	2613	2613
   q11	536	468	450	450
   q12	682	726	604	604
   q13	3882	4315	3648	3648
   q14	295	288	273	273
   q15	829	790	818	790
   q16	646	686	627	627
   q17	1083	1333	1313	1313
   q18	7695	7506	7111	7111
   q19	824	792	807	792
   q20	2035	2070	1938	1938
   q21	4452	4188	4100	4100
   q22	596	544	512	512
   Total cold run time: 52915 ms
   Total hot run time: 50843 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [enhance](memtable) support dynamic modification of flush thread pool size [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60423:
URL: https://github.com/apache/doris/pull/60423#issuecomment-3845341763

   # BE Regression && UT Coverage Report
   Increment line coverage `51.61% (32/62)` :tada:
   
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/60423_453da1e885aec197803c792fb1cdeba21d81e902_merge/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/60423_453da1e885aec197803c792fb1cdeba21d81e902_merge/report/index.html)
   | Category          | Coverage           |
   |-------------------|--------------------|
   | Function Coverage | 71.65% (25869/36104) |
   | Line Coverage     | 54.27% (270208/497930) |
   | Region Coverage   | 51.79% (225173/434802) |
   | Branch Coverage   | 53.22% (96609/181535) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [enhance](memtable) support dynamic modification of flush thread pool size [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #60423:
URL: https://github.com/apache/doris/pull/60423#issuecomment-3846357912

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [enhance](memtable) support dynamic modification of flush thread pool size [doris]

Posted by "sollhui (via GitHub)" <gi...@apache.org>.
sollhui commented on PR #60423:
URL: https://github.com/apache/doris/pull/60423#issuecomment-3833485314

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [enhance](memtable) support dynamic modification of flush thread pool size [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60423:
URL: https://github.com/apache/doris/pull/60423#issuecomment-3839942010

   
   <details>
   <summary>ClickBench: <b>Total hot run time: 28.81 s</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit 453da1e885aec197803c792fb1cdeba21d81e902, data reload: false
   
   query1	0.05	0.05	0.04
   query2	0.09	0.05	0.04
   query3	0.25	0.08	0.08
   query4	1.62	0.11	0.11
   query5	0.27	0.25	0.25
   query6	1.16	0.67	0.68
   query7	0.03	0.02	0.03
   query8	0.05	0.04	0.04
   query9	0.56	0.51	0.50
   query10	0.55	0.54	0.55
   query11	0.14	0.10	0.10
   query12	0.14	0.10	0.10
   query13	0.64	0.62	0.63
   query14	1.07	1.06	1.05
   query15	0.88	0.87	0.89
   query16	0.40	0.42	0.40
   query17	1.15	1.17	1.17
   query18	0.23	0.21	0.20
   query19	2.02	2.02	2.04
   query20	0.02	0.01	0.02
   query21	15.39	0.27	0.15
   query22	5.09	0.06	0.05
   query23	15.92	0.27	0.10
   query24	1.12	1.26	0.68
   query25	0.07	0.08	0.06
   query26	0.14	0.13	0.13
   query27	0.08	0.04	0.07
   query28	4.43	1.15	0.96
   query29	12.63	3.95	3.16
   query30	0.28	0.14	0.12
   query31	2.81	0.66	0.40
   query32	3.24	0.59	0.50
   query33	3.28	3.28	3.22
   query34	16.28	5.35	4.75
   query35	4.78	4.78	4.85
   query36	0.65	0.51	0.50
   query37	0.11	0.08	0.07
   query38	0.07	0.04	0.04
   query39	0.05	0.03	0.03
   query40	0.19	0.15	0.14
   query41	0.08	0.03	0.04
   query42	0.04	0.03	0.03
   query43	0.05	0.04	0.04
   Total cold run time: 98.1 s
   Total hot run time: 28.81 s
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [enhance](memtable) support dynamic modification of flush thread pool size [doris]

Posted by "sollhui (via GitHub)" <gi...@apache.org>.
sollhui commented on PR #60423:
URL: https://github.com/apache/doris/pull/60423#issuecomment-3832774551

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [enhance](memtable) support dynamic modification of flush thread pool size [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60423:
URL: https://github.com/apache/doris/pull/60423#issuecomment-3839867428

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 31929 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 453da1e885aec197803c792fb1cdeba21d81e902, data reload: false
   
   ------ Round 1 ----------------------------------
   q1	17617	5286	5044	5044
   q2	2080	343	213	213
   q3	10112	1361	764	764
   q4	10270	844	317	317
   q5	8665	2147	1928	1928
   q6	241	183	151	151
   q7	901	735	626	626
   q8	9266	1365	1190	1190
   q9	5362	4850	4858	4850
   q10	6877	1971	1577	1577
   q11	511	300	281	281
   q12	394	379	228	228
   q13	17772	4065	3214	3214
   q14	236	236	227	227
   q15	921	815	805	805
   q16	720	677	623	623
   q17	716	840	432	432
   q18	7126	6581	6405	6405
   q19	1537	1017	620	620
   q20	376	354	227	227
   q21	2616	2035	1935	1935
   q22	352	318	272	272
   Total cold run time: 104668 ms
   Total hot run time: 31929 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   q1	5354	5296	5403	5296
   q2	258	329	263	263
   q3	2164	2679	2251	2251
   q4	1371	1725	1331	1331
   q5	4284	4156	4490	4156
   q6	249	205	161	161
   q7	2189	2108	1942	1942
   q8	2528	2399	2396	2396
   q9	7540	7521	7563	7521
   q10	2846	3069	2743	2743
   q11	581	492	460	460
   q12	690	763	599	599
   q13	3982	4464	3625	3625
   q14	312	313	282	282
   q15	877	862	819	819
   q16	702	748	679	679
   q17	1142	1381	1405	1381
   q18	8045	8084	7914	7914
   q19	888	854	891	854
   q20	2105	2073	1883	1883
   q21	4498	4170	4006	4006
   q22	553	542	509	509
   Total cold run time: 53158 ms
   Total hot run time: 51071 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [enhance](memtable) support dynamic modification of flush thread pool size [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60423:
URL: https://github.com/apache/doris/pull/60423#issuecomment-3840799995

   # BE Regression && UT Coverage Report
   Increment line coverage `51.61% (32/62)` :tada:
   
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/60423_453da1e885aec197803c792fb1cdeba21d81e902_merge/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/60423_453da1e885aec197803c792fb1cdeba21d81e902_merge/report/index.html)
   | Category          | Coverage           |
   |-------------------|--------------------|
   | Function Coverage | 71.65% (25870/36104) |
   | Line Coverage     | 54.27% (270204/497930) |
   | Region Coverage   | 51.80% (225240/434802) |
   | Branch Coverage   | 53.22% (96607/181535) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [enhance](memtable) support dynamic modification of flush thread pool size [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60423:
URL: https://github.com/apache/doris/pull/60423#issuecomment-3834418986

   # BE Regression && UT Coverage Report
   Increment line coverage `100.00% (24/24)` :tada:
   
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/60423_2ff3e752c4541174e70294991cd7366947b62e33_merge/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/60423_2ff3e752c4541174e70294991cd7366947b62e33_merge/report/index.html)
   | Category          | Coverage           |
   |-------------------|--------------------|
   | Function Coverage | 71.69% (25870/36084) |
   | Line Coverage     | 54.35% (270618/497906) |
   | Region Coverage   | 51.91% (225722/434840) |
   | Branch Coverage   | 53.33% (96831/181555) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [enhance](memtable) support dynamic modification of flush thread pool size [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60423:
URL: https://github.com/apache/doris/pull/60423#issuecomment-3839158718

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 32036 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit f3c20b022c49152eb5e0abf0fd2856570ab08e49, data reload: false
   
   ------ Round 1 ----------------------------------
   q1	17651	5270	5020	5020
   q2	2071	329	188	188
   q3	10189	1346	767	767
   q4	10205	843	317	317
   q5	7758	2218	1872	1872
   q6	220	182	146	146
   q7	906	717	616	616
   q8	9263	1443	1159	1159
   q9	5491	4937	4842	4842
   q10	6853	1950	1564	1564
   q11	562	284	275	275
   q12	393	377	225	225
   q13	17799	4075	3224	3224
   q14	231	235	221	221
   q15	908	828	809	809
   q16	682	666	618	618
   q17	635	839	439	439
   q18	6665	6440	7726	6440
   q19	1331	1029	678	678
   q20	410	387	240	240
   q21	2941	2320	2106	2106
   q22	382	316	270	270
   Total cold run time: 103546 ms
   Total hot run time: 32036 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   q1	5626	5557	5468	5468
   q2	262	355	276	276
   q3	2536	2908	2512	2512
   q4	1457	1842	1471	1471
   q5	4903	4642	4495	4495
   q6	221	183	139	139
   q7	2041	2166	1770	1770
   q8	2580	2479	2398	2398
   q9	7460	7510	7625	7510
   q10	2775	2969	2564	2564
   q11	544	481	471	471
   q12	674	739	611	611
   q13	3496	4000	3206	3206
   q14	269	287	256	256
   q15	839	800	794	794
   q16	644	692	627	627
   q17	1083	1256	1307	1256
   q18	7446	7514	7328	7328
   q19	830	850	854	850
   q20	1951	2057	1888	1888
   q21	4503	4222	4129	4129
   q22	565	555	501	501
   Total cold run time: 52705 ms
   Total hot run time: 50520 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org