You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by "Artemy Tregubenko (JIRA)" <ji...@apache.org> on 2008/08/12 15:56:44 UTC
[jira] Created: (SHINDIG-514) Reduce Config::get usage in
BasicBlobCrypter to simplify overriding
Reduce Config::get usage in BasicBlobCrypter to simplify overriding
-------------------------------------------------------------------
Key: SHINDIG-514
URL: https://issues.apache.org/jira/browse/SHINDIG-514
Project: Shindig
Issue Type: Improvement
Components: Common Components (PHP)
Reporter: Artemy Tregubenko
Attachments: reduce_config_usage.diff
Currently BasicBlobCrypter uses Config::get('allow_plaintext_token') in it's wrap/unwrap implementation. If this value is moved to __construct, it becomes easier to create custom BlobCrypter by overriding only __construct method in child class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (SHINDIG-514) Reduce Config::get usage in
BasicBlobCrypter to simplify overriding
Posted by "Artemy Tregubenko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Artemy Tregubenko closed SHINDIG-514.
-------------------------------------
Thanks for accepting patch and for advice : )
> Reduce Config::get usage in BasicBlobCrypter to simplify overriding
> -------------------------------------------------------------------
>
> Key: SHINDIG-514
> URL: https://issues.apache.org/jira/browse/SHINDIG-514
> Project: Shindig
> Issue Type: Improvement
> Components: Common Components (PHP)
> Reporter: Artemy Tregubenko
> Assignee: Chris Chabot
> Priority: Trivial
> Attachments: reduce_config_usage.diff
>
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> Currently BasicBlobCrypter uses Config::get('allow_plaintext_token') in it's wrap/unwrap implementation. If this value is moved to __construct, it becomes easier to create custom BlobCrypter by overriding only __construct method in child class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-514) Reduce Config::get usage in
BasicBlobCrypter to simplify overriding
Posted by "Artemy Tregubenko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Artemy Tregubenko updated SHINDIG-514:
--------------------------------------
Priority: Trivial (was: Major)
> Reduce Config::get usage in BasicBlobCrypter to simplify overriding
> -------------------------------------------------------------------
>
> Key: SHINDIG-514
> URL: https://issues.apache.org/jira/browse/SHINDIG-514
> Project: Shindig
> Issue Type: Improvement
> Components: Common Components (PHP)
> Reporter: Artemy Tregubenko
> Priority: Trivial
> Attachments: reduce_config_usage.diff
>
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> Currently BasicBlobCrypter uses Config::get('allow_plaintext_token') in it's wrap/unwrap implementation. If this value is moved to __construct, it becomes easier to create custom BlobCrypter by overriding only __construct method in child class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-514) Reduce Config::get usage in
BasicBlobCrypter to simplify overriding
Posted by "Artemy Tregubenko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Artemy Tregubenko updated SHINDIG-514:
--------------------------------------
Attachment: reduce_config_usage.diff
> Reduce Config::get usage in BasicBlobCrypter to simplify overriding
> -------------------------------------------------------------------
>
> Key: SHINDIG-514
> URL: https://issues.apache.org/jira/browse/SHINDIG-514
> Project: Shindig
> Issue Type: Improvement
> Components: Common Components (PHP)
> Reporter: Artemy Tregubenko
> Attachments: reduce_config_usage.diff
>
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> Currently BasicBlobCrypter uses Config::get('allow_plaintext_token') in it's wrap/unwrap implementation. If this value is moved to __construct, it becomes easier to create custom BlobCrypter by overriding only __construct method in child class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SHINDIG-514) Reduce Config::get usage in
BasicBlobCrypter to simplify overriding
Posted by "Chris Chabot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Chabot resolved SHINDIG-514.
----------------------------------
Resolution: Fixed
Assignee: Chris Chabot
Thanks, nice suggestion. Patch has been applied & committed.
Ps, it's good form to declare the class var before using it, it takes the away the auto magic and puts design and intend in it's place :)
> Reduce Config::get usage in BasicBlobCrypter to simplify overriding
> -------------------------------------------------------------------
>
> Key: SHINDIG-514
> URL: https://issues.apache.org/jira/browse/SHINDIG-514
> Project: Shindig
> Issue Type: Improvement
> Components: Common Components (PHP)
> Reporter: Artemy Tregubenko
> Assignee: Chris Chabot
> Priority: Trivial
> Attachments: reduce_config_usage.diff
>
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> Currently BasicBlobCrypter uses Config::get('allow_plaintext_token') in it's wrap/unwrap implementation. If this value is moved to __construct, it becomes easier to create custom BlobCrypter by overriding only __construct method in child class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.