You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Mahler <bm...@apache.org> on 2018/05/30 00:57:53 UTC

Review Request 67370: Added a test for weighted shuffling.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67370/
-----------------------------------------------------------

Review request for mesos, Gaston Kleiman, Greg Mann, and Meng Zhu.


Bugs: MESOS-8936
    https://issues.apache.org/jira/browse/MESOS-8936


Repository: mesos


Description
-------

See summary.


Diffs
-----

  src/tests/sorter_tests.cpp da4e0f64a565af1d9458ff256ae0eafddd0a6b68 


Diff: https://reviews.apache.org/r/67370/diff/1/


Testing
-------


Thanks,

Benjamin Mahler

Re: Review Request 67370: Added a test for weighted shuffling.

Posted by Meng Zhu <mz...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67370/#review204158
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/sorter_tests.cpp
Lines 70 (patched)
<https://reviews.apache.org/r/67370/#comment286547>

    Put a comment about how we get the table?


- Meng Zhu


On May 29, 2018, 5:57 p.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67370/
> -----------------------------------------------------------
> 
> (Updated May 29, 2018, 5:57 p.m.)
> 
> 
> Review request for mesos, Gaston Kleiman, Greg Mann, and Meng Zhu.
> 
> 
> Bugs: MESOS-8936
>     https://issues.apache.org/jira/browse/MESOS-8936
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/tests/sorter_tests.cpp da4e0f64a565af1d9458ff256ae0eafddd0a6b68 
> 
> 
> Diff: https://reviews.apache.org/r/67370/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>