You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/08/20 19:37:38 UTC

[GitHub] sandeep-krishnamurthy closed pull request #12253: Tweaked comments for OpExecutor

sandeep-krishnamurthy closed pull request #12253: Tweaked comments for OpExecutor
URL: https://github.com/apache/incubator-mxnet/pull/12253
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/src/executor/exec_pass.h b/src/executor/exec_pass.h
index 8c483e9b2b8..cd1db0ac194 100644
--- a/src/executor/exec_pass.h
+++ b/src/executor/exec_pass.h
@@ -66,13 +66,13 @@ class OpExecutor {
   virtual ~OpExecutor() {}
   /*!
    * \brief Setup the executor for given NDArray member
-   * this can be called multiple times if NDArray changed during reshape.
-   *  It is safe to call it via asynchronize engine lambda
+   *  This can be called multiple times if NDArray changed during reshape.
+   *  It is safe to call it via an asynchronous engine lambda.
    */
   virtual void Setup() = 0;
   /*!
    * \brief run the operator given runtime context on device.
-   *  This function call do not synchronize the stream.
+   *  This function call does not synchronize the stream.
    * \param rctx The runtime context passed in by environment.
    */
   virtual void Run(RunContext rctx, bool is_gpu) = 0;


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services