You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jason Zhou <ja...@gmail.com> on 2024/06/04 15:22:04 UTC
Review Request 75027: [mesos-build] update review tidybot & docker-build.sh to support ubuntu 20.04
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75027/
-----------------------------------------------------------
Review request for mesos and Benjamin Mahler.
Repository: mesos
Description
-------
The reviewbot, tidybot, and our docker-build scripts
have been updated to use or accomodate for ubuntu 20.04.
Diffs
-----
support/docker-build.sh 4f4019001755082c8dcbea5cb0043363940d383c
support/jenkins/reviewbot.sh 349e18dfdb3786edf34300b88e7b03014ab1af59
support/mesos-tidy/Dockerfile db66a8575ba0b518ce550bf1c7cfb3d898dc9f42
Diff: https://reviews.apache.org/r/75027/diff/1/
Testing
-------
Thanks,
Jason Zhou
Re: Review Request 75027: [mesos-build] update review tidybot & docker-build.sh to support ubuntu 20.04
Posted by Jason Zhou <ja...@gmail.com>.
> On June 5, 2024, 4:41 a.m., Benjamin Mahler wrote:
> > support/mesos-build/entrypoint.sh
> > Lines 26 (patched)
> > <https://reviews.apache.org/r/75027/diff/2/?file=2288518#file2288518line26>
> >
> > Probably helps to document what this is for? I will land it as is without it but please follow up with a patch that adds a comment :)
https://reviews.apache.org/r/75029/ Documented along with a small change here
- Jason
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75027/#review226508
-----------------------------------------------------------
On June 4, 2024, 3:22 p.m., Jason Zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/75027/
> -----------------------------------------------------------
>
> (Updated June 4, 2024, 3:22 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The reviewbot, tidybot, and our docker-build scripts
> have been updated to use or accomodate for ubuntu 20.04.
>
>
> Diffs
> -----
>
> support/docker-build.sh 4f4019001755082c8dcbea5cb0043363940d383c
> support/jenkins/reviewbot.sh 349e18dfdb3786edf34300b88e7b03014ab1af59
> support/mesos-build/entrypoint.sh 865c44aef02d5a8b23a8397e8d3cc5eda331a017
> support/mesos-tidy/Dockerfile db66a8575ba0b518ce550bf1c7cfb3d898dc9f42
>
>
> Diff: https://reviews.apache.org/r/75027/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jason Zhou
>
>
Re: Review Request 75027: [mesos-build] update review tidybot & docker-build.sh to support ubuntu 20.04
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75027/#review226508
-----------------------------------------------------------
Fix it, then Ship it!
support/mesos-build/entrypoint.sh
Lines 26 (patched)
<https://reviews.apache.org/r/75027/#comment314760>
Probably helps to document what this is for? I will land it as is without it but please follow up with a patch that adds a comment :)
- Benjamin Mahler
On June 4, 2024, 3:22 p.m., Jason Zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/75027/
> -----------------------------------------------------------
>
> (Updated June 4, 2024, 3:22 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The reviewbot, tidybot, and our docker-build scripts
> have been updated to use or accomodate for ubuntu 20.04.
>
>
> Diffs
> -----
>
> support/docker-build.sh 4f4019001755082c8dcbea5cb0043363940d383c
> support/jenkins/reviewbot.sh 349e18dfdb3786edf34300b88e7b03014ab1af59
> support/mesos-build/entrypoint.sh 865c44aef02d5a8b23a8397e8d3cc5eda331a017
> support/mesos-tidy/Dockerfile db66a8575ba0b518ce550bf1c7cfb3d898dc9f42
>
>
> Diff: https://reviews.apache.org/r/75027/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jason Zhou
>
>