[GitHub] [iceberg] rdblue commented on a diff in pull request #6609: Core: Parameterize token refresh retry attemps & add test for token expiration during refresh

[GitBox <gi...@apache.org>]

rdblue commented on code in PR #6609:
URL: https://github.com/apache/iceberg/pull/6609#discussion_r1072467805


##########
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##########
@@ -165,8 +165,13 @@ public void initialize(String name, Map<String, String> unresolved) {
             CatalogProperties.AUTH_DEFAULT_REFRESH_ENABLED_DEFAULT);
     this.client = clientBuilder.apply(mergedProps);
     this.paths = ResourcePaths.forCatalogProperties(mergedProps);
+    int tokenRefreshRetries =
+        PropertyUtil.propertyAsInt(
+            props,
+            OAuth2Properties.TOKEN_REFRESH_NUM_RETRIES,
+            OAuth2Properties.TOKEN_REFRESH_NUM_RETRIES_DEFAULT);
 
-    this.catalogAuth = new AuthSession(baseHeaders, null, null, credential);
+    this.catalogAuth = new AuthSession(baseHeaders, null, null, credential, tokenRefreshRetries);

Review Comment:
   I'm not a fan of adding more properties to `AuthSession`. Maybe we should have a config object that we pass around with the default refresh interval, retry settings (including the others), and the OAuth scope?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org