You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cxf.apache.org by em...@apache.org on 2010/06/10 16:30:56 UTC

svn commit: r953334 - in /cxf/trunk/rt/ws/addr/src/main/java/org/apache/cxf/ws/addressing: ContextUtils.java MAPAggregator.java

Author: ema
Date: Thu Jun 10 14:30:56 2010
New Revision: 953334

URL: http://svn.apache.org/viewvc?rev=953334&view=rev
Log:
[CXF-2842]:Fixed the wsa:action header missing when wsam:Action= in wsdl input;[CXF-2843]:Correct the wsa action value computation for response message

Modified:
    cxf/trunk/rt/ws/addr/src/main/java/org/apache/cxf/ws/addressing/ContextUtils.java
    cxf/trunk/rt/ws/addr/src/main/java/org/apache/cxf/ws/addressing/MAPAggregator.java

Modified: cxf/trunk/rt/ws/addr/src/main/java/org/apache/cxf/ws/addressing/ContextUtils.java
URL: http://svn.apache.org/viewvc/cxf/trunk/rt/ws/addr/src/main/java/org/apache/cxf/ws/addressing/ContextUtils.java?rev=953334&r1=953333&r2=953334&view=diff
==============================================================================
--- cxf/trunk/rt/ws/addr/src/main/java/org/apache/cxf/ws/addressing/ContextUtils.java (original)
+++ cxf/trunk/rt/ws/addr/src/main/java/org/apache/cxf/ws/addressing/ContextUtils.java Thu Jun 10 14:30:56 2010
@@ -852,7 +852,7 @@ public final class ContextUtils {
         if (msgInfo != null
             && msgInfo.getExtensionAttributes() != null) {
             String attr = getAction(msgInfo);
-            if (attr != null) {
+            if (!StringUtils.isEmpty(attr)) {
                 action = attr;
                 msgInfo.setProperty(ACTION, action);
             }

Modified: cxf/trunk/rt/ws/addr/src/main/java/org/apache/cxf/ws/addressing/MAPAggregator.java
URL: http://svn.apache.org/viewvc/cxf/trunk/rt/ws/addr/src/main/java/org/apache/cxf/ws/addressing/MAPAggregator.java?rev=953334&r1=953333&r2=953334&view=diff
==============================================================================
--- cxf/trunk/rt/ws/addr/src/main/java/org/apache/cxf/ws/addressing/MAPAggregator.java (original)
+++ cxf/trunk/rt/ws/addr/src/main/java/org/apache/cxf/ws/addressing/MAPAggregator.java Thu Jun 10 14:30:56 2010
@@ -553,7 +553,7 @@ public class MAPAggregator extends Abstr
 
         if (inputMessage.getExtensionAttributes() != null) {
             String inputAction = ContextUtils.getAction(inputMessage);
-            if (inputAction != null) {
+            if (!StringUtils.isEmpty(inputAction)) {
                 return inputAction;
             }
         }
@@ -564,7 +564,7 @@ public class MAPAggregator extends Abstr
         MessageInfo outputMessage = operation.getOutput();
         if (outputMessage != null && outputMessage.getExtensionAttributes() != null) {
             String outputAction = ContextUtils.getAction(outputMessage);
-            if (outputAction != null) {
+            if (!StringUtils.isEmpty(outputAction)) {
                 return outputAction;
             }
         }
@@ -591,7 +591,7 @@ public class MAPAggregator extends Abstr
                 if (isSameFault(faultInfo, faultName)) {
                     if (faultInfo.getExtensionAttributes() != null) {
                         String faultAction = ContextUtils.getAction(faultInfo);
-                        if (faultAction != null) {
+                        if (!StringUtils.isEmpty(faultAction)) {
                             return faultAction;
                         }
                     }
@@ -685,7 +685,7 @@ public class MAPAggregator extends Abstr
             if (explicitAction != null) {
                 actionUri = explicitAction;
             } else if (null == op.getOutputName()) {
-                actionUri = addPath(opNamespace, op.getOutput().getName().getLocalPart());
+                actionUri = addPath(opNamespace, op.getName().getLocalPart() + "Response");
             } else {
                 actionUri = addPath(opNamespace, op.getOutputName());
             }