You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/11/01 00:38:12 UTC
[GitHub] [beam] alxmrs opened a new pull request, #23913: Windowing Support to the Dask Runner
alxmrs opened a new pull request, #23913:
URL: https://github.com/apache/beam/pull/23913
This is currently as work-in-progress. To server near-term goals, the Dask runner needs to support side-inputs. In order to do this, Windowing needs to be supported. This CL adds basic Windowing support to this runner, including a few tests for side inputs.
Reviewers: @pabloem
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #23913: Windowing Support for the Dask Runner
Posted by GitBox <gi...@apache.org>.
pabloem commented on PR #23913:
URL: https://github.com/apache/beam/pull/23913#issuecomment-1312026761
should I review this? : )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] commented on pull request #23913: Windowing Support to the Dask Runner
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #23913:
URL: https://github.com/apache/beam/pull/23913#issuecomment-1297878844
# [Codecov](https://codecov.io/gh/apache/beam/pull/23913?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#23913](https://codecov.io/gh/apache/beam/pull/23913?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (36bea9a) into [master](https://codecov.io/gh/apache/beam/commit/3371a1c187fa1211cb1d76e3c143c6459aa8d487?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3371a1c) will **decrease** coverage by `0.04%`.
> The diff coverage is `1.38%`.
```diff
@@ Coverage Diff @@
## master #23913 +/- ##
==========================================
- Coverage 73.85% 73.81% -0.05%
==========================================
Files 707 707
Lines 95746 95836 +90
==========================================
+ Hits 70711 70738 +27
- Misses 23719 23782 +63
Partials 1316 1316
```
| Flag | Coverage Δ | |
|---|---|---|
| python | `83.72% <1.38%> (-0.08%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/23913?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...dks/python/apache\_beam/runners/dask/dask\_runner.py](https://codecov.io/gh/apache/beam/pull/23913/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXNrL2Rhc2tfcnVubmVyLnB5) | `10.00% <0.00%> (-0.42%)` | :arrow_down: |
| [sdks/python/apache\_beam/runners/dask/overrides.py](https://codecov.io/gh/apache/beam/pull/23913/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXNrL292ZXJyaWRlcy5weQ==) | `51.85% <0.00%> (ø)` | |
| [...on/apache\_beam/runners/dask/transform\_evaluator.py](https://codecov.io/gh/apache/beam/pull/23913/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXNrL3RyYW5zZm9ybV9ldmFsdWF0b3IucHk=) | `5.40% <1.49%> (-6.60%)` | :arrow_down: |
| [...python/apache\_beam/runners/worker/worker\_status.py](https://codecov.io/gh/apache/beam/pull/23913/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvd29ya2VyX3N0YXR1cy5weQ==) | `75.33% <0.00%> (-1.34%)` | :arrow_down: |
| [sdks/python/apache\_beam/runners/direct/executor.py](https://codecov.io/gh/apache/beam/pull/23913/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvZXhlY3V0b3IucHk=) | `96.46% <0.00%> (-0.55%)` | :arrow_down: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/23913/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `93.67% <0.00%> (+0.12%)` | :arrow_up: |
| [sdks/python/apache\_beam/transforms/util.py](https://codecov.io/gh/apache/beam/pull/23913/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy91dGlsLnB5) | `96.21% <0.00%> (+0.14%)` | :arrow_up: |
| [...eam/runners/portability/fn\_api\_runner/execution.py](https://codecov.io/gh/apache/beam/pull/23913/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL2V4ZWN1dGlvbi5weQ==) | `93.08% <0.00%> (+0.64%)` | :arrow_up: |
| [.../python/apache\_beam/transforms/periodicsequence.py](https://codecov.io/gh/apache/beam/pull/23913/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9wZXJpb2RpY3NlcXVlbmNlLnB5) | `100.00% <0.00%> (+1.61%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #23913: Windowing Support for the Dask Runner
Posted by GitBox <gi...@apache.org>.
damccorm commented on PR #23913:
URL: https://github.com/apache/beam/pull/23913#issuecomment-1329315129
Tests are running
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] alxmrs commented on pull request #23913: Windowing Support to the Dask Runner
Posted by GitBox <gi...@apache.org>.
alxmrs commented on PR #23913:
URL: https://github.com/apache/beam/pull/23913#issuecomment-1304428692
@pabloem it took me a while, but I think I got it working correctly :)
I'm going to test this running Pangeo-Forge recipes this weekend / early next week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23913: Windowing Support for the Dask Runner
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23913:
URL: https://github.com/apache/beam/pull/23913#issuecomment-1346371884
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @pabloem for label python.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23913: Windowing Support for the Dask Runner
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23913:
URL: https://github.com/apache/beam/pull/23913#issuecomment-1340880721
Reminder, please take a look at this pr: @AnandInguva
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] AnandInguva commented on pull request #23913: Windowing Support for the Dask Runner
Posted by GitBox <gi...@apache.org>.
AnandInguva commented on PR #23913:
URL: https://github.com/apache/beam/pull/23913#issuecomment-1326886965
Hm it should appear as part of this https://github.com/apache/beam/pull/24324 but I don't see it in the Actions workflows
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #23913: Windowing Support for the Dask Runner
Posted by GitBox <gi...@apache.org>.
pabloem commented on PR #23913:
URL: https://github.com/apache/beam/pull/23913#issuecomment-1325658375
closing and reopening to see if I can get the newest dask runner-related action to run...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] alxmrs commented on pull request #23913: Windowing Support for the Dask Runner
Posted by GitBox <gi...@apache.org>.
alxmrs commented on PR #23913:
URL: https://github.com/apache/beam/pull/23913#issuecomment-1325923808
Do you have to merge in the upstream branch to get it to run?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] alxmrs commented on pull request #23913: Windowing Support for the Dask Runner
Posted by GitBox <gi...@apache.org>.
alxmrs commented on PR #23913:
URL: https://github.com/apache/beam/pull/23913#issuecomment-1312031853
i was going to fix the lint issues. other than that, i think this is good
to go! :)
On Fri, Nov 11, 2022 at 1:15 PM Pablo ***@***.***> wrote:
> should I review this? : )
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/beam/pull/23913#issuecomment-1312026761>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AARXAB4SRFTN6A2REJFQXK3WH2EMDANCNFSM6AAAAAARTS7FQI>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem closed pull request #23913: Windowing Support for the Dask Runner
Posted by GitBox <gi...@apache.org>.
pabloem closed pull request #23913: Windowing Support for the Dask Runner
URL: https://github.com/apache/beam/pull/23913
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm closed pull request #23913: Windowing Support for the Dask Runner
Posted by GitBox <gi...@apache.org>.
damccorm closed pull request #23913: Windowing Support for the Dask Runner
URL: https://github.com/apache/beam/pull/23913
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23913: Windowing Support for the Dask Runner
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #23913:
URL: https://github.com/apache/beam/pull/23913#issuecomment-1486823804
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] cisaacstern commented on pull request #23913: Windowing Support for the Dask Runner
Posted by "cisaacstern (via GitHub)" <gi...@apache.org>.
cisaacstern commented on PR #23913:
URL: https://github.com/apache/beam/pull/23913#issuecomment-1405431726
Thanks for the ping, @alxmrs, and glad to see this progressing.
I do not have extra bandwidth to look at this, unfortunately.
Regarding Pangeo Forge timelines, for the next 6 months or so at least, and maybe a fair bit longer, our needs are covered but the Dataflow and Flink runners.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #23913: Windowing Support for the Dask Runner
Posted by GitBox <gi...@apache.org>.
damccorm commented on PR #23913:
URL: https://github.com/apache/beam/pull/23913#issuecomment-1329219065
Looks like the job itself is broken - https://github.com/apache/beam/actions/runs/3565663232
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #23913: Windowing Support for the Dask Runner
Posted by GitBox <gi...@apache.org>.
pabloem commented on PR #23913:
URL: https://github.com/apache/beam/pull/23913#issuecomment-1320615204
fixed lint
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23913: Windowing Support for the Dask Runner
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23913:
URL: https://github.com/apache/beam/pull/23913#issuecomment-1365913640
Stopping reviewer notifications for this pull request: requested by reviewer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #23913: Windowing Support for the Dask Runner
Posted by GitBox <gi...@apache.org>.
damccorm commented on PR #23913:
URL: https://github.com/apache/beam/pull/23913#issuecomment-1329225428
https://github.com/apache/beam/pull/24376 should fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #23913: Windowing Support for the Dask Runner
Posted by GitBox <gi...@apache.org>.
damccorm commented on PR #23913:
URL: https://github.com/apache/beam/pull/23913#issuecomment-1365912632
stop reviewer notifications
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23913: Windowing Support for the Dask Runner
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23913:
URL: https://github.com/apache/beam/pull/23913#issuecomment-1359273333
Reminder, please take a look at this pr: @pabloem
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] alxmrs commented on pull request #23913: Windowing Support for the Dask Runner
Posted by "alxmrs (via GitHub)" <gi...@apache.org>.
alxmrs commented on PR #23913:
URL: https://github.com/apache/beam/pull/23913#issuecomment-1404559187
Hey Pablo! I'm happy to take a look at these dask related issues in a week or two. I imagine that these changes have diverged from the upstream main branch since they were written.
For a sooner timeline, do you have any capacity @cisaacstern or maybe @TomAugspurger? Charles, can you help me understand timelines for when Pangeo would like Dask support in Beam?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23913: Windowing Support for the Dask Runner
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23913:
URL: https://github.com/apache/beam/pull/23913#issuecomment-1320992390
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @AnandInguva for label python.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] AnandInguva commented on pull request #23913: Windowing Support for the Dask Runner
Posted by GitBox <gi...@apache.org>.
AnandInguva commented on PR #23913:
URL: https://github.com/apache/beam/pull/23913#issuecomment-1326885080
> Do you have to merge in the upstream branch to get it to run?
No, we should be able to see it in the Python unit tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #23913: Windowing Support for the Dask Runner
Posted by "pabloem (via GitHub)" <gi...@apache.org>.
pabloem commented on PR #23913:
URL: https://github.com/apache/beam/pull/23913#issuecomment-1402821563
@alxmrs how do we deal with this one? : )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] closed pull request #23913: Windowing Support for the Dask Runner
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #23913: Windowing Support for the Dask Runner
URL: https://github.com/apache/beam/pull/23913
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #23913: Windowing Support for the Dask Runner
Posted by GitBox <gi...@apache.org>.
damccorm commented on PR #23913:
URL: https://github.com/apache/beam/pull/23913#issuecomment-1365912816
(pablo is already reviewing, this one should probably be sticky)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23913: Windowing Support for the Dask Runner
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23913:
URL: https://github.com/apache/beam/pull/23913#issuecomment-1363904397
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @damccorm for label python.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #23913: Windowing Support for the Dask Runner
Posted by GitBox <gi...@apache.org>.
pabloem commented on PR #23913:
URL: https://github.com/apache/beam/pull/23913#issuecomment-1320989623
taking a look...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #23913: Windowing Support for the Dask Runner
Posted by GitBox <gi...@apache.org>.
pabloem commented on PR #23913:
URL: https://github.com/apache/beam/pull/23913#issuecomment-1324421314
the code lgtm - I'm wanting to confirm that the tests are running for Dask... I can't find them in the test history...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] AnandInguva commented on pull request #23913: Windowing Support for the Dask Runner
Posted by GitBox <gi...@apache.org>.
AnandInguva commented on PR #23913:
URL: https://github.com/apache/beam/pull/23913#issuecomment-1326885838
> Do you have to merge in the upstream branch to get it to run?
@damccorm do we need to merge this in order to see the test in Actions?
Also, other alternative is to check the `dask_runner_tests.yml` workflow on beam fork and see if it appears there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23913: Windowing Support for the Dask Runner
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #23913:
URL: https://github.com/apache/beam/pull/23913#issuecomment-1497431700
This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org