You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2017/10/26 16:31:56 UTC
Review Request 63275: Windows: Abstracted out `os::name_job` in stout.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63275/
-----------------------------------------------------------
Review request for mesos, Akash Gupta, Jeff Coffler, Jie Yu, John Kordich, and Joseph Wu.
Repository: mesos
Description
-------
Almost all uses identify a job object by the PID, but the job object
handle must be obtained by name. So this overloads `os::open_job` to
call `os::name_job` when given a PID.
Diffs
-----
3rdparty/stout/include/stout/windows/os.hpp 09ddec6d69472cd13b453fe1a77fdbe343fc23c8
Diff: https://reviews.apache.org/r/63275/diff/1/
Testing
-------
Thanks,
Andrew Schwartzmeyer
Re: Review Request 63275: Windows: Abstracted out `os::name_job` in
stout.
Posted by Jeff Coffler <je...@taltos.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63275/#review189355
-----------------------------------------------------------
Ship it!
Ship It!
- Jeff Coffler
On Oct. 26, 2017, 4:31 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63275/
> -----------------------------------------------------------
>
> (Updated Oct. 26, 2017, 4:31 p.m.)
>
>
> Review request for mesos, Akash Gupta, Jeff Coffler, Jie Yu, John Kordich, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Almost all uses identify a job object by the PID, but the job object
> handle must be obtained by name. So this overloads `os::open_job` to
> call `os::name_job` when given a PID.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/windows/os.hpp 09ddec6d69472cd13b453fe1a77fdbe343fc23c8
>
>
> Diff: https://reviews.apache.org/r/63275/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>