You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2024/04/05 11:27:15 UTC
[Bug 68862] New: InputBuffer#handleReadException breaks FailedRequestFilter
https://bz.apache.org/bugzilla/show_bug.cgi?id=68862
Bug ID: 68862
Summary: InputBuffer#handleReadException breaks
FailedRequestFilter
Product: Tomcat 10
Version: 10.1.18
Hardware: PC
OS: All
Status: NEW
Severity: normal
Priority: P2
Component: Catalina
Assignee: dev@tomcat.apache.org
Reporter: christoph.empl@mgm-tp.com
Target Milestone: ------
InputBuffer#handleReadException calls (since e77176c) Response#sendError.
If you use FailedRequestFilter and a SocketTimeoutException occurs while
parsing request parameters, this change leads to an IllegalStateException in
org.apache.catalina.connector.ResponseFacade.checkCommitted:
java.lang.IllegalStateException: Cannot call sendError() after the response has
been committed
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 68862] InputBuffer#handleReadException breaks FailedRequestFilter
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=68862
--- Comment #3 from Christoph Empl <ch...@mgm-tp.com> ---
I don't think that this commit
(https://github.com/apache/tomcat/commit/e7f902bb73c15a75e153c4a25036eabe788d3bb6)
fixes the error to the full extent.
In my use case, the IllegalStateException is thrown when FailedRequestFilter
calls Response#sendError.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 68862] InputBuffer#handleReadException breaks FailedRequestFilter
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=68862
--- Comment #1 from Christoph Empl <ch...@mgm-tp.com> ---
Correction of my description: InputBuffer calls Response#sendError since
https://github.com/apache/tomcat/commit/700d582b508d899aa6dd2d1cc1e42c12e9f47ba0
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 68862] InputBuffer#handleReadException breaks FailedRequestFilter
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=68862
--- Comment #5 from Christoph Empl <ch...@mgm-tp.com> ---
org.apache.catalina.filters.FailedRequestFilter
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 68862] InputBuffer#handleReadException breaks FailedRequestFilter
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=68862
Christoph Empl <ch...@mgm-tp.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|FIXED |---
Status|RESOLVED |REOPENED
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 68862] InputBuffer#handleReadException breaks FailedRequestFilter
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=68862
Remy Maucherat <re...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|REOPENED |RESOLVED
Resolution|--- |FIXED
--- Comment #6 from Remy Maucherat <re...@apache.org> ---
This code was removed, so I forgot about it. I added a catch ISE for now in
FailedRequestFilter.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 68862] InputBuffer#handleReadException breaks FailedRequestFilter
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=68862
Remy Maucherat <re...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|NEW |RESOLVED
--- Comment #2 from Remy Maucherat <re...@apache.org> ---
Ok, it is better to fallback when there's a NPE due to commit. The fix will be
in 11.0.0-M19, 10.1.21 and 9.0.88.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 68862] InputBuffer#handleReadException breaks FailedRequestFilter
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=68862
--- Comment #4 from Remy Maucherat <re...@apache.org> ---
What is FailedRequestFilter ?
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org