You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by mg...@apache.org on 2017/12/30 22:45:14 UTC
wicket git commit: WICKET-6484 Wicket.Cookie.set does not set
'secure' flag
Repository: wicket
Updated Branches:
refs/heads/master 02808f7d0 -> 8403c3725
WICKET-6484 Wicket.Cookie.set does not set 'secure' flag
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/8403c372
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/8403c372
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/8403c372
Branch: refs/heads/master
Commit: 8403c3725d71c33b87b3c4e196cf078e7762840d
Parents: 02808f7
Author: Martin Tzvetanov Grigorov <mg...@apache.org>
Authored: Sun Dec 31 00:44:48 2017 +0200
Committer: Martin Tzvetanov Grigorov <mg...@apache.org>
Committed: Sun Dec 31 00:44:48 2017 +0200
----------------------------------------------------------------------
.../wicket/extensions/ajax/markup/html/modal/res/modal.js | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/wicket/blob/8403c372/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js
----------------------------------------------------------------------
diff --git a/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js b/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js
index 83e1d26..b00ceec 100644
--- a/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js
+++ b/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js
@@ -1667,7 +1667,10 @@
set: function(name, value, expiredays) {
var exdate = new Date();
exdate.setDate(exdate.getDate() + expiredays);
- document.cookie = name + "=" + window.escape(value) + ((expiredays === null) ? "" : ";expires="+exdate);
+ var secure = /^https/.test(location.protocol) ? ';secure' : '';
+ document.cookie = name + "=" + window.escape(value) +
+ ((expiredays === null) ? "" : ";expires="+exdate) +
+ secure;
}
};