You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2019/03/03 01:01:52 UTC
Review Request 70096: Moved cpplint configuration into dedicated file.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70096/
-----------------------------------------------------------
Review request for mesos and Benjamin Mahler.
Repository: mesos
Description
-------
Moved cpplint configuration into dedicated file.
Diffs
-----
bootstrap 7be2cc95c7ace55d710315427f38284cc5b2af4c
support/CPPLINT.cfg PRE-CREATION
support/mesos-style.py 11d5f96d4ca534a7d51ed93d2d6b0c528d31fad4
Diff: https://reviews.apache.org/r/70096/diff/1/
Testing
-------
* confirmed that `./support/mesos-style.py src/executor/executor.cpp` still does what is expected
* no new warnings when running over the whole codebase
Thanks,
Benjamin Bannier
Re: Review Request 70096: Moved cpplint configuration into dedicated
file.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70096/#review213483
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rukletsov
On March 3, 2019, 1:01 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70096/
> -----------------------------------------------------------
>
> (Updated March 3, 2019, 1:01 a.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Moved cpplint configuration into dedicated file.
>
>
> Diffs
> -----
>
> bootstrap 7be2cc95c7ace55d710315427f38284cc5b2af4c
> support/CPPLINT.cfg PRE-CREATION
> support/mesos-style.py 11d5f96d4ca534a7d51ed93d2d6b0c528d31fad4
>
>
> Diff: https://reviews.apache.org/r/70096/diff/1/
>
>
> Testing
> -------
>
> * confirmed that `./support/mesos-style.py src/executor/executor.cpp` still does what is expected
> * no new warnings when running over the whole codebase
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 70096: Moved cpplint configuration into dedicated
file.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70096/#review217282
-----------------------------------------------------------
Ship it!
Ship It!
- Benno Evers
On Aug. 14, 2019, 11:25 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70096/
> -----------------------------------------------------------
>
> (Updated Aug. 14, 2019, 11:25 a.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-9630
> https://issues.apache.org/jira/browse/MESOS-9630
>
>
> Repository: mesos
>
>
> Description
> -------
>
> With this change we not only reduce the amount of code in
> `support/mesos-style.py` in favor of a configuration supported by
> upstream, but we also make it easier to interoperate with editor
> integrations for cpplint.
>
>
> Diffs
> -----
>
> bootstrap 7be2cc95c7ace55d710315427f38284cc5b2af4c
> bootstrap.bat 584b5c3ca228ff485b22473cd167d3f454d6dad4
> support/CPPLINT.cfg PRE-CREATION
> support/gitignore 7218eda0d78b8e6fc4568f215016961bd7a11a1b
> support/mesos-style.py cd490bd3deeb8477295bbad010f36d984ce17d27
>
>
> Diff: https://reviews.apache.org/r/70096/diff/7/
>
>
> Testing
> -------
>
> * confirmed that `./support/mesos-style.py src/executor/executor.cpp` still does what is expected
> * no new warnings when running over the whole codebase
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 70096: Moved cpplint configuration into dedicated
file.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70096/#review217457
-----------------------------------------------------------
Fix it, then Ship it!
bootstrap.bat
Lines 60 (patched)
<https://reviews.apache.org/r/70096/#comment304721>
s/mlink/mklink/
- Joseph Wu
On Aug. 14, 2019, 4:25 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70096/
> -----------------------------------------------------------
>
> (Updated Aug. 14, 2019, 4:25 a.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-9630
> https://issues.apache.org/jira/browse/MESOS-9630
>
>
> Repository: mesos
>
>
> Description
> -------
>
> With this change we not only reduce the amount of code in
> `support/mesos-style.py` in favor of a configuration supported by
> upstream, but we also make it easier to interoperate with editor
> integrations for cpplint.
>
>
> Diffs
> -----
>
> bootstrap 7be2cc95c7ace55d710315427f38284cc5b2af4c
> bootstrap.bat 584b5c3ca228ff485b22473cd167d3f454d6dad4
> support/CPPLINT.cfg PRE-CREATION
> support/gitignore 7218eda0d78b8e6fc4568f215016961bd7a11a1b
> support/mesos-style.py cd490bd3deeb8477295bbad010f36d984ce17d27
>
>
> Diff: https://reviews.apache.org/r/70096/diff/7/
>
>
> Testing
> -------
>
> * confirmed that `./support/mesos-style.py src/executor/executor.cpp` still does what is expected
> * no new warnings when running over the whole codebase
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 70096: Moved cpplint configuration into dedicated
file.
Posted by Till Toenshoff via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70096/#review217431
-----------------------------------------------------------
Ship it!
bootstrap
Lines 84 (patched)
<https://reviews.apache.org/r/70096/#comment304707>
Too bad cpplint does not allow for hidden config files like e.g. `.cpplintrc` - but this code tells us; https://github.com/cpplint/cpplint/blob/master/cpplint.py#L6220-L6228
- Till Toenshoff
On Aug. 14, 2019, 11:25 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70096/
> -----------------------------------------------------------
>
> (Updated Aug. 14, 2019, 11:25 a.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-9630
> https://issues.apache.org/jira/browse/MESOS-9630
>
>
> Repository: mesos
>
>
> Description
> -------
>
> With this change we not only reduce the amount of code in
> `support/mesos-style.py` in favor of a configuration supported by
> upstream, but we also make it easier to interoperate with editor
> integrations for cpplint.
>
>
> Diffs
> -----
>
> bootstrap 7be2cc95c7ace55d710315427f38284cc5b2af4c
> bootstrap.bat 584b5c3ca228ff485b22473cd167d3f454d6dad4
> support/CPPLINT.cfg PRE-CREATION
> support/gitignore 7218eda0d78b8e6fc4568f215016961bd7a11a1b
> support/mesos-style.py cd490bd3deeb8477295bbad010f36d984ce17d27
>
>
> Diff: https://reviews.apache.org/r/70096/diff/7/
>
>
> Testing
> -------
>
> * confirmed that `./support/mesos-style.py src/executor/executor.cpp` still does what is expected
> * no new warnings when running over the whole codebase
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 70096: Moved cpplint configuration into dedicated
file.
Posted by Benjamin Bannier <bb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70096/
-----------------------------------------------------------
(Updated Aug. 28, 2019, 11:04 a.m.)
Review request for mesos and Benjamin Mahler.
Bugs: MESOS-9630
https://issues.apache.org/jira/browse/MESOS-9630
Repository: mesos
Description
-------
With this change we not only reduce the amount of code in
`support/mesos-style.py` in favor of a configuration supported by
upstream, but we also make it easier to interoperate with editor
integrations for cpplint.
Diffs (updated)
-----
bootstrap 7be2cc95c7ace55d710315427f38284cc5b2af4c
bootstrap.bat 584b5c3ca228ff485b22473cd167d3f454d6dad4
support/CPPLINT.cfg PRE-CREATION
support/gitignore 7218eda0d78b8e6fc4568f215016961bd7a11a1b
support/mesos-style.py cd490bd3deeb8477295bbad010f36d984ce17d27
Diff: https://reviews.apache.org/r/70096/diff/8/
Changes: https://reviews.apache.org/r/70096/diff/7-8/
Testing
-------
* confirmed that `./support/mesos-style.py src/executor/executor.cpp` still does what is expected
* no new warnings when running over the whole codebase
Thanks,
Benjamin Bannier
Re: Review Request 70096: Moved cpplint configuration into dedicated
file.
Posted by Benjamin Bannier <bb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70096/
-----------------------------------------------------------
(Updated Aug. 14, 2019, 1:25 p.m.)
Review request for mesos and Benjamin Mahler.
Repository: mesos
Description (updated)
-------
With this change we not only reduce the amount of code in
`support/mesos-style.py` in favor of a configuration supported by
upstream, but we also make it easier to interoperate with editor
integrations for cpplint.
Diffs (updated)
-----
bootstrap 7be2cc95c7ace55d710315427f38284cc5b2af4c
support/CPPLINT.cfg PRE-CREATION
support/mesos-style.py cd490bd3deeb8477295bbad010f36d984ce17d27
Diff: https://reviews.apache.org/r/70096/diff/3/
Changes: https://reviews.apache.org/r/70096/diff/2-3/
Testing
-------
* confirmed that `./support/mesos-style.py src/executor/executor.cpp` still does what is expected
* no new warnings when running over the whole codebase
Thanks,
Benjamin Bannier
Re: Review Request 70096: Moved cpplint configuration into dedicated
file.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70096/#review217201
-----------------------------------------------------------
Can you maybe clarify in the commit description what the advantage of having this in a separate file is?
This is going to clutter the source dir with a very visible, screaming-case `CPPLINT.cfg` file, so all other things being equal it seems like passing these settings via command-line instead would be preferrable?
- Benno Evers
On March 3, 2019, 1:01 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70096/
> -----------------------------------------------------------
>
> (Updated March 3, 2019, 1:01 a.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Moved cpplint configuration into dedicated file.
>
>
> Diffs
> -----
>
> bootstrap 7be2cc95c7ace55d710315427f38284cc5b2af4c
> support/CPPLINT.cfg PRE-CREATION
> support/mesos-style.py b14820a1efe32c9c6e093b6f9cea93cb55ec97e4
>
>
> Diff: https://reviews.apache.org/r/70096/diff/2/
>
>
> Testing
> -------
>
> * confirmed that `./support/mesos-style.py src/executor/executor.cpp` still does what is expected
> * no new warnings when running over the whole codebase
>
>
> Thanks,
>
> Benjamin Bannier
>
>