You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2019/01/11 11:22:48 UTC
Review Request 69721: Broke up `SSLTest.ProtocolMismatch` into
smaller tests.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69721/
-----------------------------------------------------------
Review request for mesos and Till Toenshoff.
Bugs: MESOS-5189
https://issues.apache.org/jira/browse/MESOS-5189
Repository: mesos
Description
-------
This patch breaks up the different iterations in
`SSLTest.ProtocolMismatch` into smaller tests
`SSLProtocol/SSLProtocolTest.Mismatch/N`. While this slightly
increases the time to run all combinations sequentially, it leads to
much shorter aggregated run time in parallel test execution.
Diffs
-----
3rdparty/libprocess/src/tests/ssl_tests.cpp bfb5eab255230b7fbfdefaa62be27a8f8c4e9517
Diff: https://reviews.apache.org/r/69721/diff/1/
Testing
-------
`make check`
Thanks,
Benjamin Bannier
Re: Review Request 69721: Broke up `SSLTest.ProtocolMismatch` into
smaller tests.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69721/#review211880
-----------------------------------------------------------
PASS: Mesos patch 69721 was successfully built and tested.
Reviews applied: `['69720', '69721']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2760/mesos-review-69721
- Mesos Reviewbot Windows
On Jan. 11, 2019, 3:22 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69721/
> -----------------------------------------------------------
>
> (Updated Jan. 11, 2019, 3:22 a.m.)
>
>
> Review request for mesos and Till Toenshoff.
>
>
> Bugs: MESOS-5189
> https://issues.apache.org/jira/browse/MESOS-5189
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch breaks up the different iterations in
> `SSLTest.ProtocolMismatch` into smaller tests
> `SSLProtocol/SSLProtocolTest.Mismatch/N`. While this slightly
> increases the time to run all combinations sequentially, it leads to
> much shorter aggregated run time in parallel test execution.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/tests/ssl_tests.cpp bfb5eab255230b7fbfdefaa62be27a8f8c4e9517
>
>
> Diff: https://reviews.apache.org/r/69721/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 69721: Broke up `SSLTest.ProtocolMismatch` into
smaller tests.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69721/#review211958
-----------------------------------------------------------
Ship it!
Ship It!
- Joseph Wu
On Jan. 11, 2019, 3:22 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69721/
> -----------------------------------------------------------
>
> (Updated Jan. 11, 2019, 3:22 a.m.)
>
>
> Review request for mesos and Till Toenshoff.
>
>
> Bugs: MESOS-5189
> https://issues.apache.org/jira/browse/MESOS-5189
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch breaks up the different iterations in
> `SSLTest.ProtocolMismatch` into smaller tests
> `SSLProtocol/SSLProtocolTest.Mismatch/N`. While this slightly
> increases the time to run all combinations sequentially, it leads to
> much shorter aggregated run time in parallel test execution.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/tests/ssl_tests.cpp bfb5eab255230b7fbfdefaa62be27a8f8c4e9517
>
>
> Diff: https://reviews.apache.org/r/69721/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 69721: Broke up `SSLTest.ProtocolMismatch` into
smaller tests.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69721/#review211969
-----------------------------------------------------------
PASS: Mesos patch 69721 was successfully built and tested.
Reviews applied: `['69720', '69721']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2775/mesos-review-69721
- Mesos Reviewbot Windows
On Jan. 14, 2019, 7:54 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69721/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2019, 7:54 p.m.)
>
>
> Review request for mesos and Till Toenshoff.
>
>
> Bugs: MESOS-5189
> https://issues.apache.org/jira/browse/MESOS-5189
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch breaks up the different iterations in
> `SSLTest.ProtocolMismatch` into smaller tests
> `SSLProtocol/SSLProtocolTest.Mismatch/N`. While this slightly
> increases the time to run all combinations sequentially, it leads to
> much shorter aggregated run time in parallel test execution.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/tests/ssl_tests.cpp bfb5eab255230b7fbfdefaa62be27a8f8c4e9517
>
>
> Diff: https://reviews.apache.org/r/69721/diff/2/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 69721: Broke up `SSLTest.ProtocolMismatch` into
smaller tests.
Posted by Till Toenshoff via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69721/#review212036
-----------------------------------------------------------
Ship it!
Ship It!
- Till Toenshoff
On Jan. 14, 2019, 7:54 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69721/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2019, 7:54 p.m.)
>
>
> Review request for mesos and Till Toenshoff.
>
>
> Bugs: MESOS-5189
> https://issues.apache.org/jira/browse/MESOS-5189
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch breaks up the different iterations in
> `SSLTest.ProtocolMismatch` into smaller tests
> `SSLProtocol/SSLProtocolTest.Mismatch/N`. While this slightly
> increases the time to run all combinations sequentially, it leads to
> much shorter aggregated run time in parallel test execution.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/tests/ssl_tests.cpp bfb5eab255230b7fbfdefaa62be27a8f8c4e9517
>
>
> Diff: https://reviews.apache.org/r/69721/diff/2/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 69721: Broke up `SSLTest.ProtocolMismatch` into
smaller tests.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69721/
-----------------------------------------------------------
(Updated Jan. 14, 2019, 8:54 p.m.)
Review request for mesos and Till Toenshoff.
Changes
-------
Reordered tests.
Bugs: MESOS-5189
https://issues.apache.org/jira/browse/MESOS-5189
Repository: mesos
Description
-------
This patch breaks up the different iterations in
`SSLTest.ProtocolMismatch` into smaller tests
`SSLProtocol/SSLProtocolTest.Mismatch/N`. While this slightly
increases the time to run all combinations sequentially, it leads to
much shorter aggregated run time in parallel test execution.
Diffs (updated)
-----
3rdparty/libprocess/src/tests/ssl_tests.cpp bfb5eab255230b7fbfdefaa62be27a8f8c4e9517
Diff: https://reviews.apache.org/r/69721/diff/2/
Changes: https://reviews.apache.org/r/69721/diff/1-2/
Testing
-------
`make check`
Thanks,
Benjamin Bannier