You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@wicket.apache.org by renoth <gi...@git.apache.org> on 2018/08/30 20:08:55 UTC

[GitHub] wicket pull request #287: Considering upgrading to Junit5

Github user renoth commented on a diff in the pull request:

    https://github.com/apache/wicket/pull/287#discussion_r214164481
  
    --- Diff: wicket-util/src/test/java/org/apache/wicket/util/collections/IntHashMapTest.java ---
    @@ -48,9 +46,9 @@ public void serialize() throws IOException, ClassNotFoundException
     		ByteArrayInputStream bais = new ByteArrayInputStream(serialized);
     		ObjectInputStream ois = new ObjectInputStream(bais);
     		IntHashMap<String> deserialized = (IntHashMap<String>) ois.readObject();
    -		assertThat(deserialized, is(notNullValue()));
    -		assertThat(deserialized.get(1), is(equalTo("one")));
    -		assertThat(deserialized.get(2), is(equalTo("two")));
    +		assertNotNull(deserialized);
    +		assertEquals(deserialized.get(1), "one");
    --- End diff --
    
    No you are right, it should be reversed (expected, actual)


---