You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Guangya Liu <gy...@gmail.com> on 2016/04/15 16:23:00 UTC
Re: Review Request 45270: Added spec protobuf for external mount.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45270/
-----------------------------------------------------------
(Updated 四月 15, 2016, 2:23 p.m.)
Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and Jie Yu.
Summary (updated)
-----------------
Added spec protobuf for external mount.
Bugs: MESOS-5013
https://issues.apache.org/jira/browse/MESOS-5013
Repository: mesos
Description (updated)
-------
Added spec protobuf for external mount.
Diffs (updated)
-----
src/CMakeLists.txt 06f58c4a88e3c527df727df1efe11ed3ab77efa8
src/Makefile.am ec855263d620e4723c8ba9cd056c40a3a2e9ca99
src/slave/containerizer/mesos/isolators/docker/volume/state.proto PRE-CREATION
Diff: https://reviews.apache.org/r/45270/diff/
Testing
-------
make
make check
Thanks,
Guangya Liu
Re: Review Request 45270: Added spec protobuf for DockerVolumeMount.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45270/#review129650
-----------------------------------------------------------
src/slave/containerizer/mesos/isolators/docker/volume/state.proto (line 21)
<https://reviews.apache.org/r/45270/#comment193137>
s/DockerVolumeMount/DockerVolume/
src/slave/containerizer/mesos/isolators/docker/volume/state.proto (line 22)
<https://reviews.apache.org/r/45270/#comment193138>
s/volume_driver/driver/
s/volume_name/name/
Volume already in the message Type.
src/slave/containerizer/mesos/isolators/docker/volume/state.proto (line 27)
<https://reviews.apache.org/r/45270/#comment193139>
s/DockerVolumeMountList/DockerVolumes/
src/slave/containerizer/mesos/isolators/docker/volume/state.proto (line 28)
<https://reviews.apache.org/r/45270/#comment193141>
s/mounts/volumes/
- Jie Yu
On April 19, 2016, 3:04 p.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45270/
> -----------------------------------------------------------
>
> (Updated April 19, 2016, 3:04 p.m.)
>
>
> Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and Jie Yu.
>
>
> Bugs: MESOS-5013
> https://issues.apache.org/jira/browse/MESOS-5013
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added spec protobuf for DockerVolumeMount.
> The DockerVolumeMount was used to check point the mount
> point for each container to recover.
>
>
> Diffs
> -----
>
> src/CMakeLists.txt aabb33dfd4b985fe5774f87bb63b4ec1ec853962
> src/Makefile.am 5a2b4efa781752863d6751f98614fb78bece73ac
> src/slave/containerizer/mesos/isolators/docker/volume/state.proto PRE-CREATION
>
> Diff: https://reviews.apache.org/r/45270/diff/
>
>
> Testing
> -------
>
> make
> make check
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 45270: Added spec protobuf for DockerVolumeMount.
Posted by Guangya Liu <gy...@gmail.com>.
> On 四月 19, 2016, 5:27 p.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/isolators/docker/volume/state.proto, lines 32-46
> > <https://reviews.apache.org/r/45270/diff/9/?file=1350577#file1350577line32>
> >
> > I still don't understand why we want to make it a protobuf? Can that just be a nested struct in the isolator?
OK, will move this to struct.
- Guangya
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45270/#review129570
-----------------------------------------------------------
On 四月 19, 2016, 3:04 p.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45270/
> -----------------------------------------------------------
>
> (Updated 四月 19, 2016, 3:04 p.m.)
>
>
> Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and Jie Yu.
>
>
> Bugs: MESOS-5013
> https://issues.apache.org/jira/browse/MESOS-5013
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added spec protobuf for DockerVolumeMount.
> The DockerVolumeMount was used to check point the mount
> point for each container to recover.
>
>
> Diffs
> -----
>
> src/CMakeLists.txt aabb33dfd4b985fe5774f87bb63b4ec1ec853962
> src/Makefile.am 5a2b4efa781752863d6751f98614fb78bece73ac
> src/slave/containerizer/mesos/isolators/docker/volume/state.proto PRE-CREATION
>
> Diff: https://reviews.apache.org/r/45270/diff/
>
>
> Testing
> -------
>
> make
> make check
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 45270: Added spec protobuf for DockerVolumeMount.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45270/#review129570
-----------------------------------------------------------
src/CMakeLists.txt (line 55)
<https://reviews.apache.org/r/45270/#comment193000>
s/SPEC/STATE/?
src/CMakeLists.txt (line 88)
<https://reviews.apache.org/r/45270/#comment193001>
Ditto.
src/slave/containerizer/mesos/isolators/docker/volume/state.proto (line 27)
<https://reviews.apache.org/r/45270/#comment193002>
s/DockerVolumeMountList/DockerVolumeMounts/
src/slave/containerizer/mesos/isolators/docker/volume/state.proto (lines 32 - 46)
<https://reviews.apache.org/r/45270/#comment193003>
I still don't understand why we want to make it a protobuf? Can that just be a nested struct in the isolator?
- Jie Yu
On April 19, 2016, 3:04 p.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45270/
> -----------------------------------------------------------
>
> (Updated April 19, 2016, 3:04 p.m.)
>
>
> Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and Jie Yu.
>
>
> Bugs: MESOS-5013
> https://issues.apache.org/jira/browse/MESOS-5013
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added spec protobuf for DockerVolumeMount.
> The DockerVolumeMount was used to check point the mount
> point for each container to recover.
>
>
> Diffs
> -----
>
> src/CMakeLists.txt aabb33dfd4b985fe5774f87bb63b4ec1ec853962
> src/Makefile.am 5a2b4efa781752863d6751f98614fb78bece73ac
> src/slave/containerizer/mesos/isolators/docker/volume/state.proto PRE-CREATION
>
> Diff: https://reviews.apache.org/r/45270/diff/
>
>
> Testing
> -------
>
> make
> make check
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 45270: Added spec protobuf for DockerVolume.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45270/#review129751
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On April 20, 2016, 10:57 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45270/
> -----------------------------------------------------------
>
> (Updated April 20, 2016, 10:57 a.m.)
>
>
> Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and Jie Yu.
>
>
> Bugs: MESOS-5013
> https://issues.apache.org/jira/browse/MESOS-5013
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added spec protobuf for DockerVolume.
> The DockerVolume was used to check point the mount
> point for each container when recover.
>
>
> Diffs
> -----
>
> src/CMakeLists.txt e4923c4d4a7a9eefcab9267fe5def7f7535e49ed
> src/Makefile.am 5a2b4efa781752863d6751f98614fb78bece73ac
> src/slave/containerizer/mesos/isolators/docker/volume/state.hpp PRE-CREATION
> src/slave/containerizer/mesos/isolators/docker/volume/state.proto PRE-CREATION
>
> Diff: https://reviews.apache.org/r/45270/diff/
>
>
> Testing
> -------
>
> make
> make check
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 45270: Added spec protobuf for DockerVolume.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45270/#review129753
-----------------------------------------------------------
src/Makefile.am (line 837)
<https://reviews.apache.org/r/45270/#comment193291>
Why remove paths.hpp??
Please be careful and do a make distcheck when submitting a patch.
- Jie Yu
On April 20, 2016, 10:57 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45270/
> -----------------------------------------------------------
>
> (Updated April 20, 2016, 10:57 a.m.)
>
>
> Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and Jie Yu.
>
>
> Bugs: MESOS-5013
> https://issues.apache.org/jira/browse/MESOS-5013
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added spec protobuf for DockerVolume.
> The DockerVolume was used to check point the mount
> point for each container when recover.
>
>
> Diffs
> -----
>
> src/CMakeLists.txt e4923c4d4a7a9eefcab9267fe5def7f7535e49ed
> src/Makefile.am 5a2b4efa781752863d6751f98614fb78bece73ac
> src/slave/containerizer/mesos/isolators/docker/volume/state.hpp PRE-CREATION
> src/slave/containerizer/mesos/isolators/docker/volume/state.proto PRE-CREATION
>
> Diff: https://reviews.apache.org/r/45270/diff/
>
>
> Testing
> -------
>
> make
> make check
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 45270: Added spec protobuf for DockerVolume.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45270/
-----------------------------------------------------------
(Updated 四月 20, 2016, 5:39 p.m.)
Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and Jie Yu.
Bugs: MESOS-5013
https://issues.apache.org/jira/browse/MESOS-5013
Repository: mesos
Description
-------
Added spec protobuf for DockerVolume.
The DockerVolume was used to check point the mount
point for each container when recover.
Diffs (updated)
-----
src/CMakeLists.txt e4923c4d4a7a9eefcab9267fe5def7f7535e49ed
src/Makefile.am 5a2b4efa781752863d6751f98614fb78bece73ac
src/slave/containerizer/mesos/isolators/docker/volume/state.hpp PRE-CREATION
src/slave/containerizer/mesos/isolators/docker/volume/state.proto PRE-CREATION
Diff: https://reviews.apache.org/r/45270/diff/
Testing
-------
make
make check
Thanks,
Guangya Liu
Re: Review Request 45270: Added spec protobuf for DockerVolume.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45270/
-----------------------------------------------------------
(Updated 四月 20, 2016, 10:57 a.m.)
Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and Jie Yu.
Summary (updated)
-----------------
Added spec protobuf for DockerVolume.
Bugs: MESOS-5013
https://issues.apache.org/jira/browse/MESOS-5013
Repository: mesos
Description
-------
Added spec protobuf for DockerVolume.
The DockerVolume was used to check point the mount
point for each container when recover.
Diffs (updated)
-----
src/CMakeLists.txt e4923c4d4a7a9eefcab9267fe5def7f7535e49ed
src/Makefile.am 5a2b4efa781752863d6751f98614fb78bece73ac
src/slave/containerizer/mesos/isolators/docker/volume/state.hpp PRE-CREATION
src/slave/containerizer/mesos/isolators/docker/volume/state.proto PRE-CREATION
Diff: https://reviews.apache.org/r/45270/diff/
Testing
-------
make
make check
Thanks,
Guangya Liu
Re: Review Request 45270: Added spec protobuf for DockerVolumeMount.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45270/
-----------------------------------------------------------
(Updated 四月 20, 2016, 6:38 a.m.)
Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and Jie Yu.
Bugs: MESOS-5013
https://issues.apache.org/jira/browse/MESOS-5013
Repository: mesos
Description (updated)
-------
Added spec protobuf for DockerVolume.
The DockerVolume was used to check point the mount
point for each container when recover.
Diffs (updated)
-----
src/CMakeLists.txt e4923c4d4a7a9eefcab9267fe5def7f7535e49ed
src/Makefile.am 5a2b4efa781752863d6751f98614fb78bece73ac
src/slave/containerizer/mesos/isolators/docker/volume/state.proto PRE-CREATION
Diff: https://reviews.apache.org/r/45270/diff/
Testing
-------
make
make check
Thanks,
Guangya Liu
Re: Review Request 45270: Added spec protobuf for DockerVolumeMount.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45270/
-----------------------------------------------------------
(Updated 四月 19, 2016, 3:04 p.m.)
Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and Jie Yu.
Bugs: MESOS-5013
https://issues.apache.org/jira/browse/MESOS-5013
Repository: mesos
Description (updated)
-------
Added spec protobuf for DockerVolumeMount.
The DockerVolumeMount was used to check point the mount
point for each container to recover.
Diffs (updated)
-----
src/CMakeLists.txt aabb33dfd4b985fe5774f87bb63b4ec1ec853962
src/Makefile.am 5a2b4efa781752863d6751f98614fb78bece73ac
src/slave/containerizer/mesos/isolators/docker/volume/state.proto PRE-CREATION
Diff: https://reviews.apache.org/r/45270/diff/
Testing
-------
make
make check
Thanks,
Guangya Liu
Re: Review Request 45270: Added spec protobuf for DockerVolumeMount.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45270/
-----------------------------------------------------------
(Updated 四月 15, 2016, 11:56 p.m.)
Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and Jie Yu.
Bugs: MESOS-5013
https://issues.apache.org/jira/browse/MESOS-5013
Repository: mesos
Description (updated)
-------
Added spec protobuf for DockerVolumeMount. The DockerVolumeMount
was used to check point the mount point for each container to recover.
Diffs
-----
src/CMakeLists.txt 06f58c4a88e3c527df727df1efe11ed3ab77efa8
src/Makefile.am ec855263d620e4723c8ba9cd056c40a3a2e9ca99
src/slave/containerizer/mesos/isolators/docker/volume/state.proto PRE-CREATION
Diff: https://reviews.apache.org/r/45270/diff/
Testing
-------
make
make check
Thanks,
Guangya Liu
Re: Review Request 45270: Added spec protobuf for DockerVolumeMount.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45270/
-----------------------------------------------------------
(Updated 四月 15, 2016, 2:44 p.m.)
Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and Jie Yu.
Summary (updated)
-----------------
Added spec protobuf for DockerVolumeMount.
Bugs: MESOS-5013
https://issues.apache.org/jira/browse/MESOS-5013
Repository: mesos
Description (updated)
-------
Added spec protobuf for DockerVolumeMount. The DockerVolumeMount was used to check point the mount point for each container to recover.
Diffs
-----
src/CMakeLists.txt 06f58c4a88e3c527df727df1efe11ed3ab77efa8
src/Makefile.am ec855263d620e4723c8ba9cd056c40a3a2e9ca99
src/slave/containerizer/mesos/isolators/docker/volume/state.proto PRE-CREATION
Diff: https://reviews.apache.org/r/45270/diff/
Testing
-------
make
make check
Thanks,
Guangya Liu