You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by Alexandre Rafalovitch <ar...@gmail.com> on 2014/12/06 20:45:27 UTC
Minimum test set for idempotent changes in schema.xml
Hi,
I want to do some minor cleanup in (multiple) schema.xml. What's the
minimum set of tests I need to run before I submit a patch?
'ant test' seems to be a heavy thing. Is there a way to say, just
schema-related ones?
Regards,
Alex.
Personal: http://www.outerthoughts.com/ and @arafalov
Solr resources and newsletter: http://www.solr-start.com/ and @solrstart
Solr popularizers community: https://www.linkedin.com/groups?gid=6713853
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: Minimum test set for idempotent changes in schema.xml
Posted by Alexandre Rafalovitch <ar...@gmail.com>.
You are both right :-)
I was modifying schema.xml in the distribution and wanted to know
whether we had any Solr tests that covered/tested those files to
ensure I did not break anything.
I did not find any specific to my - truly minor - changes (now in
SOLR-6826), so ended up running the full suite.
David, your suggestion though is great for the future, so I appreciate it.
Regards,
Alex.
Personal: http://www.outerthoughts.com/ and @arafalov
Solr resources and newsletter: http://www.solr-start.com/ and @solrstart
Solr popularizers community: https://www.linkedin.com/groups?gid=6713853
On 7 December 2014 at 00:04, david.w.smiley@gmail.com
<da...@gmail.com> wrote:
> I think I misunderstood what Alex wanted. Now, I think he wants to know
> which tests exercise the schemas/config that users see (e.g. the example
> ones). I suggest running tests with “Example” in the name:
> ant test -Dtestcase=“*Example*"
>
> ~ David Smiley
> Freelance Apache Lucene/Solr Search Consultant/Developer
> http://www.linkedin.com/in/davidwsmiley
>
> On Sat, Dec 6, 2014 at 11:37 PM, Michael Wechner <mi...@wyona.com>
> wrote:
>>
>> Hi David
>>
>> I do not really understand what you are suggesting. I guess Alex was
>> talking about changes on files like for example
>>
>>
>> ./solr/contrib/morphlines-core/src/test-files/solr/minimr/conf/schema.xml
>> ./solr/contrib/uima/src/test-files/uima/solr/collection1/conf/schema.xml
>>
>> ./solr/contrib/velocity/src/test-files/velocity/solr/collection1/conf/schema.xml
>> ./solr/core/src/test-files/solr/configsets/minimal/conf/schema.xml
>> ./solr/example/example-DIH/solr/db/conf/schema.xml
>> ./solr/example/example-DIH/solr/solr/conf/schema.xml
>> ./solr/example/example-DIH/solr/tika/conf/schema.xml
>> ./solr/server/solr/configsets/basic_configs/conf/schema.xml
>> ./solr/server/solr/configsets/data_driven_schema_configs/conf/schema.xml
>> ./solr/solrj/src/test-files/solrj/solr/shared/conf/schema.xml
>>
>> I have found that one should check the following guide
>>
>> http://wiki.apache.org/solr/SchemaXml
>>
>> IIUC there is no DTD or XML Schema to validate these XML based
>> configurations, right?
>>
>> Can you explain once more your suggestion by maybe giving a specific
>> example?
>>
>> Thanks
>>
>> Michael
>>
>> Am 07.12.14 um 04:29 schrieb david.w.smiley@gmail.com:
>> > Hi Alex,
>> >
>> > There isn’t a way to say “just schema-related ones”. But, if you
>> > suspect
>> > the tests you want to run will have a string in the class name then you
>> > can
>> > run tests for classes matching a supplied regexp. For example:
>> >
>> > ant test -Dtestcase="*High*"
>> >
>> > And do that from within a specific module (say solr-core) to further
>> > scope
>> > the tests.
>> >
>> > ~ David Smiley
>> > Freelance Apache Lucene/Solr Search Consultant/Developer
>> > http://www.linkedin.com/in/davidwsmiley
>> >
>> > On Sat, Dec 6, 2014 at 2:45 PM, Alexandre Rafalovitch
>> > <ar...@gmail.com>
>> > wrote:
>> >
>> >> Hi,
>> >>
>> >> I want to do some minor cleanup in (multiple) schema.xml. What's the
>> >> minimum set of tests I need to run before I submit a patch?
>> >>
>> >> 'ant test' seems to be a heavy thing. Is there a way to say, just
>> >> schema-related ones?
>> >>
>> >> Regards,
>> >> Alex.
>> >> Personal: http://www.outerthoughts.com/ and @arafalov
>> >> Solr resources and newsletter: http://www.solr-start.com/ and
>> >> @solrstart
>> >> Solr popularizers community:
>> >> https://www.linkedin.com/groups?gid=6713853
>> >>
>> >> ---------------------------------------------------------------------
>> >> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>> >> For additional commands, e-mail: dev-help@lucene.apache.org
>> >>
>> >>
>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>> For additional commands, e-mail: dev-help@lucene.apache.org
>>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: Minimum test set for idempotent changes in schema.xml
Posted by "david.w.smiley@gmail.com" <da...@gmail.com>.
I think I misunderstood what Alex wanted. Now, I think he wants to know
which tests exercise the schemas/config that users see (e.g. the example
ones). I suggest running tests with “Example” in the name:
ant test -Dtestcase=“*Example*"
~ David Smiley
Freelance Apache Lucene/Solr Search Consultant/Developer
http://www.linkedin.com/in/davidwsmiley
On Sat, Dec 6, 2014 at 11:37 PM, Michael Wechner <mi...@wyona.com>
wrote:
> Hi David
>
> I do not really understand what you are suggesting. I guess Alex was
> talking about changes on files like for example
>
>
> ./solr/contrib/morphlines-core/src/test-files/solr/minimr/conf/schema.xml
> ./solr/contrib/uima/src/test-files/uima/solr/collection1/conf/schema.xml
>
> ./solr/contrib/velocity/src/test-files/velocity/solr/collection1/conf/schema.xml
> ./solr/core/src/test-files/solr/configsets/minimal/conf/schema.xml
> ./solr/example/example-DIH/solr/db/conf/schema.xml
> ./solr/example/example-DIH/solr/solr/conf/schema.xml
> ./solr/example/example-DIH/solr/tika/conf/schema.xml
> ./solr/server/solr/configsets/basic_configs/conf/schema.xml
> ./solr/server/solr/configsets/data_driven_schema_configs/conf/schema.xml
> ./solr/solrj/src/test-files/solrj/solr/shared/conf/schema.xml
>
> I have found that one should check the following guide
>
> http://wiki.apache.org/solr/SchemaXml
>
> IIUC there is no DTD or XML Schema to validate these XML based
> configurations, right?
>
> Can you explain once more your suggestion by maybe giving a specific
> example?
>
> Thanks
>
> Michael
>
> Am 07.12.14 um 04:29 schrieb david.w.smiley@gmail.com:
> > Hi Alex,
> >
> > There isn’t a way to say “just schema-related ones”. But, if you
> suspect
> > the tests you want to run will have a string in the class name then you
> can
> > run tests for classes matching a supplied regexp. For example:
> >
> > ant test -Dtestcase="*High*"
> >
> > And do that from within a specific module (say solr-core) to further
> scope
> > the tests.
> >
> > ~ David Smiley
> > Freelance Apache Lucene/Solr Search Consultant/Developer
> > http://www.linkedin.com/in/davidwsmiley
> >
> > On Sat, Dec 6, 2014 at 2:45 PM, Alexandre Rafalovitch <
> arafalov@gmail.com>
> > wrote:
> >
> >> Hi,
> >>
> >> I want to do some minor cleanup in (multiple) schema.xml. What's the
> >> minimum set of tests I need to run before I submit a patch?
> >>
> >> 'ant test' seems to be a heavy thing. Is there a way to say, just
> >> schema-related ones?
> >>
> >> Regards,
> >> Alex.
> >> Personal: http://www.outerthoughts.com/ and @arafalov
> >> Solr resources and newsletter: http://www.solr-start.com/ and
> @solrstart
> >> Solr popularizers community:
> https://www.linkedin.com/groups?gid=6713853
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> >> For additional commands, e-mail: dev-help@lucene.apache.org
> >>
> >>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
>
Re: Minimum test set for idempotent changes in schema.xml
Posted by Michael Wechner <mi...@wyona.com>.
Hi David
I do not really understand what you are suggesting. I guess Alex was
talking about changes on files like for example
./solr/contrib/morphlines-core/src/test-files/solr/minimr/conf/schema.xml
./solr/contrib/uima/src/test-files/uima/solr/collection1/conf/schema.xml
./solr/contrib/velocity/src/test-files/velocity/solr/collection1/conf/schema.xml
./solr/core/src/test-files/solr/configsets/minimal/conf/schema.xml
./solr/example/example-DIH/solr/db/conf/schema.xml
./solr/example/example-DIH/solr/solr/conf/schema.xml
./solr/example/example-DIH/solr/tika/conf/schema.xml
./solr/server/solr/configsets/basic_configs/conf/schema.xml
./solr/server/solr/configsets/data_driven_schema_configs/conf/schema.xml
./solr/solrj/src/test-files/solrj/solr/shared/conf/schema.xml
I have found that one should check the following guide
http://wiki.apache.org/solr/SchemaXml
IIUC there is no DTD or XML Schema to validate these XML based
configurations, right?
Can you explain once more your suggestion by maybe giving a specific
example?
Thanks
Michael
Am 07.12.14 um 04:29 schrieb david.w.smiley@gmail.com:
> Hi Alex,
>
> There isn’t a way to say “just schema-related ones”. But, if you suspect
> the tests you want to run will have a string in the class name then you can
> run tests for classes matching a supplied regexp. For example:
>
> ant test -Dtestcase="*High*"
>
> And do that from within a specific module (say solr-core) to further scope
> the tests.
>
> ~ David Smiley
> Freelance Apache Lucene/Solr Search Consultant/Developer
> http://www.linkedin.com/in/davidwsmiley
>
> On Sat, Dec 6, 2014 at 2:45 PM, Alexandre Rafalovitch <ar...@gmail.com>
> wrote:
>
>> Hi,
>>
>> I want to do some minor cleanup in (multiple) schema.xml. What's the
>> minimum set of tests I need to run before I submit a patch?
>>
>> 'ant test' seems to be a heavy thing. Is there a way to say, just
>> schema-related ones?
>>
>> Regards,
>> Alex.
>> Personal: http://www.outerthoughts.com/ and @arafalov
>> Solr resources and newsletter: http://www.solr-start.com/ and @solrstart
>> Solr popularizers community: https://www.linkedin.com/groups?gid=6713853
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>> For additional commands, e-mail: dev-help@lucene.apache.org
>>
>>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: Minimum test set for idempotent changes in schema.xml
Posted by "david.w.smiley@gmail.com" <da...@gmail.com>.
Hi Alex,
There isn’t a way to say “just schema-related ones”. But, if you suspect
the tests you want to run will have a string in the class name then you can
run tests for classes matching a supplied regexp. For example:
ant test -Dtestcase="*High*"
And do that from within a specific module (say solr-core) to further scope
the tests.
~ David Smiley
Freelance Apache Lucene/Solr Search Consultant/Developer
http://www.linkedin.com/in/davidwsmiley
On Sat, Dec 6, 2014 at 2:45 PM, Alexandre Rafalovitch <ar...@gmail.com>
wrote:
> Hi,
>
> I want to do some minor cleanup in (multiple) schema.xml. What's the
> minimum set of tests I need to run before I submit a patch?
>
> 'ant test' seems to be a heavy thing. Is there a way to say, just
> schema-related ones?
>
> Regards,
> Alex.
> Personal: http://www.outerthoughts.com/ and @arafalov
> Solr resources and newsletter: http://www.solr-start.com/ and @solrstart
> Solr popularizers community: https://www.linkedin.com/groups?gid=6713853
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
>