You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by richard zhou <yi...@gmail.com> on 2014/11/14 10:05:20 UTC
Review Request 28033: SQOOP-1730: httpcore and httpclient version has
not upgrade after hadoop upgraded
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28033/
-----------------------------------------------------------
Review request for Sqoop.
Repository: sqoop-sqoop2
Description
-------
It is a bug for Hadoop actually. So I exclude wrong version of httpcore and httpclient from hadoop-common.
Diffs
-----
pom.xml 9ff51d12620ce5c220a33e68819f9004c44a6d99
test/pom.xml 28a1e66f8a8ca989a805e454c0088e6e7405aab9
test/src/main/java/org/apache/sqoop/test/minicluster/TomcatSqoopMiniCluster.java 7504e766f2170e8a9038a17e82cc4a0ea07984f4
Diff: https://reviews.apache.org/r/28033/diff/
Testing
-------
Thanks,
richard zhou
Re: Review Request 28033: SQOOP-1730: httpcore and httpclient version
has not upgrade after hadoop upgraded
Posted by richard zhou <yi...@gmail.com>.
> On Nov. 14, 2014, 4:48 p.m., Abraham Elmahrek wrote:
> > Not sure I fully understand... Hadoop includes the wrong version of httpcore and httpclient? Or Sqoop has versions that conflict with httpcore and httpclient?
The version of httpcore and httpclient in Hadoop-common is wrong (4.1.2), while the version in Hadoop-auth is correct (4.2.5).
So if Hadoop-common is included, wrong version of httpcore and httpclient 4.1.2 is used.
We need to exclude the wrong version 4.1.2 in Hadoop-common, and include the correct version 4.2.5 in Hadoop-auth.
> On Nov. 14, 2014, 4:48 p.m., Abraham Elmahrek wrote:
> > test/src/main/java/org/apache/sqoop/test/minicluster/TomcatSqoopMiniCluster.java, lines 91-92
> > <https://reviews.apache.org/r/28033/diff/1/?file=763325#file763325line91>
> >
> > Are these necessary for the server? They seem oriented around the client?
These 2 jars are used in SqoopAuthenticationFilter.java. Actually the PseudoAuthenticationHandler uses these 2 jars.
PseudoAuthenticationHandler depends on httpcore and httpclient 4.2.5, while the version in Hadoop-common is 4.1.2, which is the root cause of this issue.
- richard
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28033/#review61447
-----------------------------------------------------------
On Nov. 14, 2014, 9:05 a.m., richard zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28033/
> -----------------------------------------------------------
>
> (Updated Nov. 14, 2014, 9:05 a.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> It is a bug for Hadoop actually. So I exclude wrong version of httpcore and httpclient from hadoop-common.
>
>
> Diffs
> -----
>
> pom.xml 9ff51d12620ce5c220a33e68819f9004c44a6d99
> test/pom.xml 28a1e66f8a8ca989a805e454c0088e6e7405aab9
> test/src/main/java/org/apache/sqoop/test/minicluster/TomcatSqoopMiniCluster.java 7504e766f2170e8a9038a17e82cc4a0ea07984f4
>
> Diff: https://reviews.apache.org/r/28033/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> richard zhou
>
>
Re: Review Request 28033: SQOOP-1730: httpcore and httpclient version
has not upgrade after hadoop upgraded
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28033/#review61447
-----------------------------------------------------------
Not sure I fully understand... Hadoop includes the wrong version of httpcore and httpclient? Or Sqoop has versions that conflict with httpcore and httpclient?
test/src/main/java/org/apache/sqoop/test/minicluster/TomcatSqoopMiniCluster.java
<https://reviews.apache.org/r/28033/#comment103027>
Are these necessary for the server? They seem oriented around the client?
- Abraham Elmahrek
On Nov. 14, 2014, 9:05 a.m., richard zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28033/
> -----------------------------------------------------------
>
> (Updated Nov. 14, 2014, 9:05 a.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> It is a bug for Hadoop actually. So I exclude wrong version of httpcore and httpclient from hadoop-common.
>
>
> Diffs
> -----
>
> pom.xml 9ff51d12620ce5c220a33e68819f9004c44a6d99
> test/pom.xml 28a1e66f8a8ca989a805e454c0088e6e7405aab9
> test/src/main/java/org/apache/sqoop/test/minicluster/TomcatSqoopMiniCluster.java 7504e766f2170e8a9038a17e82cc4a0ea07984f4
>
> Diff: https://reviews.apache.org/r/28033/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> richard zhou
>
>
Re: Review Request 28033: SQOOP-1730: httpcore and httpclient version
has not upgrade after hadoop upgraded
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28033/#review61649
-----------------------------------------------------------
Ship it!
Ship It!
- Abraham Elmahrek
On Nov. 14, 2014, 9:05 a.m., richard zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28033/
> -----------------------------------------------------------
>
> (Updated Nov. 14, 2014, 9:05 a.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> It is a bug for Hadoop actually. So I exclude wrong version of httpcore and httpclient from hadoop-common.
>
>
> Diffs
> -----
>
> pom.xml 9ff51d12620ce5c220a33e68819f9004c44a6d99
> test/pom.xml 28a1e66f8a8ca989a805e454c0088e6e7405aab9
> test/src/main/java/org/apache/sqoop/test/minicluster/TomcatSqoopMiniCluster.java 7504e766f2170e8a9038a17e82cc4a0ea07984f4
>
> Diff: https://reviews.apache.org/r/28033/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> richard zhou
>
>