[GitHub] [flink] StephanEwen commented on issue #10239: [Flink-11491][Test] Support all TPC-DS queries

[GitBox <gi...@apache.org>]

StephanEwen commented on issue #10239: [Flink-11491][Test] Support all TPC-DS queries
URL: https://github.com/apache/flink/pull/10239#issuecomment-555760075
 
 
   Thank you very much for this great effort. Having TPC-DS coverage tested and validates is a really cool achievement for Flink.
   
   I think we need to adjust a few things in this PR, though, unfortunately. Most importantly, we cannot check binaries into the code, that is a strict release rule in Apache: No binaries in the source. Binaries can only be built / downloaded during the build phase. So we either need to compile those binaries (which seems very complicated) or we need to fetch them from a trusted location during the test.
   
   License wise, I will check if the TPC license is compatible with the Apache License.
   We may need to change the header of the query template and answer files to Apache headers and put the TPC license notice into the NOTICE file. Let me check that, I will write an answer here soon.
   
   There is a big `v2.11.0rc2.tar.gz` file in the PR that should be removed. It seems redundant (contains the same files that are individually checked in as well).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services