You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/04/28 18:15:54 UTC

[GitHub] [beam] Akshay-Iyangar commented on a change in pull request #11341: [BEAM-9720] Add Aws Http client configurations capability.

Akshay-Iyangar commented on a change in pull request #11341:
URL: https://github.com/apache/beam/pull/11341#discussion_r416823997



##########
File path: sdks/java/io/amazon-web-services/src/main/java/org/apache/beam/sdk/io/aws/options/AwsOptions.java
##########
@@ -103,6 +103,34 @@ public AWSCredentialsProvider create(PipelineOptions options) {
 
   void setClientConfiguration(ClientConfiguration clientConfiguration);

Review comment:
       yaa they could be gotten rid of but I wasn't sure if it was a breaking change for people already using it. If you think it's ok to have only one i will change it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org