[jira] Commented: (TUSCANY-1953) Feed-aggregator sample does not stop properly

["Jean-Sebastien Delfino (JIRA)" <tu...@ws.apache.org>]

    [ https://issues.apache.org/jira/browse/TUSCANY-1953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12557175#action_12557175 ] 

Jean-Sebastien Delfino commented on TUSCANY-1953:
-------------------------------------------------

Now fixed in trunk but not merged in the 1.1 branch.

I think we have the following options:

a) Defer the inclusion of the fix to release 1.2 as it's not a blocker. People who want to embed Tomcat can call System.exit() to exit their program.

b) Test all the samples that embed Tomcat with the fix, on a real 1.1 distribution build and using Ant, after having fixed TUSCANY-1954 which is much more serious.

c) As part of the fix to TUSCANY-1954 pick Jetty as the default embedded server, lowering the severity of this problem, and defer the inclusion of the fix to release 1.2.

I recommend option (a) for now.


> Feed-aggregator sample does not stop properly
> ---------------------------------------------
>
>                 Key: TUSCANY-1953
>                 URL: https://issues.apache.org/jira/browse/TUSCANY-1953
>             Project: Tuscany
>          Issue Type: Bug
>          Components: Java SCA Tomcat Integration
>    Affects Versions: Java-SCA-1.1
>            Reporter: Jean-Sebastien Delfino
>            Assignee: Jean-Sebastien Delfino
>             Fix For: Java-SCA-1.1
>
>
> To reproduce the problem, start the feed-aggregator sample using ant run, point your Web browser to http://localhost:8083/atomAggregator, then press enter in the window where you started ant run. The program should exit but doesn't.
> The problem is that ThreadPoolWorkManager used by the TomcatServer to handle incoming HTTP requests and read from the input TCP/IP socket does not create Daemon threads. Tomcat leaves a thread alive blocked on the input socket and that live thread prevents the JVM to exit.
> This problem is not specific to the feed-aggregator sample, it happens with any Tuscany application using our embedded TomcatServer. The problem does not occur with Jetty.
> I am fixing it by marking the threads as Daemon threads in ThreadWorkPoolManager.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org