[GitHub] HeartSaVioR edited a comment on issue #23854: [SPARK-22000][SQL] Use String.valueOf in generated code to assign value to String type of field in Java Bean Encoder

[GitBox <gi...@apache.org>]

HeartSaVioR edited a comment on issue #23854: [SPARK-22000][SQL] Use String.valueOf in generated code to assign value to String type of field in Java Bean Encoder
URL: https://github.com/apache/spark/pull/23854#issuecomment-466197634
 
 
   > Before your change, which field has the wrong generated code -- what type is it?
   
   The field/column was `ref`: the type from `ref` column in Dataset was `IntegerType` and the type of `ref` field in Java class was `String`.
   
   To be honest I have no idea this is intended to support implicit type conversions when deserializing (more clearly, why it doesn't check type compatibility), but any types to String would sound convenient, and not much weird. Without knowing history/intention I guess I can't explain more.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org