[GitHub] [flink] fapaul commented on a change in pull request #17519: [FLINK-24368][testutils] Print logs JobManager and TaskManager on STDOUT in Flink container for redirecting to log4j in tests

[GitBox <gi...@apache.org>]

fapaul commented on a change in pull request #17519:
URL: https://github.com/apache/flink/pull/17519#discussion_r732578188



##########
File path: flink-end-to-end-tests/flink-end-to-end-tests-common/src/main/java/org/apache/flink/tests/util/flink/FlinkContainer.java
##########
@@ -385,6 +385,17 @@ public FlinkContainer build() {
 
         private ImageFromDockerfile buildConfiguredImage(
                 Path workersFile, Path configurationFile, String baseImage) {
+            // Build cluster startup command
+            StringBuilder commandBuilder = new StringBuilder();

Review comment:
       Does the old log collection mechanism still work https://github.com/apache/flink/blob/3b693fd284dec0633e572d6e0428bc1153bc0ed9/flink-end-to-end-tests/flink-end-to-end-tests-common/src/main/java/org/apache/flink/tests/util/flink/FlinkContainer.java#L128?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org