You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by el...@apache.org on 2020/03/12 14:54:29 UTC
[maven-shared-utils] branch master updated: [MSHARED-860]
deprecated Windows 9X CommandShell (#20)
This is an automated email from the ASF dual-hosted git repository.
elharo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven-shared-utils.git
The following commit(s) were added to refs/heads/master by this push:
new cb448b9 [MSHARED-860] deprecated Windows 9X CommandShell (#20)
cb448b9 is described below
commit cb448b90918a5e894c38b86d00d402638f195502
Author: Elliotte Rusty Harold <el...@users.noreply.github.com>
AuthorDate: Thu Mar 12 10:54:24 2020 -0400
[MSHARED-860] deprecated Windows 9X CommandShell (#20)
* deprecated Windows 9X CommandShell
* correct JavaDoc
---
.../maven/shared/utils/cli/shell/CmdShell.java | 4 +--
.../maven/shared/utils/cli/shell/CommandShell.java | 5 ++--
.../apache/maven/shared/utils/cli/shell/Shell.java | 32 +++++++++++-----------
3 files changed, 19 insertions(+), 22 deletions(-)
diff --git a/src/main/java/org/apache/maven/shared/utils/cli/shell/CmdShell.java b/src/main/java/org/apache/maven/shared/utils/cli/shell/CmdShell.java
index 7c27ac1..04aa6de 100644
--- a/src/main/java/org/apache/maven/shared/utils/cli/shell/CmdShell.java
+++ b/src/main/java/org/apache/maven/shared/utils/cli/shell/CmdShell.java
@@ -23,9 +23,7 @@ import java.util.Arrays;
import java.util.List;
/**
- * <p>
- * Implementation to call the CMD Shell present on Windows NT, 2000 and XP
- * </p>
+ * Implementation to call the CMD Shell present on Windows NT, 2000, XP, 7, 8, and 10.
*
* @author <a href="mailto:carlos@apache.org">Carlos Sanchez</a>
*
diff --git a/src/main/java/org/apache/maven/shared/utils/cli/shell/CommandShell.java b/src/main/java/org/apache/maven/shared/utils/cli/shell/CommandShell.java
index dcee046..ba85633 100644
--- a/src/main/java/org/apache/maven/shared/utils/cli/shell/CommandShell.java
+++ b/src/main/java/org/apache/maven/shared/utils/cli/shell/CommandShell.java
@@ -21,13 +21,12 @@ package org.apache.maven.shared.utils.cli.shell;
/**
- * <p>
* Implementation to call the Command.com Shell present on Windows 95, 98 and Me
- * </p>
*
* @author <a href="mailto:carlos@apache.org">Carlos Sanchez</a>
- *
+ * @deprecated Windows ME is long dead. Update to Windows 10 and use {@link CmdShell}.
*/
+@Deprecated
public class CommandShell
extends Shell
{
diff --git a/src/main/java/org/apache/maven/shared/utils/cli/shell/Shell.java b/src/main/java/org/apache/maven/shared/utils/cli/shell/Shell.java
index 5809610..bec555e 100644
--- a/src/main/java/org/apache/maven/shared/utils/cli/shell/Shell.java
+++ b/src/main/java/org/apache/maven/shared/utils/cli/shell/Shell.java
@@ -27,14 +27,13 @@ import java.util.List;
import org.apache.maven.shared.utils.StringUtils;
/**
- * <p>
* Class that abstracts the Shell functionality,
- * with subclases for shells that behave particularly, like
+ * with subclasses for shells that behave particularly, like<p>
+ *
* <ul>
* <li><code>command.com</code></li>
* <li><code>cmd.exe</code></li>
* </ul>
- * </p>
*
* @author <a href="mailto:carlos@apache.org">Carlos Sanchez</a>
*
@@ -65,9 +64,9 @@ public class Shell
private char exeQuoteDelimiter = '\"';
/**
- * Set the command to execute the shell (eg. COMMAND.COM, /bin/bash,...)
+ * Set the command to execute the shell (e.g. COMMAND.COM, /bin/bash,...).
*
- * @param shellCommand The command
+ * @param shellCommand the command
*/
void setShellCommand( String shellCommand )
{
@@ -75,9 +74,9 @@ public class Shell
}
/**
- * Get the command to execute the shell
+ * Get the command to execute the shell.
*
- * @return The command
+ * @return the command
*/
String getShellCommand()
{
@@ -86,7 +85,7 @@ public class Shell
/**
* Set the shell arguments when calling a command line (not the executable arguments)
- * (eg. /X /C for CMD.EXE)
+ * (e.g. /X /C for CMD.EXE).
*
* @param shellArgs the arguments to the shell
*/
@@ -99,7 +98,7 @@ public class Shell
/**
* Get the shell arguments
*
- * @return The arguments
+ * @return the arguments
*/
String[] getShellArgs()
{
@@ -118,7 +117,7 @@ public class Shell
*
* @param executableParameter executable that the shell has to call
* @param argumentsParameter arguments for the executable, not the shell
- * @return List with one String object with executable and arguments quoted as needed
+ * @return list with one String object with executable and arguments quoted as needed
*/
List<String> getCommandLine( String executableParameter, String... argumentsParameter )
{
@@ -126,9 +125,9 @@ public class Shell
}
/**
- * @param executableParameter Executable.
- * @param argumentsParameter The arguments for the executable.
- * @return The list on command line.
+ * @param executableParameter Executable
+ * @param argumentsParameter the arguments for the executable
+ * @return the list on command line
*/
List<String> getRawCommandLine( String executableParameter, String... argumentsParameter )
{
@@ -211,7 +210,7 @@ public class Shell
}
/**
- * @return false in all cases.
+ * @return false in all cases
*/
protected boolean isDoubleQuotedArgumentEscaped()
{
@@ -354,7 +353,8 @@ public class Shell
/**
* Sets execution directory.
- * @param workingDirectory The working directory.
+ *
+ * @param workingDirectory the working directory
*/
public void setWorkingDirectory( File workingDirectory )
{
@@ -365,7 +365,7 @@ public class Shell
}
/**
- * @return The working directory.
+ * @return the working directory
*/
public File getWorkingDirectory()
{