You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Dominic Hamon <dh...@twopensource.com> on 2014/02/20 21:10:23 UTC
Review Request 18321: Replaced static non-PODs with pointers and removed
dead code.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18321/
-----------------------------------------------------------
Review request for mesos, Ben Mahler and Vinod Kone.
Summary (updated)
-----------------
Replaced static non-PODs with pointers and removed dead code.
Bugs: MESOS-1023
https://issues.apache.org/jira/browse/MESOS-1023
Repository: mesos-git
Description (updated)
-------
See summary
Diffs (updated)
-----
3rdparty/libprocess/include/process/clock.hpp 82ae3c6f4928388d041803068a2a4362ddc3bcd5
3rdparty/libprocess/include/process/help.hpp 8d50419d9e794c64aecc5c8a906d3b1f6a288fac
3rdparty/libprocess/include/process/time.hpp 26cec3dadca8aa5b33964c5072be4671aa42a259
3rdparty/libprocess/include/process/timeseries.hpp b368b9bb9cd63fb331b2c137dcde759d0ee59ee6
3rdparty/libprocess/src/process.cpp 69898b7fff36fa5de048782ccbba63ce4a35f7c8
3rdparty/libprocess/src/synchronized.cpp 79b0849accd41d291fd083601cea7d4fe92782cf
3rdparty/libprocess/src/timer.hpp 443b5a0f56f32193f90c11b7f0da76eabd9ecfde
3rdparty/libprocess/src/timer.cpp aa1ee1bad51dbff7d81e49f242156e8ab25e6944
Diff: https://reviews.apache.org/r/18321/diff/
Testing
-------
Thanks,
Dominic Hamon
Re: Review Request 18321: Replaced static non-PODs with pointers and removed
dead code.
Posted by Dominic Hamon <dh...@twopensource.com>.
> On Feb. 20, 2014, 2:27 p.m., Ben Mahler wrote:
> > 3rdparty/libprocess/include/process/help.hpp, lines 37-38
> > <https://reviews.apache.org/r/18321/diff/1/?file=499270#file499270line37>
> >
> > Rather than return a pointer, seems like the responsibility of proper static storage should lie in the caller, no? I think HELP should be agnostic to how it is being called.
>
> Dominic Hamon wrote:
> true, but then all the callsites will have to remember to write:
>
> const std::string* THIS_HELP = new std::string(HELP(....));
>
> given 'HELP' looks like a macro that just does the write thing, it can help out by returning a heap-allocated string pointer.
>
> Ben Mahler wrote:
> But I'm wondering whether we can change the current style of HELP usage to avoid this.
>
> We only need to compute the HELP string once during initialize(), for route()ing purposes. So, for example, a static function might be a good alternative for callers:
>
> System
> {
> initialize()
> {
> route("/stats.json", STATS_HELP(), &System::stats);
> }
>
> // This could live only in the .cpp file outside the System class if we implement initialize() in the .cpp.
> static std::string STATS_HELP()
> }
>
> What do you think?
That seems reasonable. It puts the onus on the callsite to use HELP responsibly and doesn't require any changes to process.
- Dominic
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18321/#review35091
-----------------------------------------------------------
On Feb. 20, 2014, 3:19 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18321/
> -----------------------------------------------------------
>
> (Updated Feb. 20, 2014, 3:19 p.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Bugs: MESOS-1023
> https://issues.apache.org/jira/browse/MESOS-1023
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/clock.hpp 82ae3c6f4928388d041803068a2a4362ddc3bcd5
> 3rdparty/libprocess/include/process/help.hpp 8d50419d9e794c64aecc5c8a906d3b1f6a288fac
> 3rdparty/libprocess/include/process/time.hpp 26cec3dadca8aa5b33964c5072be4671aa42a259
> 3rdparty/libprocess/include/process/timeseries.hpp b368b9bb9cd63fb331b2c137dcde759d0ee59ee6
> 3rdparty/libprocess/src/process.cpp 69898b7fff36fa5de048782ccbba63ce4a35f7c8
> 3rdparty/libprocess/src/synchronized.cpp 79b0849accd41d291fd083601cea7d4fe92782cf
> 3rdparty/libprocess/src/timer.hpp 443b5a0f56f32193f90c11b7f0da76eabd9ecfde
> 3rdparty/libprocess/src/timer.cpp aa1ee1bad51dbff7d81e49f242156e8ab25e6944
>
> Diff: https://reviews.apache.org/r/18321/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 18321: Replaced static non-PODs with pointers and removed
dead code.
Posted by Ben Mahler <be...@gmail.com>.
> On Feb. 20, 2014, 10:27 p.m., Ben Mahler wrote:
> > 3rdparty/libprocess/include/process/help.hpp, lines 37-38
> > <https://reviews.apache.org/r/18321/diff/1/?file=499270#file499270line37>
> >
> > Rather than return a pointer, seems like the responsibility of proper static storage should lie in the caller, no? I think HELP should be agnostic to how it is being called.
>
> Dominic Hamon wrote:
> true, but then all the callsites will have to remember to write:
>
> const std::string* THIS_HELP = new std::string(HELP(....));
>
> given 'HELP' looks like a macro that just does the write thing, it can help out by returning a heap-allocated string pointer.
But I'm wondering whether we can change the current style of HELP usage to avoid this.
We only need to compute the HELP string once during initialize(), for route()ing purposes. So, for example, a static function might be a good alternative for callers:
System
{
initialize()
{
route("/stats.json", STATS_HELP(), &System::stats);
}
// This could live only in the .cpp file outside the System class if we implement initialize() in the .cpp.
static std::string STATS_HELP()
}
What do you think?
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18321/#review35091
-----------------------------------------------------------
On Feb. 20, 2014, 11:19 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18321/
> -----------------------------------------------------------
>
> (Updated Feb. 20, 2014, 11:19 p.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Bugs: MESOS-1023
> https://issues.apache.org/jira/browse/MESOS-1023
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/clock.hpp 82ae3c6f4928388d041803068a2a4362ddc3bcd5
> 3rdparty/libprocess/include/process/help.hpp 8d50419d9e794c64aecc5c8a906d3b1f6a288fac
> 3rdparty/libprocess/include/process/time.hpp 26cec3dadca8aa5b33964c5072be4671aa42a259
> 3rdparty/libprocess/include/process/timeseries.hpp b368b9bb9cd63fb331b2c137dcde759d0ee59ee6
> 3rdparty/libprocess/src/process.cpp 69898b7fff36fa5de048782ccbba63ce4a35f7c8
> 3rdparty/libprocess/src/synchronized.cpp 79b0849accd41d291fd083601cea7d4fe92782cf
> 3rdparty/libprocess/src/timer.hpp 443b5a0f56f32193f90c11b7f0da76eabd9ecfde
> 3rdparty/libprocess/src/timer.cpp aa1ee1bad51dbff7d81e49f242156e8ab25e6944
>
> Diff: https://reviews.apache.org/r/18321/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 18321: Replaced static non-PODs with pointers and removed
dead code.
Posted by Dominic Hamon <dh...@twopensource.com>.
> On Feb. 20, 2014, 2:27 p.m., Ben Mahler wrote:
> > 3rdparty/libprocess/include/process/clock.hpp, lines 14-28
> > <https://reviews.apache.org/r/18321/diff/1/?file=499269#file499269line14>
> >
> > Why this change? If we're changing it to a namespace, then s/Clock/clock/ and kill the semicolon on the closing brace.
i'll roll this back for now. i don't want to update all the callsites in this change.
> On Feb. 20, 2014, 2:27 p.m., Ben Mahler wrote:
> > 3rdparty/libprocess/include/process/help.hpp, lines 37-38
> > <https://reviews.apache.org/r/18321/diff/1/?file=499270#file499270line37>
> >
> > Rather than return a pointer, seems like the responsibility of proper static storage should lie in the caller, no? I think HELP should be agnostic to how it is being called.
true, but then all the callsites will have to remember to write:
const std::string* THIS_HELP = new std::string(HELP(....));
given 'HELP' looks like a macro that just does the write thing, it can help out by returning a heap-allocated string pointer.
- Dominic
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18321/#review35091
-----------------------------------------------------------
On Feb. 20, 2014, 12:10 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18321/
> -----------------------------------------------------------
>
> (Updated Feb. 20, 2014, 12:10 p.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Bugs: MESOS-1023
> https://issues.apache.org/jira/browse/MESOS-1023
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/clock.hpp 82ae3c6f4928388d041803068a2a4362ddc3bcd5
> 3rdparty/libprocess/include/process/help.hpp 8d50419d9e794c64aecc5c8a906d3b1f6a288fac
> 3rdparty/libprocess/include/process/time.hpp 26cec3dadca8aa5b33964c5072be4671aa42a259
> 3rdparty/libprocess/include/process/timeseries.hpp b368b9bb9cd63fb331b2c137dcde759d0ee59ee6
> 3rdparty/libprocess/src/process.cpp 69898b7fff36fa5de048782ccbba63ce4a35f7c8
> 3rdparty/libprocess/src/synchronized.cpp 79b0849accd41d291fd083601cea7d4fe92782cf
> 3rdparty/libprocess/src/timer.hpp 443b5a0f56f32193f90c11b7f0da76eabd9ecfde
> 3rdparty/libprocess/src/timer.cpp aa1ee1bad51dbff7d81e49f242156e8ab25e6944
>
> Diff: https://reviews.apache.org/r/18321/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 18321: Replaced static non-PODs with pointers and removed
dead code.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18321/#review35091
-----------------------------------------------------------
3rdparty/libprocess/include/process/clock.hpp
<https://reviews.apache.org/r/18321/#comment65492>
Why this change? If we're changing it to a namespace, then s/Clock/clock/ and kill the semicolon on the closing brace.
3rdparty/libprocess/include/process/help.hpp
<https://reviews.apache.org/r/18321/#comment65491>
Rather than return a pointer, seems like the responsibility of proper static storage should lie in the caller, no? I think HELP should be agnostic to how it is being called.
3rdparty/libprocess/src/process.cpp
<https://reviews.apache.org/r/18321/#comment65490>
How about doing what we did for Duration::min() / Duration::max() so we can kill the static constants altogether?
- Ben Mahler
On Feb. 20, 2014, 8:10 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18321/
> -----------------------------------------------------------
>
> (Updated Feb. 20, 2014, 8:10 p.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Bugs: MESOS-1023
> https://issues.apache.org/jira/browse/MESOS-1023
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/clock.hpp 82ae3c6f4928388d041803068a2a4362ddc3bcd5
> 3rdparty/libprocess/include/process/help.hpp 8d50419d9e794c64aecc5c8a906d3b1f6a288fac
> 3rdparty/libprocess/include/process/time.hpp 26cec3dadca8aa5b33964c5072be4671aa42a259
> 3rdparty/libprocess/include/process/timeseries.hpp b368b9bb9cd63fb331b2c137dcde759d0ee59ee6
> 3rdparty/libprocess/src/process.cpp 69898b7fff36fa5de048782ccbba63ce4a35f7c8
> 3rdparty/libprocess/src/synchronized.cpp 79b0849accd41d291fd083601cea7d4fe92782cf
> 3rdparty/libprocess/src/timer.hpp 443b5a0f56f32193f90c11b7f0da76eabd9ecfde
> 3rdparty/libprocess/src/timer.cpp aa1ee1bad51dbff7d81e49f242156e8ab25e6944
>
> Diff: https://reviews.apache.org/r/18321/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 18321: Replaced static non-PODs with pointers and removed
dead code.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18321/#review35105
-----------------------------------------------------------
3rdparty/libprocess/include/process/help.hpp
<https://reviews.apache.org/r/18321/#comment65511>
s/write/right/
- Dominic Hamon
On Feb. 20, 2014, 3:19 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18321/
> -----------------------------------------------------------
>
> (Updated Feb. 20, 2014, 3:19 p.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Bugs: MESOS-1023
> https://issues.apache.org/jira/browse/MESOS-1023
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/clock.hpp 82ae3c6f4928388d041803068a2a4362ddc3bcd5
> 3rdparty/libprocess/include/process/help.hpp 8d50419d9e794c64aecc5c8a906d3b1f6a288fac
> 3rdparty/libprocess/include/process/time.hpp 26cec3dadca8aa5b33964c5072be4671aa42a259
> 3rdparty/libprocess/include/process/timeseries.hpp b368b9bb9cd63fb331b2c137dcde759d0ee59ee6
> 3rdparty/libprocess/src/process.cpp 69898b7fff36fa5de048782ccbba63ce4a35f7c8
> 3rdparty/libprocess/src/synchronized.cpp 79b0849accd41d291fd083601cea7d4fe92782cf
> 3rdparty/libprocess/src/timer.hpp 443b5a0f56f32193f90c11b7f0da76eabd9ecfde
> 3rdparty/libprocess/src/timer.cpp aa1ee1bad51dbff7d81e49f242156e8ab25e6944
>
> Diff: https://reviews.apache.org/r/18321/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 18321: Replaced static non-PODs with pointers and removed
dead code.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18321/#review35205
-----------------------------------------------------------
3rdparty/libprocess/src/process.cpp
<https://reviews.apache.org/r/18321/#comment65657>
Full sentence please :)
- Ben Mahler
On Feb. 20, 2014, 11:19 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18321/
> -----------------------------------------------------------
>
> (Updated Feb. 20, 2014, 11:19 p.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Bugs: MESOS-1023
> https://issues.apache.org/jira/browse/MESOS-1023
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/clock.hpp 82ae3c6f4928388d041803068a2a4362ddc3bcd5
> 3rdparty/libprocess/include/process/help.hpp 8d50419d9e794c64aecc5c8a906d3b1f6a288fac
> 3rdparty/libprocess/include/process/time.hpp 26cec3dadca8aa5b33964c5072be4671aa42a259
> 3rdparty/libprocess/include/process/timeseries.hpp b368b9bb9cd63fb331b2c137dcde759d0ee59ee6
> 3rdparty/libprocess/src/process.cpp 69898b7fff36fa5de048782ccbba63ce4a35f7c8
> 3rdparty/libprocess/src/synchronized.cpp 79b0849accd41d291fd083601cea7d4fe92782cf
> 3rdparty/libprocess/src/timer.hpp 443b5a0f56f32193f90c11b7f0da76eabd9ecfde
> 3rdparty/libprocess/src/timer.cpp aa1ee1bad51dbff7d81e49f242156e8ab25e6944
>
> Diff: https://reviews.apache.org/r/18321/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 18321: Replaced static non-PODs with pointers and removed
dead code.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18321/#review35219
-----------------------------------------------------------
Ship it!
Ship It!
- Ben Mahler
On Feb. 22, 2014, 12:21 a.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18321/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2014, 12:21 a.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Bugs: MESOS-1023
> https://issues.apache.org/jira/browse/MESOS-1023
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/clock.hpp 82ae3c6f4928388d041803068a2a4362ddc3bcd5
> 3rdparty/libprocess/include/process/logging.hpp f4fb6196c875d2eb6dab9f4514b98936517ff176
> 3rdparty/libprocess/include/process/time.hpp 26cec3dadca8aa5b33964c5072be4671aa42a259
> 3rdparty/libprocess/include/process/timeseries.hpp b368b9bb9cd63fb331b2c137dcde759d0ee59ee6
> 3rdparty/libprocess/src/process.cpp 69898b7fff36fa5de048782ccbba63ce4a35f7c8
> 3rdparty/libprocess/src/synchronized.cpp 79b0849accd41d291fd083601cea7d4fe92782cf
> 3rdparty/libprocess/src/timer.hpp 443b5a0f56f32193f90c11b7f0da76eabd9ecfde
> 3rdparty/libprocess/src/timer.cpp aa1ee1bad51dbff7d81e49f242156e8ab25e6944
>
> Diff: https://reviews.apache.org/r/18321/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 18321: Replaced static non-PODs with pointers and removed
dead code.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18321/
-----------------------------------------------------------
(Updated Feb. 21, 2014, 4:21 p.m.)
Review request for mesos, Ben Mahler and Vinod Kone.
Bugs: MESOS-1023
https://issues.apache.org/jira/browse/MESOS-1023
Repository: mesos-git
Description
-------
See summary
Diffs (updated)
-----
3rdparty/libprocess/include/process/clock.hpp 82ae3c6f4928388d041803068a2a4362ddc3bcd5
3rdparty/libprocess/include/process/logging.hpp f4fb6196c875d2eb6dab9f4514b98936517ff176
3rdparty/libprocess/include/process/time.hpp 26cec3dadca8aa5b33964c5072be4671aa42a259
3rdparty/libprocess/include/process/timeseries.hpp b368b9bb9cd63fb331b2c137dcde759d0ee59ee6
3rdparty/libprocess/src/process.cpp 69898b7fff36fa5de048782ccbba63ce4a35f7c8
3rdparty/libprocess/src/synchronized.cpp 79b0849accd41d291fd083601cea7d4fe92782cf
3rdparty/libprocess/src/timer.hpp 443b5a0f56f32193f90c11b7f0da76eabd9ecfde
3rdparty/libprocess/src/timer.cpp aa1ee1bad51dbff7d81e49f242156e8ab25e6944
Diff: https://reviews.apache.org/r/18321/diff/
Testing
-------
Thanks,
Dominic Hamon
Re: Review Request 18321: Replaced static non-PODs with pointers and removed
dead code.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18321/
-----------------------------------------------------------
(Updated Feb. 21, 2014, 4:04 p.m.)
Review request for mesos, Ben Mahler and Vinod Kone.
Bugs: MESOS-1023
https://issues.apache.org/jira/browse/MESOS-1023
Repository: mesos-git
Description
-------
See summary
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp 778398af0e166709a777d770b7fddda309a60add
3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp 267b5f95958e51a003657cec6689a81f2b7763a7
3rdparty/libprocess/include/process/clock.hpp 82ae3c6f4928388d041803068a2a4362ddc3bcd5
3rdparty/libprocess/include/process/logging.hpp f4fb6196c875d2eb6dab9f4514b98936517ff176
3rdparty/libprocess/include/process/time.hpp 26cec3dadca8aa5b33964c5072be4671aa42a259
3rdparty/libprocess/include/process/timeseries.hpp b368b9bb9cd63fb331b2c137dcde759d0ee59ee6
3rdparty/libprocess/src/process.cpp 69898b7fff36fa5de048782ccbba63ce4a35f7c8
3rdparty/libprocess/src/synchronized.cpp 79b0849accd41d291fd083601cea7d4fe92782cf
3rdparty/libprocess/src/timer.hpp 443b5a0f56f32193f90c11b7f0da76eabd9ecfde
3rdparty/libprocess/src/timer.cpp aa1ee1bad51dbff7d81e49f242156e8ab25e6944
docs/mesos-presentations.md 587c5af179c45dcb6184cb128b1dc6aa1c9569df
src/Makefile.am f1ceab30902103e0ec8faa742bf5fa9346952394
src/local/local.cpp e31c19c1bd0bc527275b818a8ce2bc1d54d8cb89
src/master/main.cpp 723d534726175287b9ca3bffed894f77433183f4
src/master/master.hpp 768dc3d165510d9e65e4b44075256b2805fde18c
src/master/master.cpp de40884f873656cf91566ef49736cb8dda1300d8
src/master/registrar.hpp 20734afc69055197e9ab90d42253c56e4af4b97c
src/master/registrar.cpp 470a40511cf1ac9a379d76a76453df89101d7489
src/master/registry.proto b58cae532764036748eaabd95fcccc07188a1397
src/master/repairer.hpp d5c6b8494993f72012d2aa562e708f78b2fad678
src/master/repairer.cpp 151b4ed7ac0b8dacd175b97d372c1f867cd280f6
src/tests/cluster.hpp d1bf680ed3f6a0fb16af85a21409d653d44522ca
src/tests/registrar_tests.cpp 3bf42bd77a10470a2afc6fd8e1da30d6134e792c
Diff: https://reviews.apache.org/r/18321/diff/
Testing
-------
Thanks,
Dominic Hamon
Re: Review Request 18321: Replaced static non-PODs with pointers and removed
dead code.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18321/
-----------------------------------------------------------
(Updated Feb. 20, 2014, 3:19 p.m.)
Review request for mesos, Ben Mahler and Vinod Kone.
Bugs: MESOS-1023
https://issues.apache.org/jira/browse/MESOS-1023
Repository: mesos-git
Description
-------
See summary
Diffs (updated)
-----
3rdparty/libprocess/include/process/clock.hpp 82ae3c6f4928388d041803068a2a4362ddc3bcd5
3rdparty/libprocess/include/process/help.hpp 8d50419d9e794c64aecc5c8a906d3b1f6a288fac
3rdparty/libprocess/include/process/time.hpp 26cec3dadca8aa5b33964c5072be4671aa42a259
3rdparty/libprocess/include/process/timeseries.hpp b368b9bb9cd63fb331b2c137dcde759d0ee59ee6
3rdparty/libprocess/src/process.cpp 69898b7fff36fa5de048782ccbba63ce4a35f7c8
3rdparty/libprocess/src/synchronized.cpp 79b0849accd41d291fd083601cea7d4fe92782cf
3rdparty/libprocess/src/timer.hpp 443b5a0f56f32193f90c11b7f0da76eabd9ecfde
3rdparty/libprocess/src/timer.cpp aa1ee1bad51dbff7d81e49f242156e8ab25e6944
Diff: https://reviews.apache.org/r/18321/diff/
Testing
-------
Thanks,
Dominic Hamon