You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/03/31 20:32:32 UTC

[GitHub] [kafka] ewencp commented on a change in pull request #10452: KAFKA-12593: Fix header in streams-scala

ewencp commented on a change in pull request #10452:
URL: https://github.com/apache/kafka/pull/10452#discussion_r605200916



##########
File path: NOTICE
##########
@@ -10,3 +10,7 @@ License. The source code of jersey can be found at https://github.com/jersey/jer
 This distribution has a binary test dependency on jqwik, which is available under
 the Eclipse Public License 2.0. The source code can be found at
 https://github.com/jlink/jqwik.
+
+The streams-scala (streams/streams-scala) module was donated by Lightbend and the original code was copyrighted by them:
+Copyright (C) 2018 Lightbend Inc. <https://www.lightbend.com>
+Copyright (C) 2017-2018 Alexis Seigneurin.

Review comment:
       I think it's better to preserve attribution. Aside from what's required from Apache2 license, what goes into NOTICE is up to us so I think this is a fine location for this.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org