You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2018/11/02 05:14:37 UTC
[kudu-CR] delta applier: support for diff scan style iteration
Hello Mike Percy, David Ribeiro Alves, Grant Henke, Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/11860
to review the following change.
Change subject: delta_applier: support for diff scan style iteration
......................................................................
delta_applier: support for diff scan style iteration
This patch incorporates all of the previous work to provide diff scan
support for an entire DiskRowSet. There's a new "fuzzy" test in
diskrowset-test that exercises this functionality.
Change-Id: I895350a3c7728df88a87a36b904ffdea4f3f6b7a
---
M src/kudu/tablet/delta_applier.cc
M src/kudu/tablet/delta_applier.h
M src/kudu/tablet/delta_tracker.cc
M src/kudu/tablet/delta_tracker.h
M src/kudu/tablet/diskrowset-test.cc
5 files changed, 287 insertions(+), 9 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/60/11860/1
--
To view, visit http://gerrit.cloudera.org:8080/11860
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I895350a3c7728df88a87a36b904ffdea4f3f6b7a
Gerrit-Change-Number: 11860
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] (05/05) delta applier: support for diff scan style iteration
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Hello Mike Percy, David Ribeiro Alves, Kudu Jenkins, Grant Henke, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11860
to look at the new patch set (#2).
Change subject: (05/05) delta_applier: support for diff scan style iteration
......................................................................
(05/05) delta_applier: support for diff scan style iteration
This patch incorporates all of the previous work to provide diff scan
support for an entire DiskRowSet. There's a new "fuzzy" test in
diskrowset-test that exercises this functionality.
Change-Id: I895350a3c7728df88a87a36b904ffdea4f3f6b7a
---
M src/kudu/tablet/delta_applier.cc
M src/kudu/tablet/delta_applier.h
M src/kudu/tablet/delta_tracker.cc
M src/kudu/tablet/delta_tracker.h
M src/kudu/tablet/diskrowset-test.cc
5 files changed, 287 insertions(+), 9 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/60/11860/2
--
To view, visit http://gerrit.cloudera.org:8080/11860
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I895350a3c7728df88a87a36b904ffdea4f3f6b7a
Gerrit-Change-Number: 11860
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] (05/05) delta applier: support for diff scan style iteration
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11860 )
Change subject: (05/05) delta_applier: support for diff scan style iteration
......................................................................
Patch Set 4: Verified+1
Overriding Jenkins, KUDU-2599 plus another unrelated flake.
--
To view, visit http://gerrit.cloudera.org:8080/11860
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I895350a3c7728df88a87a36b904ffdea4f3f6b7a
Gerrit-Change-Number: 11860
Gerrit-PatchSet: 4
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 09 Nov 2018 18:59:53 +0000
Gerrit-HasComments: No
[kudu-CR] (05/05) delta applier: support for diff scan style iteration
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11860 )
Change subject: (05/05) delta_applier: support for diff scan style iteration
......................................................................
(05/05) delta_applier: support for diff scan style iteration
This patch incorporates all of the previous work to provide diff scan
support for an entire DiskRowSet. There's a new "fuzzy" test in
diskrowset-test that exercises this functionality.
Change-Id: I895350a3c7728df88a87a36b904ffdea4f3f6b7a
Reviewed-on: http://gerrit.cloudera.org:8080/11860
Tested-by: Kudu Jenkins
Reviewed-by: Mike Percy <mp...@apache.org>
---
M src/kudu/tablet/delta_applier.cc
M src/kudu/tablet/delta_applier.h
M src/kudu/tablet/delta_tracker.cc
M src/kudu/tablet/delta_tracker.h
M src/kudu/tablet/diskrowset-test.cc
5 files changed, 294 insertions(+), 9 deletions(-)
Approvals:
Kudu Jenkins: Verified
Mike Percy: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/11860
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I895350a3c7728df88a87a36b904ffdea4f3f6b7a
Gerrit-Change-Number: 11860
Gerrit-PatchSet: 7
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] (05/05) delta applier: support for diff scan style iteration
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/11860 )
Change subject: (05/05) delta_applier: support for diff scan style iteration
......................................................................
Removed reviewer Kudu Jenkins with the following votes:
* Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/11860
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: I895350a3c7728df88a87a36b904ffdea4f3f6b7a
Gerrit-Change-Number: 11860
Gerrit-PatchSet: 4
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] (05/05) delta applier: support for diff scan style iteration
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Hello Mike Percy, David Ribeiro Alves, Kudu Jenkins, Grant Henke, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11860
to look at the new patch set (#6).
Change subject: (05/05) delta_applier: support for diff scan style iteration
......................................................................
(05/05) delta_applier: support for diff scan style iteration
This patch incorporates all of the previous work to provide diff scan
support for an entire DiskRowSet. There's a new "fuzzy" test in
diskrowset-test that exercises this functionality.
Change-Id: I895350a3c7728df88a87a36b904ffdea4f3f6b7a
---
M src/kudu/tablet/delta_applier.cc
M src/kudu/tablet/delta_applier.h
M src/kudu/tablet/delta_tracker.cc
M src/kudu/tablet/delta_tracker.h
M src/kudu/tablet/diskrowset-test.cc
5 files changed, 294 insertions(+), 9 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/60/11860/6
--
To view, visit http://gerrit.cloudera.org:8080/11860
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I895350a3c7728df88a87a36b904ffdea4f3f6b7a
Gerrit-Change-Number: 11860
Gerrit-PatchSet: 6
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] (05/05) delta applier: support for diff scan style iteration
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11860 )
Change subject: (05/05) delta_applier: support for diff scan style iteration
......................................................................
Patch Set 5:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/11860/5/src/kudu/tablet/diskrowset-test.cc
File src/kudu/tablet/diskrowset-test.cc:
http://gerrit.cloudera.org:8080/#/c/11860/5/src/kudu/tablet/diskrowset-test.cc@756
PS5, Line 756: rowid_t
uint32_t according to the schema?
http://gerrit.cloudera.org:8080/#/c/11860/5/src/kudu/tablet/diskrowset-test.cc@831
PS5, Line 831: val.get_ptr());
just wondering, do you know of coverage for nullability elsewhere?
http://gerrit.cloudera.org:8080/#/c/11860/5/src/kudu/tablet/diskrowset-test.cc@853
PS5, Line 853: oepration
operation
http://gerrit.cloudera.org:8080/#/c/11860/5/src/kudu/tablet/diskrowset-test.cc@855
PS5, Line 855: 4
3? Or should else be a no-op?
http://gerrit.cloudera.org:8080/#/c/11860/5/src/kudu/tablet/diskrowset-test.cc@885
PS5, Line 885: NO_FATALS(run_test(0, 1, {}));
Intuitively, I would think this would capture the insert by way of the delete UNDO, leaving us with 4 rows. I suppose the reason it doesn't is that we are manually concocting this test and therefore the UNDO DELETE was never created for those rows. Is that right?
Maybe worth a comment.
--
To view, visit http://gerrit.cloudera.org:8080/11860
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I895350a3c7728df88a87a36b904ffdea4f3f6b7a
Gerrit-Change-Number: 11860
Gerrit-PatchSet: 5
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Mon, 26 Nov 2018 19:32:59 +0000
Gerrit-HasComments: Yes
[kudu-CR] (05/05) delta applier: support for diff scan style iteration
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11860 )
Change subject: (05/05) delta_applier: support for diff scan style iteration
......................................................................
Patch Set 5:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/11860/5/src/kudu/tablet/diskrowset-test.cc
File src/kudu/tablet/diskrowset-test.cc:
http://gerrit.cloudera.org:8080/#/c/11860/5/src/kudu/tablet/diskrowset-test.cc@756
PS5, Line 756: rowid_t
> uint32_t according to the schema?
Whoops, done.
http://gerrit.cloudera.org:8080/#/c/11860/5/src/kudu/tablet/diskrowset-test.cc@831
PS5, Line 831: val.get_ptr());
> just wondering, do you know of coverage for nullability elsewhere?
For diff scans? I don't think so. But it'd be pretty straight-forward to add that kind of coverage to the delta fuzz tests. Not sure it adds much though; the diff scan changes are largely about delta types, timestamps, and liveness tracking. Actual update values are less relevant.
http://gerrit.cloudera.org:8080/#/c/11860/5/src/kudu/tablet/diskrowset-test.cc@853
PS5, Line 853: oepration
> operation
Done
http://gerrit.cloudera.org:8080/#/c/11860/5/src/kudu/tablet/diskrowset-test.cc@855
PS5, Line 855: 4
> 3? Or should else be a no-op?
I wanted the chance of a flush to exceed that of a compaction. I'll add a comment.
http://gerrit.cloudera.org:8080/#/c/11860/5/src/kudu/tablet/diskrowset-test.cc@885
PS5, Line 885: NO_FATALS(run_test(0, 1, {}));
> Intuitively, I would think this would capture the insert by way of the dele
That's right; I'll add a comment.
--
To view, visit http://gerrit.cloudera.org:8080/11860
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I895350a3c7728df88a87a36b904ffdea4f3f6b7a
Gerrit-Change-Number: 11860
Gerrit-PatchSet: 5
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 27 Nov 2018 00:35:23 +0000
Gerrit-HasComments: Yes
[kudu-CR] (05/05) delta applier: support for diff scan style iteration
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11860 )
Change subject: (05/05) delta_applier: support for diff scan style iteration
......................................................................
Patch Set 6:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11860/5/src/kudu/tablet/diskrowset-test.cc
File src/kudu/tablet/diskrowset-test.cc:
http://gerrit.cloudera.org:8080/#/c/11860/5/src/kudu/tablet/diskrowset-test.cc@831
PS5, Line 831: val.get_ptr());
> For diff scans? I don't think so. But it'd be pretty straight-forward to ad
I relented and pushed a new patch to do this: https://gerrit.cloudera.org/c/11994/
--
To view, visit http://gerrit.cloudera.org:8080/11860
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I895350a3c7728df88a87a36b904ffdea4f3f6b7a
Gerrit-Change-Number: 11860
Gerrit-PatchSet: 6
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 27 Nov 2018 05:14:07 +0000
Gerrit-HasComments: Yes
[kudu-CR] (05/05) delta applier: support for diff scan style iteration
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Hello Mike Percy, David Ribeiro Alves, Kudu Jenkins, Grant Henke, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11860
to look at the new patch set (#3).
Change subject: (05/05) delta_applier: support for diff scan style iteration
......................................................................
(05/05) delta_applier: support for diff scan style iteration
This patch incorporates all of the previous work to provide diff scan
support for an entire DiskRowSet. There's a new "fuzzy" test in
diskrowset-test that exercises this functionality.
Change-Id: I895350a3c7728df88a87a36b904ffdea4f3f6b7a
---
M src/kudu/tablet/delta_applier.cc
M src/kudu/tablet/delta_applier.h
M src/kudu/tablet/delta_tracker.cc
M src/kudu/tablet/delta_tracker.h
M src/kudu/tablet/diskrowset-test.cc
5 files changed, 286 insertions(+), 9 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/60/11860/3
--
To view, visit http://gerrit.cloudera.org:8080/11860
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I895350a3c7728df88a87a36b904ffdea4f3f6b7a
Gerrit-Change-Number: 11860
Gerrit-PatchSet: 3
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] (05/05) delta applier: support for diff scan style iteration
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11860 )
Change subject: (05/05) delta_applier: support for diff scan style iteration
......................................................................
Patch Set 6: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11860/5/src/kudu/tablet/diskrowset-test.cc
File src/kudu/tablet/diskrowset-test.cc:
http://gerrit.cloudera.org:8080/#/c/11860/5/src/kudu/tablet/diskrowset-test.cc@831
PS5, Line 831: val.get_ptr());
> I relented and pushed a new patch to do this: https://gerrit.cloudera.org/c
Thanks!
--
To view, visit http://gerrit.cloudera.org:8080/11860
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I895350a3c7728df88a87a36b904ffdea4f3f6b7a
Gerrit-Change-Number: 11860
Gerrit-PatchSet: 6
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 07 Dec 2018 03:47:29 +0000
Gerrit-HasComments: Yes