[jira] [Commented] (ARROW-14436) [C++] Disable color diagnostics when compiling with ccache

["Antoine Pitrou (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARROW-14436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17460927#comment-17460927 ] 

Antoine Pitrou commented on ARROW-14436:
----------------------------------------

I'm a bit surprised about this. I use ccache and have no problem with color diagnostics. Is it just because of an old version of ccache?

> [C++] Disable color diagnostics when compiling with ccache
> ----------------------------------------------------------
>
>                 Key: ARROW-14436
>                 URL: https://issues.apache.org/jira/browse/ARROW-14436
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: C++
>            Reporter: Krisztian Szucs
>            Assignee: Eduardo Ponce
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 7.0.0
>
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> Copied from https://github.com/apache/arrow/issues/11279
> Steps to reproduce:
> Compile arrow_objlib with ccache, clang and CCACHE_DEBUG=1 CCACHE_LOGFILE=./ccache.log
> Find in ./ccache.log:
> Failed; falling back to running the real compiler
> Result: unsupported compiler option
> Dropping -fcolor-diagnostics fixes the issue.
> I suggest either opting into color diagnostics with WITH_COLOR_DIAGNOSTICS or adding a way to disable it via DISABLE_COLOR_DIAGNOSTICS.
> It would be good if this wouldn't be tied to ARROW_USE_CCACHE since its also relevant for:
> -DARROW_USE_CCACHE=OFF -DCMAKE_CXX_COMPILER_LAUNCHER=emscripten_ccache.
> I can open a PR if you tell me which way you prefer.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)