[GitHub] [spark] cloud-fan commented on a change in pull request #32067: [SPARK-34962][SQL] Explicit representation of * in UpdateAction and InsertAction in MergeIntoTable

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #32067:
URL: https://github.com/apache/spark/pull/32067#discussion_r608315700



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/v2Commands.scala
##########
@@ -404,8 +404,17 @@ case class MergeIntoTable(
     mergeCondition: Expression,
     matchedActions: Seq[MergeAction],
     notMatchedActions: Seq[MergeAction]) extends BinaryCommand with SupportsSubquery {
+
+  override lazy val resolved: Boolean = {

Review comment:
       How about we simply mark `InsertStarAction` and `UpdateStarAction` as unresolved as they must be expanded during analysis? Similar to `Star`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org