[GitHub] [calcite] ritesh-kapoor commented on a change in pull request #1143: [CALCITE-2884] Add the JSON_INSERT, JSON_REPLACE, JSON_SET function

[GitBox <gi...@apache.org>]

ritesh-kapoor commented on a change in pull request #1143: [CALCITE-2884] Add the JSON_INSERT,JSON_REPLACE,JSON_SET function
URL: https://github.com/apache/calcite/pull/1143#discussion_r272629142
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java
 ##########
 @@ -2806,6 +2810,70 @@ private static Integer getJsonDepth(Object o) {
     return depth;
   }
 
+  private static String jsonPairsModify(Object jsonDoc, String type, Object... kvs) {
+    assert kvs.length % 2 == 0;
 
 Review comment:
   Please help me understand if there were challenges using JSON Path. I'm sorry if it too obvious. https://stackoverflow.com/questions/27244431/how-to-change-values-in-a-json-file-using-xpath-jsonpath-in-java

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services