You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2016/01/01 22:23:02 UTC
Review Request 41843: Moved docker spec tests to a separate file.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41843/
-----------------------------------------------------------
Review request for mesos, Gilbert Song, Jojy Varghese, and Timothy Chen.
Repository: mesos
Description
-------
Moved docker spec tests to a separate file.
This is a part of a series patchs to clean up docker related code.
Diffs
-----
src/Makefile.am b58d6b560858d318058be766456dd5c5ef98c23e
src/tests/containerizer/docker_spec_tests.cpp PRE-CREATION
src/tests/containerizer/provisioner_docker_tests.cpp d51f342dabf386fb618ef72ce3e36a8bd8c82b5f
Diff: https://reviews.apache.org/r/41843/diff/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 41843: Moved docker spec tests to a separate file.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41843/#review112418
-----------------------------------------------------------
Ship it!
Ship It!
- Gilbert Song
On Jan. 1, 2016, 1:23 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41843/
> -----------------------------------------------------------
>
> (Updated Jan. 1, 2016, 1:23 p.m.)
>
>
> Review request for mesos, Gilbert Song, Jojy Varghese, and Timothy Chen.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Moved docker spec tests to a separate file.
>
> This is a part of a series patchs to clean up docker related code.
>
>
> Diffs
> -----
>
> src/Makefile.am b58d6b560858d318058be766456dd5c5ef98c23e
> src/tests/containerizer/docker_spec_tests.cpp PRE-CREATION
> src/tests/containerizer/provisioner_docker_tests.cpp d51f342dabf386fb618ef72ce3e36a8bd8c82b5f
>
> Diff: https://reviews.apache.org/r/41843/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 41843: Moved docker spec tests to a separate file.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41843/#review112428
-----------------------------------------------------------
Patch looks great!
Reviews applied: [41839, 41840, 41841, 41842, 41843]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Jan. 1, 2016, 9:23 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41843/
> -----------------------------------------------------------
>
> (Updated Jan. 1, 2016, 9:23 p.m.)
>
>
> Review request for mesos, Gilbert Song, Jojy Varghese, and Timothy Chen.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Moved docker spec tests to a separate file.
>
> This is a part of a series patchs to clean up docker related code.
>
>
> Diffs
> -----
>
> src/Makefile.am b58d6b560858d318058be766456dd5c5ef98c23e
> src/tests/containerizer/docker_spec_tests.cpp PRE-CREATION
> src/tests/containerizer/provisioner_docker_tests.cpp d51f342dabf386fb618ef72ce3e36a8bd8c82b5f
>
> Diff: https://reviews.apache.org/r/41843/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>