[jira] [Comment Edited] (HADOOP-11293) Factor OSType out from Shell

["Colin Patrick McCabe (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-11293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14205826#comment-14205826 ] 

Colin Patrick McCabe edited comment on HADOOP-11293 at 11/11/14 2:15 AM:
-------------------------------------------------------------------------

Good idea.

How about calling this {{CurrentOperatingSystem}} instead of {{OSTypeUtil}}?   {{OSTypeUtil}} suggests that this is a class with utility methods.  But it's not, really.  Also, perhaps we should rename {{WINDOWS}} to {{IS_WINDOWS}}, and so forth.

[edit: perhaps naming this class {{OperatingSystem}} would work as well, if we use the IS_ methods everywhere.]

Also there are a bunch of unrelated whitespace changes in this patch-- let's get rid of those.


was (Author: cmccabe):
Good idea.

How about calling this {{CurrentOperatingSystem}} instead of {{OSTypeUtil}}?   {{OSTypeUtil}} suggests that this is a class with utility methods.  But it's not, really.  Also, perhaps we should rename {{WINDOWS}} to {{IS_WINDOWS}}, and so forth.

Also there are a bunch of unrelated whitespace changes in this patch-- let's get rid of those.

> Factor OSType out from Shell
> ----------------------------
>
>                 Key: HADOOP-11293
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11293
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: util
>            Reporter: Yongjun Zhang
>            Assignee: Yongjun Zhang
>         Attachments: HADOOP-11293.001.patch
>
>
> Currently the code that detects the OS type is located in Shell.java. Code that need to check OS type refers to Shell, even if no other stuff of Shell is needed. 
> I am proposing to refactor OSType out to  its own class, so to make the OSType easier to access and the dependency cleaner.
>  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)